[SQL-CVS] r1779 - in SQLObject/trunk/sqlobject: . tests

[<sub...@co...>]

Author: phd
Date: 2006-05-19 08:21:20 -0600 (Fri, 19 May 2006)
New Revision: 1779

Modified:
   SQLObject/trunk/sqlobject/sqlbuilder.py
   SQLObject/trunk/sqlobject/tests/test_joins_conditional.py
Log:
Fixed SF bug N 1472210; added a test.


Modified: SQLObject/trunk/sqlobject/sqlbuilder.py
===================================================================
--- SQLObject/trunk/sqlobject/sqlbuilder.py	2006-05-18 20:38:37 UTC (rev 1778)
+++ SQLObject/trunk/sqlobject/sqlbuilder.py	2006-05-19 14:21:20 UTC (rev 1779)
@@ -770,7 +770,7 @@
                 if hasattr(col, "__sqlrepr__"):
                     col = sqlrepr(col, db)
                 using_columns.append(col)
-            using_columns = ", ".join()
+            using_columns = ", ".join(using_columns)
             join = "%s %s USING (%s)" % (self.op, self.table2, using_columns)
             if self.table1:
                 join = "%s %s" % (self.table1, join)

Modified: SQLObject/trunk/sqlobject/tests/test_joins_conditional.py
===================================================================
--- SQLObject/trunk/sqlobject/tests/test_joins_conditional.py	2006-05-18 20:38:37 UTC (rev 1778)
+++ SQLObject/trunk/sqlobject/tests/test_joins_conditional.py	2006-05-19 14:21:20 UTC (rev 1779)
@@ -69,3 +69,13 @@
     )
     assert str(select) == \
         "SELECT test_join1.id, test_join1.col1 FROM test_join1  LEFT JOIN test_join2  LEFT JOIN test_join3 WHERE 1 = 1"
+
+def test_6join_using():
+    setup()
+    setupClass(TestJoin3)
+
+    select = TestJoin1.select(
+        join=LEFTJOINUsing(None, TestJoin2, [TestJoin2.q.id])
+    )
+    assert str(select) == \
+        "SELECT test_join1.id, test_join1.col1 FROM test_join1 LEFT JOIN test_join2 USING (test_join2.id) WHERE 1 = 1"