|
From: SourceForge.net <no...@so...> - 2006-04-06 14:39:47
|
Patches item #1458925, was opened at 2006-03-27 01:35 Message generated for change (Comment added) made by phd You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1458925&group_id=74338 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed Resolution: Invalid Priority: 5 Submitted By: Cody Pisto (cpisto) Assigned to: Oleg Broytmann (phd) Summary: Fix for bug 1458595 (destroySelf in Transaction = deadlock) Initial Comment: This patch fixes bug 1458595, in which actions that resulted in Transaction._SO_delete being called resulted in an additional database connection being opened, causing a deadlock while multiple connections await on eachothers commit. This patch is against svn trunk, r1668. (dbconnection.py) ---------------------------------------------------------------------- >Comment By: Oleg Broytmann (phd) Date: 2006-04-06 18:39 Message: Logged In: YES user_id=4799 Ok, I'll apply and test it... ---------------------------------------------------------------------- Comment By: Cody Pisto (cpisto) Date: 2006-04-05 22:41 Message: Logged In: YES user_id=118227 Luke's fix looks good, solves the problem my patch addresses, and resolves the duplication of code the patch incurred. ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2006-04-05 18:34 Message: Logged In: YES user_id=4799 Cody, any opinion on the alternate fix? ---------------------------------------------------------------------- Comment By: Luke Opperman (luke_opperman) Date: 2006-04-04 21:31 Message: Logged In: YES user_id=1393478 See patch #1464379 ---------------------------------------------------------------------- Comment By: Cody Pisto (cpisto) Date: 2006-03-28 18:32 Message: Logged In: YES user_id=118227 sorry, lost track of time, patch will follow today ;) ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2006-03-28 16:21 Message: Logged In: YES user_id=4799 Problems? :) ---------------------------------------------------------------------- Comment By: Cody Pisto (cpisto) Date: 2006-03-27 19:45 Message: Logged In: YES user_id=118227 Sure, ill refactor- Revised patch will follow this evening. ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2006-03-27 18:46 Message: Logged In: YES user_id=4799 Your patch duplicates the query from DBAPI._SO_delete() to Transaction._SO_delete(). Would you mind to refactor your patch - split DBAPI._SO_delete() into two methods - one to generate a query string, and another to execute the query; then use the first method to generate a query in the Transaction._SO_delete()? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1458925&group_id=74338 |
