|
From: SourceForge.net <no...@so...> - 2006-03-28 12:18:27
|
Patches item #1450568, was opened at 2006-03-15 20:58 Message generated for change (Comment added) made by phd You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1450568&group_id=74338 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Submitted By: Davide Alberani (alberanid) >Assigned to: Oleg Broytmann (phd) Summary: faster sqlbuilder.Insert Initial Comment: In the attachment, a very simple patch to improve performances (about 12 times faster, with a list of ~20000 items, tested with python2.3) of the sqlbuilder.Insert class, when a very long valueList list is provided. ---------------------------------------------------------------------- >Comment By: Oleg Broytmann (phd) Date: 2006-03-28 16:18 Message: Logged In: YES user_id=4799 Applied in the revision 1672 in the trunk. Thank you! ---------------------------------------------------------------------- Comment By: Davide Alberani (alberanid) Date: 2006-03-28 00:50 Message: Logged In: YES user_id=170840 I've extended the test_insert() function of the test_converters.py file; you can find the new function in the attached "insert_tests.py" file. Now some common conditions are tested. It seems to works correctly, and the patch was really simple, but better safe than sorry. :-) If you need something else, feel free to ask. ---------------------------------------------------------------------- Comment By: Oleg Broytmann (phd) Date: 2006-03-27 18:37 Message: Logged In: YES user_id=4799 Please add some tests so I can run them before and after applying the patch and verify that the patch doesn't break Insert(). ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1450568&group_id=74338 |
