[SQL-CVS] [ sqlobject-Patches-1422132 ] [patch] selectBy(nonexistantcolumn=foo) passes silently

[SourceForge.net <no...@so...>]

Patches item #1422132, was opened at 2006-02-02 06:44
Message generated for change (Settings changed) made by phd
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1422132&group_id=74338

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Accepted
Priority: 5
Submitted By: Stephen Thorne (jerub)
>Assigned to: Oleg Broytmann (phd)
Summary: [patch] selectBy(nonexistantcolumn=foo) passes silently

Initial Comment:
When doing a query on a table, for instance:

Foo.selectBy(food="bar")

where 'food' is a typo, and 'foo' is the correct column
name, no error will occur, and this is equivilnet to:

Foo.select()

Attached is a patch to both dbconnection.py and
tests/test_select.py, adding an exception to the code
for the case where unexpected kwargs are passed, and a
test for that behaviour.

----------------------------------------------------------------------

>Comment By: Oleg Broytmann (phd)
Date: 2006-02-03 22:07

Message:
Logged In: YES 
user_id=4799

Applied to the revision 1560 to the trunk, r1561 to the
0.7-branch. Thank you!

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=540674&aid=1422132&group_id=74338