[SQL-CVS] r1529 - in SQLObject/trunk/sqlobject: sqlite tests

[<sub...@co...>]

Author: phd
Date: 2006-01-23 05:55:29 -0700 (Mon, 23 Jan 2006)
New Revision: 1529

Modified:
   SQLObject/trunk/sqlobject/sqlite/sqliteconnection.py
   SQLObject/trunk/sqlobject/tests/dbtest.py
   SQLObject/trunk/sqlobject/tests/test_auto.py
   SQLObject/trunk/sqlobject/tests/test_auto_old.py
Log:
Implemented addColumn() for SQLite. Added empty delColumn() for tests.


Modified: SQLObject/trunk/sqlobject/sqlite/sqliteconnection.py
===================================================================
--- SQLObject/trunk/sqlobject/sqlite/sqliteconnection.py	2006-01-23 07:53:24 UTC (rev 1528)
+++ SQLObject/trunk/sqlobject/sqlite/sqliteconnection.py	2006-01-23 12:55:29 UTC (rev 1529)
@@ -202,5 +202,13 @@
     def createIndexSQL(self, soClass, index):
         return index.sqliteCreateIndexSQL(soClass)
 
+    def addColumn(self, tableName, column):
+        self.query('ALTER TABLE %s ADD COLUMN %s' %
+                   (tableName,
+                    column.sqliteCreateSQL()))
+
+    def delColumn(self, tableName, column):
+        pass # Oops! There is no DROP COLUMN in SQLite
+
 def stop_pysqlite2_converting_strings_to_unicode(s):
     return s

Modified: SQLObject/trunk/sqlobject/tests/dbtest.py
===================================================================
--- SQLObject/trunk/sqlobject/tests/dbtest.py	2006-01-23 07:53:24 UTC (rev 1528)
+++ SQLObject/trunk/sqlobject/tests/dbtest.py	2006-01-23 12:55:29 UTC (rev 1529)
@@ -35,7 +35,6 @@
     '+restrictedEnum': 'postgres',
     '-transactions': 'mysql',
     '-dropTableCascade': 'sybase mssql',
-    '-dynamicColumn': 'sqlite sybase',
     '-fromDatabase': 'sqlite sybase firebird',
     '-expressionIndex': 'mysql sqlite firebird mssql',
     '-blobData': 'mssql',

Modified: SQLObject/trunk/sqlobject/tests/test_auto.py
===================================================================
--- SQLObject/trunk/sqlobject/tests/test_auto.py	2006-01-23 07:53:24 UTC (rev 1528)
+++ SQLObject/trunk/sqlobject/tests/test_auto.py	2006-01-23 12:55:29 UTC (rev 1529)
@@ -39,8 +39,6 @@
                 list(Person.select('all', orderBy=Person.sqlmeta.defaultOrder)))
 
     def test_dynamicColumn(self):
-        if not supports('dynamicColumn'):
-            return
         nickname = StringCol('nickname', length=10)
         Person.sqlmeta.addColumn(nickname, changeSchema=True)
         n = Person(name='robert', nickname='bob')
@@ -49,8 +47,6 @@
         Person.sqlmeta.delColumn(nickname, changeSchema=True)
 
     def test_dynamicJoin(self):
-        if not supports('dynamicColumn'):
-            return
         col = KeyCol('personID', foreignKey='Person')
         Phone.sqlmeta.addColumn(col, changeSchema=True)
         join = MultipleJoin('Phone')

Modified: SQLObject/trunk/sqlobject/tests/test_auto_old.py
===================================================================
--- SQLObject/trunk/sqlobject/tests/test_auto_old.py	2006-01-23 07:53:24 UTC (rev 1528)
+++ SQLObject/trunk/sqlobject/tests/test_auto_old.py	2006-01-23 12:55:29 UTC (rev 1529)
@@ -41,8 +41,6 @@
                 list(OldPerson.select('all', orderBy=OldPerson.sqlmeta.defaultOrder)))
 
     def test_dynamicColumn(self):
-        if not supports('dynamicColumn'):
-            return
         nickname = StringCol('nickname', length=10)
         OldPerson.addColumn(nickname, changeSchema=True)
         n = OldPerson(name='robert', nickname='bob')
@@ -51,8 +49,6 @@
         OldPerson.delColumn(nickname, changeSchema=True)
 
     def test_dynamicJoin(self):
-        if not supports('dynamicColumn'):
-            return
         col = KeyCol('oldPersonID', foreignKey='OldPerson')
         OldPhone.addColumn(col, changeSchema=True)
         join = MultipleJoin('OldPhone')