Re: [SQLObject] Flake8 fixes

[Ian C. <gra...@gm...>]

On Mon, Jan 5, 2015 at 6:50 AM, Oleg Broytman <ph...@ph...> wrote:
> Hello, All!
>
>    Ian Cordasco and I split the work on flake8 fixes by error number. If
> you want to help developing SQLObject see issues marked with [flake8] at
> https://github.com/sqlobject/sqlobject/issues . The simpler issues
> (lower number of lines) are also labeled "low-hanging fruit":
> https://github.com/sqlobject/sqlobject/issues?q=is%3Aopen+label%3A%22low-hanging+fruit%22
>
>    The recommended workflow:
>
> 1. Announce here you want to work on an issue; I'll assign the issue to
> you. This is to avoid duplication of effort.

FWIW, this is (in my opinion) the biggest limitation of GitHub's issue
tracking system. You can only assign an issue to someone who has push
access to the repository.

> 2. Fix the problems in the code. If the description in the issue isn't
> detailed enough -- I can show the exact lines in the files.
>
> 3. Test with flake8 (I use vim-flake8 plugin but that's up to you). If
> the error is ignored in setup.cfg -- remove it before testing; remove
> both the comment and the error from "ignore" list.
>
> 3. Commit to branch "flake8-fixes"; do ``git pull --rebase`` before
> pushing, then ``git push origin flake8-fixes``. Create a pull request
> from your commit.

If you do not want to use GitHub, you can do:

   git format-patch -n HEAD^

And then email the list with the patch file. I, or someone else will
be able to apply it and create a PR for you. You will still appear as
the author and receive credit for your work.

> 4. Please do one commit per issue. The biggest issues (with hundreds
> lines) perhaps require a few commits. Make your commit message something
> like "Fix #xxx flake8 Eyyy", where #xxx is the issue's number and yyy is
> the error; for example "Fix #50 flake8 E401". "Fix #xxx" makes github
> automatically close the issue.
>
>    The list of errors sorted by the number of lines:
>
>     825 E302
>     469 E501
>     168 F403
>     149 E265
>     123 E225
>     120 E128
>     116 E301
>      72 E261
>      68 E231
>      43 F841
>      42 F401
>      40 E127
>      36 E701
>      33 E221
>      27 E502
>      27 E126
>      26 F821
>      22 E202
>      22 E201
>      19 W293
>      16 E129
>      16 E111
>      11 F402
>      11 E303
>      11 E203
>       9 W391
>       9 E122
>       8 E251
>       7 W291
>       7 E713
>       6 W603
>       6 E124
>       5 E712
>       5 E711
>       5 E228
>       4 E271
>       4 E211
>       4 E121
>       3 F812
>       3 E401
>       3 E222
>       2 F822
>
> Oleg.
> --
>      Oleg Broytman            http://phdru.name/            ph...@ph...
>            Programmers don't die, they just GOSUB without RETURN.
>
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming! The Go Parallel Website,
> sponsored by Intel and developed in partnership with Slashdot Media, is your
> hub for all things parallel software development, from weekly thought
> leadership blogs to news, videos, case studies, tutorials and more. Take a
> look and join the conversation now. http://goparallel.sourceforge.net
> _______________________________________________
> sqlobject-discuss mailing list
> sql...@li...
> https://lists.sourceforge.net/lists/listinfo/sqlobject-discuss