[SQL-CVS] r3847 - in SQLObject/branches/0.10: docs sqlobject sqlobject/inheritance sqlobject/inheritance/tests

[<sub...@co...>]

Author: phd
Date: 2009-04-09 12:23:47 -0600 (Thu, 09 Apr 2009)
New Revision: 3847

Modified:
   SQLObject/branches/0.10/docs/News.txt
   SQLObject/branches/0.10/sqlobject/inheritance/__init__.py
   SQLObject/branches/0.10/sqlobject/inheritance/tests/test_asdict.py
   SQLObject/branches/0.10/sqlobject/main.py
Log:
Fixed a bug 2744934: sqlmeta.getColumns() becomes classmethod.


Modified: SQLObject/branches/0.10/docs/News.txt
===================================================================
--- SQLObject/branches/0.10/docs/News.txt	2009-04-07 04:08:56 UTC (rev 3846)
+++ SQLObject/branches/0.10/docs/News.txt	2009-04-09 18:23:47 UTC (rev 3847)
@@ -12,6 +12,8 @@
 
 * A number of changes ported from `SQLObject 0.9.10`_.
 
+* sqlmeta.getColumns() becomes classmethod.
+
 SQLObject 0.10.4
 ================
 

Modified: SQLObject/branches/0.10/sqlobject/inheritance/__init__.py
===================================================================
--- SQLObject/branches/0.10/sqlobject/inheritance/__init__.py	2009-04-07 04:08:56 UTC (rev 3846)
+++ SQLObject/branches/0.10/sqlobject/inheritance/__init__.py	2009-04-09 18:23:47 UTC (rev 3847)
@@ -218,12 +218,14 @@
             columns.update(sm.parentClass.sqlmeta.columns)
             sm = sm.parentClass.sqlmeta
         return columns
+    getAllColumns = classmethod(getAllColumns)
 
     def getColumns(sqlmeta):
         columns = sqlmeta.getAllColumns()
         if columns.has_key('childName'):
             del columns['childName']
         return columns
+    getColumns = classmethod(getColumns)
 
 
 class InheritableSQLObject(SQLObject):

Modified: SQLObject/branches/0.10/sqlobject/inheritance/tests/test_asdict.py
===================================================================
--- SQLObject/branches/0.10/sqlobject/inheritance/tests/test_asdict.py	2009-04-07 04:08:56 UTC (rev 3846)
+++ SQLObject/branches/0.10/sqlobject/inheritance/tests/test_asdict.py	2009-04-09 18:23:47 UTC (rev 3847)
@@ -17,6 +17,17 @@
     _inheritable = False
     position = StringCol()
 
+def test_getColumns():
+    setupClass([InheritablePerson, Boss, Employee])
+
+    for klass, columns in (
+            (InheritablePerson, ['first', 'last']),
+            (Boss, ['department', 'first', 'last']),
+            (Employee, ['first', 'last', 'position'])):
+        _columns = klass.sqlmeta.getColumns().keys()
+        _columns.sort()
+        assert _columns == columns
+
 def test_asDict():
     setupClass([InheritablePerson, Boss, Employee])
     InheritablePerson(first='Oneof', last='Authors')

Modified: SQLObject/branches/0.10/sqlobject/main.py
===================================================================
--- SQLObject/branches/0.10/sqlobject/main.py	2009-04-07 04:08:56 UTC (rev 3846)
+++ SQLObject/branches/0.10/sqlobject/main.py	2009-04-09 18:23:47 UTC (rev 3847)
@@ -610,6 +610,7 @@
 
     def getColumns(sqlmeta):
         return sqlmeta.columns.copy()
+    getColumns = classmethod(getColumns)
 
     def asDict(self):
         """