From: Conan A. <co...@wa...> - 2005-04-28 21:06:38
|
Thanks for the response. A few comments: > > Conan Albrecht wrote: >> - In the documentation, that active handler example has an extra >> slash at the top ([[\\). I don't think that was intentional? > > It's intentional -- that's a "class chunk:" > http://69.60.123.152/docs/doc-lang_chunkc.html > Since a lot of people come to python from java, it might be useful to mention in the docs that this is the equivalent of <%! ... %>. Any JSP developer would immediately know what it means. > >> - The use of the self keyword in active handlers makes me wonder if >> they have to go to the same page. Is this true or false? > > True. It would require a much more sophisticated compiler to be > otherwise. But, having developed applications in an environment with > a similar limitation (ASP.NET), it's not really a problem. You can > still redirect in the handler. (The to-do demo does this in at least > one place.) The redirect is a great idea. In fact, it almost makes sense to put handlers right in the same file if you then redirect to another page. This is almost like a controller! Perhaps we should put in the docs the idea of redirection. It would have immediately calmed my fears about it. > >> - We need an explicit message somewhere about the change in absolute >> paths (includes, redirects, etc) to the web root. This is going to >> break a lot of people's installations. They need to know about it >> before installing so it doesn't come as a surprise. Where is the >> best location to put it? > > It's in the changelog; if I were upgrading that seems like the logical > place to look. Backwards incompatibilities are *d for convenience. > I'll add an "important incompatibilities" section to make it stand out > even more. Thanks for adding the "important incompatibilities" section. I know we are supposed to read the changelog, but a lot of people don't. Of course, I read them thoroughly...right after I study the license agreement for a while. :) j/k > >> - I still maintain that we need a struts-like front controller >> included in the main spyce distribution. Perhaps we can modify >> active handlers to be controller-supported. For example, the handler >> function could be in a regular python file and then a view returned. > > I'm not sure how that differs in principle from what 2.0 gives you in > the form of handler-plus-redirect. (Handlers can be in separate .py > files; spyce will even auto-import them for you: > http://69.60.123.152/docs/doc-tag_form.html#submit; also > http://69.60.123.152/docs/doc-lang_handlers.html) > Agreed. The handler-plus-redirect really does this idea well. |