|
From: Washusen, D. <Dan...@se...> - 2005-03-22 22:39:19
|
Hi Juergen, The version I was looking at (hibernate3) has a since of 1.2. I mistakenly presumed it was new; backward-compatibility is a very good reason not to change it... =0D I was trying to make an implementation of AbstractLobType that didn't read everything into memory. The code is available here (http://forum.springframework.org/viewtopic.php?t=3D4237). I was going to use the owner to generate a hash to use as a temporary file name... =0D I guess I'll re-implement the logic in AbstractLobType... =0D Cheers, Dan =0D =0D ________________________________ From: spr...@li... [mailto:spr...@li...] On Behalf Of Juergen Hoeller Sent: Tuesday, 22 March 2005 5:32 PM To: spr...@li... Subject: Re: [Springframework-developer] AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is missing a parameter... =0D Hi Dan, =0D I guess there simply hasn't been a need to access the owner object in one of the subclasses yet. AbstractLobType mainly serves as base class for the concrete LOB types that we ship in Spring, which don't need owner access. =0D The problem is that the "nullSafeGetInternal" method would have to change in a non-backwards-compatible fashion to expose the owner, so I'm reluctant to change this without a compelling reason. =0D Juergen =0D =0D -----Original Message----- From: spr...@li... [mailto:spr...@li...]On Behalf Of Washusen, Dan Sent: Tuesday, March 22, 2005 4:05 AM To: spr...@li... Subject: [Springframework-developer] AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is missing a parameter... Hey guys,=0D I'm trying to use the new org.springframework.orm.hibernate3.support.AbstractLobType and I'm wondering why the nullSafeGet implementation doesn't pass the owner parameter to the abstract nullSafeGetInternal method. =0D Should I raise a Jira issue? =0D Cheers, Dan www.about.sensis.com.au A leading Australian advertising, information and directories business. www.sensis.com.au www.yellowpages.com.au www.whitepages.com.au www.citysearch.com.au www.whereis.com.au www.telstra.com.au www.tradingpost.com.au This email and any attachments are intended only for the use of the recipient and may be confidential and/or legally privileged. Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, loss and/or damage arising from using, opening or transmitting this email. If you are not the intended recipient you must not use, interfere with, disclose, copy or retain this email and you should notify the sender immediately by return email or by contacting Sensis Pty Ltd by telephone on [+61 3 8653 5000] =0D www.about.sensis.com.au A leading Australian advertising, information and directories business. www.sensis.com.au www.yellowpages.com.au www.whitepages.com.au www.citysearch.com.au www.whereis.com.au www.telstra.com.au www.tradingpost.com.au This email and any attachments are intended only for the use of the= recipient and may be confidential and/or legally privileged. Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, loss= and/or damage arising from using, opening or transmitting this email. If you are not the intended recipient you must not use, interfere with,= disclose, copy or retain this email and you should notify the sender= immediately by return email or by contacting Sensis Pty Ltd by telephone= on [+61 3 8653 5000] |
|
From: Washusen, D. <Dan...@se...> - 2005-03-23 22:25:51
|
It would make the upgrade from Hibernate 2 to Hibernate 3 a little harder. Although, I wouldn't think many people have custom implementations of AbstractLobType... =0D ________________________________ From: spr...@li... [mailto:spr...@li...] On Behalf Of Juergen Hoeller Sent: Thursday, 24 March 2005 12:59 AM To: spr...@li... Subject: Re: [Springframework-developer] AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is missing a parameter... =0D Well, backwards compatibility just affects the Hibernate 2.x version. The Hibernate3 version was migrated straight from that. We could add the owner object in the Hibernate3 version; after all, we haven't officially release the Hibernate3 support yet, so are not constrained by backwards compatibility there. =0D Juergen =0D =0D -----Original Message----- From: spr...@li... [mailto:spr...@li...]On Behalf Of Washusen, Dan Sent: Tuesday, March 22, 2005 11:39 PM To: spr...@li... Subject: RE: [Springframework-developer] AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is missing a parameter... Hi Juergen, The version I was looking at (hibernate3) has a since of 1.2. I mistakenly presumed it was new; backward-compatibility is a very good reason not to change it... =0D I was trying to make an implementation of AbstractLobType that didn't read everything into memory. The code is available here (http://forum.springframework.org/viewtopic.php?t=3D4237). I was going to use the owner to generate a hash to use as a temporary file name... =0D I guess I'll re-implement the logic in AbstractLobType... =0D Cheers, Dan =0D =0D =0D ________________________________ From: spr...@li... [mailto:spr...@li...] On Behalf Of Juergen Hoeller Sent: Tuesday, 22 March 2005 5:32 PM To: spr...@li... Subject: Re: [Springframework-developer] AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is missing a parameter... =0D Hi Dan, =0D I guess there simply hasn't been a need to access the owner object in one of the subclasses yet. AbstractLobType mainly serves as base class for the concrete LOB types that we ship in Spring, which don't need owner access. =0D The problem is that the "nullSafeGetInternal" method would have to change in a non-backwards-compatible fashion to expose the owner, so I'm reluctant to change this without a compelling reason. =0D Juergen =0D =0D -----Original Message----- From: spr...@li... [mailto:spr...@li...]On Behalf Of Washusen, Dan Sent: Tuesday, March 22, 2005 4:05 AM To: spr...@li... Subject: [Springframework-developer] AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is missing a parameter... Hey guys,=0D I'm trying to use the new org.springframework.orm.hibernate3.support.AbstractLobType and I'm wondering why the nullSafeGet implementation doesn't pass the owner parameter to the abstract nullSafeGetInternal method. =0D Should I raise a Jira issue? =0D Cheers, Dan www.about.sensis.com.au A leading Australian advertising, information and directories business. www.sensis.com.au www.yellowpages.com.au www.whitepages.com.au www.citysearch.com.au www.whereis.com.au www.telstra.com.au www.tradingpost.com.au This email and any attachments are intended only for the use of the recipient and may be confidential and/or legally privileged. Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, loss and/or damage arising from using, opening or transmitting this email. If you are not the intended recipient you must not use, interfere with, disclose, copy or retain this email and you should notify the sender immediately by return email or by contacting Sensis Pty Ltd by telephone on [+61 3 8653 5000] =0D www.about.sensis.com.au A leading Australian advertising, information and directories business. www.sensis.com.au www.yellowpages.com.au www.whitepages.com.au www.citysearch.com.au www.whereis.com.au www.telstra.com.au www.tradingpost.com.au This email and any attachments are intended only for the use of the recipient and may be confidential and/or legally privileged. Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, loss and/or damage arising from using, opening or transmitting this email. If you are not the intended recipient you must not use, interfere with, disclose, copy or retain this email and you should notify the sender immediately by return email or by contacting Sensis Pty Ltd by telephone on [+61 3 8653 5000] =0D www.about.sensis.com.au A leading Australian advertising, information and directories business. www.sensis.com.au www.yellowpages.com.au www.whitepages.com.au www.citysearch.com.au www.whereis.com.au www.telstra.com.au www.tradingpost.com.au This email and any attachments are intended only for the use of the= recipient and may be confidential and/or legally privileged. Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, loss= and/or damage arising from using, opening or transmitting this email. If you are not the intended recipient you must not use, interfere with,= disclose, copy or retain this email and you should notify the sender= immediately by return email or by contacting Sensis Pty Ltd by telephone= on [+61 3 8653 5000] |
|
From: Colin S. <col...@ex...> - 2005-03-23 22:57:45
|
I doubt there are many people subclassing it, and it would be trivial for anybody making the change to fix-up their code for the difference. They're going to be modifying their code anyway to account for package changes. Colin Washusen, Dan wrote: > It would make the upgrade from Hibernate 2 to Hibernate 3 a little > harder. Although, I wouldn’t think many people have custom > implementations of AbstractLobType… > > ------------------------------------------------------------------------ > > *From:* spr...@li... > [mailto:spr...@li...] *On > Behalf Of *Juergen Hoeller > *Sent:* Thursday, 24 March 2005 12:59 AM > *To:* spr...@li... > *Subject:* Re: [Springframework-developer] > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is > missing a parameter... > > Well, backwards compatibility just affects the Hibernate 2.x version. > The Hibernate3 version was migrated straight from that. We could add > the owner object in the Hibernate3 version; after all, we haven't > officially release the Hibernate3 support yet, so are not constrained > by backwards compatibility there. > > Juergen > > -----Original Message----- > *From:* spr...@li... > [mailto:spr...@li...]*On > Behalf Of *Washusen, Dan > *Sent:* Tuesday, March 22, 2005 11:39 PM > *To:* spr...@li... > *Subject:* RE: [Springframework-developer] > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) > is missing a parameter... > > Hi Juergen, > > The version I was looking at (hibernate3) has a since of 1.2. I > mistakenly presumed it was new; backward-compatibility is a very > good reason not to change it... > > I was trying to make an implementation of AbstractLobType that > didn’t read everything into memory. The code is available here > (http://forum.springframework.org/viewtopic.php?t=4237). I was > going to use the owner to generate a hash to use as a temporary > file name… > > I guess I’ll re-implement the logic in AbstractLobType… > > Cheers, > > Dan > > ------------------------------------------------------------------------ > > *From:* spr...@li... > [mailto:spr...@li...] *On > Behalf Of *Juergen Hoeller > *Sent:* Tuesday, 22 March 2005 5:32 PM > *To:* spr...@li... > *Subject:* Re: [Springframework-developer] > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) > is missing a parameter... > > Hi Dan, > > I guess there simply hasn't been a need to access the owner object > in one of the subclasses yet. AbstractLobType mainly serves as > base class for the concrete LOB types that we ship in Spring, > which don't need owner access. > > The problem is that the "nullSafeGetInternal" method would have to > change in a non-backwards-compatible fashion to expose the owner, > so I'm reluctant to change this without a compelling reason. > > Juergen > > -----Original Message----- > *From:* spr...@li... > [mailto:spr...@li...]*On > Behalf Of *Washusen, Dan > *Sent:* Tuesday, March 22, 2005 4:05 AM > *To:* spr...@li... > *Subject:* [Springframework-developer] > AbstractLobType#nullSafeGetInternal((ResultSet, int, > LobHandler) is missing a parameter... > > Hey guys, > > I’m trying to use the new > org.springframework.orm.hibernate3.support.AbstractLobType and > I’m wondering why the nullSafeGet implementation doesn’t pass > the owner parameter to the abstract nullSafeGetInternal method. > > Should I raise a Jira issue? > > Cheers, > > Dan > >www.about.sensis.com.au > >A leading Australian advertising, information and directories business. > >www.sensis.com.au > >www.yellowpages.com.au > >www.whitepages.com.au > >www.citysearch.com.au > >www.whereis.com.au > >www.telstra.com.au > >www.tradingpost.com.au > >This email and any attachments are intended only for the use of the recipient and may be confidential and/or legally privileged. > >Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, loss and/or damage arising from using, opening or transmitting this email. > >If you are not the intended recipient you must not use, interfere with, disclose, copy or retain this email and you should notify the sender immediately by return email or by contacting Sensis Pty Ltd by telephone on [+61 3 8653 5000] > >www.about.sensis.com.au > >A leading Australian advertising, information and directories business. > >www.sensis.com.au > >www.yellowpages.com.au > >www.whitepages.com.au > >www.citysearch.com.au > >www.whereis.com.au > >www.telstra.com.au > >www.tradingpost.com.au > >This email and any attachments are intended only for the use of the recipient and may be confidential and/or legally privileged. > >Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, loss and/or damage arising from using, opening or transmitting this email. > >If you are not the intended recipient you must not use, interfere with, disclose, copy or retain this email and you should notify the sender immediately by return email or by contacting Sensis Pty Ltd by telephone on [+61 3 8653 5000] > >www.about.sensis.com.au >A leading Australian advertising, information and directories business. >www.sensis.com.au >www.yellowpages.com.au >www.whitepages.com.au >www.citysearch.com.au >www.whereis.com.au >www.telstra.com.au >www.tradingpost.com.au >This email and any attachments are intended only for the use of the recipient and may be confidential and/or legally privileged. >Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, loss and/or damage arising from using, opening or transmitting this email. >If you are not the intended recipient you must not use, interfere with, disclose, copy or retain this email and you should notify the sender immediately by return email or by contacting Sensis Pty Ltd by telephone on [+61 3 8653 5000] > > |
|
From: Juergen H. <ju...@in...> - 2005-03-25 08:44:35
|
FYI, I've extended the signature of AbstractLobType's "nullSafeGetInternal" to include the owner object and also the full array of column names as passed in by Hibernate. The concrete subclasses that we ship don't use those, so this is only meant for custom subclasses. I've only applied this change to the Hibernate3 support. I don't think that it is necessary to perform an analogous change in the Hibernate2 support. After all, noone has asked for it before; I assume that new developments will use Hibernate3 anyway. I've committed the change yesterday evening; this will make it into 1.2 RC1! Juergen -----Original Message----- From: spr...@li... [mailto:spr...@li...]On Behalf Of Colin Sampaleanu Sent: Wednesday, March 23, 2005 11:58 PM To: spr...@li... Subject: Re: [Springframework-developer] AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is missing a parameter... I doubt there are many people subclassing it, and it would be trivial for anybody making the change to fix-up their code for the difference. They're going to be modifying their code anyway to account for package changes. Colin Washusen, Dan wrote: > It would make the upgrade from Hibernate 2 to Hibernate 3 a little > harder. Although, I wouldn’t think many people have custom > implementations of AbstractLobType… > > ------------------------------------------------------------------------ > > *From:* spr...@li... > [mailto:spr...@li...] *On > Behalf Of *Juergen Hoeller > *Sent:* Thursday, 24 March 2005 12:59 AM > *To:* spr...@li... > *Subject:* Re: [Springframework-developer] > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is > missing a parameter... > > Well, backwards compatibility just affects the Hibernate 2.x version. > The Hibernate3 version was migrated straight from that. We could add > the owner object in the Hibernate3 version; after all, we haven't > officially release the Hibernate3 support yet, so are not constrained > by backwards compatibility there. > > Juergen > > -----Original Message----- > *From:* spr...@li... > [mailto:spr...@li...]*On > Behalf Of *Washusen, Dan > *Sent:* Tuesday, March 22, 2005 11:39 PM > *To:* spr...@li... > *Subject:* RE: [Springframework-developer] > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) > is missing a parameter... > > Hi Juergen, > > The version I was looking at (hibernate3) has a since of 1.2. I > mistakenly presumed it was new; backward-compatibility is a very > good reason not to change it... > > I was trying to make an implementation of AbstractLobType that > didn’t read everything into memory. The code is available here > (http://forum.springframework.org/viewtopic.php?t=4237). I was > going to use the owner to generate a hash to use as a temporary > file name… > > I guess I’ll re-implement the logic in AbstractLobType… > > Cheers, > > Dan > > ---------------------------------------------------------------------- -- > > *From:* spr...@li... > [mailto:spr...@li...] *On > Behalf Of *Juergen Hoeller > *Sent:* Tuesday, 22 March 2005 5:32 PM > *To:* spr...@li... > *Subject:* Re: [Springframework-developer] > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) > is missing a parameter... > > Hi Dan, > > I guess there simply hasn't been a need to access the owner object > in one of the subclasses yet. AbstractLobType mainly serves as > base class for the concrete LOB types that we ship in Spring, > which don't need owner access. > > The problem is that the "nullSafeGetInternal" method would have to > change in a non-backwards-compatible fashion to expose the owner, > so I'm reluctant to change this without a compelling reason. > > Juergen > > -----Original Message----- > *From:* spr...@li... > [mailto:spr...@li...]*On > Behalf Of *Washusen, Dan > *Sent:* Tuesday, March 22, 2005 4:05 AM > *To:* spr...@li... > *Subject:* [Springframework-developer] > AbstractLobType#nullSafeGetInternal((ResultSet, int, > LobHandler) is missing a parameter... > > Hey guys, > > I’m trying to use the new > org.springframework.orm.hibernate3.support.AbstractLobType and > I’m wondering why the nullSafeGet implementation doesn’t pass > the owner parameter to the abstract nullSafeGetInternal method. > > Should I raise a Jira issue? > > Cheers, > > Dan > >www.about.sensis.com.au > >A leading Australian advertising, information and directories business. > >www.sensis.com.au > >www.yellowpages.com.au > >www.whitepages.com.au > >www.citysearch.com.au > >www.whereis.com.au > >www.telstra.com.au > >www.tradingpost.com.au > >This email and any attachments are intended only for the use of the recipient and may be confidential and/or legally privileged. > >Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, loss and/or damage arising from using, opening or transmitting this email. > >If you are not the intended recipient you must not use, interfere with, disclose, copy or retain this email and you should notify the sender immediately by return email or by contacting Sensis Pty Ltd by telephone on [+61 3 8653 5000] > >www.about.sensis.com.au > >A leading Australian advertising, information and directories business. > >www.sensis.com.au > >www.yellowpages.com.au > >www.whitepages.com.au > >www.citysearch.com.au > >www.whereis.com.au > >www.telstra.com.au > >www.tradingpost.com.au > >This email and any attachments are intended only for the use of the recipient and may be confidential and/or legally privileged. > >Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, loss and/or damage arising from using, opening or transmitting this email. > >If you are not the intended recipient you must not use, interfere with, disclose, copy or retain this email and you should notify the sender immediately by return email or by contacting Sensis Pty Ltd by telephone on [+61 3 8653 5000] > >www.about.sensis.com.au >A leading Australian advertising, information and directories business. >www.sensis.com.au >www.yellowpages.com.au >www.whitepages.com.au >www.citysearch.com.au >www.whereis.com.au >www.telstra.com.au >www.tradingpost.com.au >This email and any attachments are intended only for the use of the recipient and may be confidential and/or legally privileged. >Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, loss and/or damage arising from using, opening or transmitting this email. >If you are not the intended recipient you must not use, interfere with, disclose, copy or retain this email and you should notify the sender immediately by return email or by contacting Sensis Pty Ltd by telephone on [+61 3 8653 5000] > > ------------------------------------------------------- This SF.net email is sponsored by Microsoft Mobile & Embedded DevCon 2005 Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest Windows Embedded(r) & Windows Mobile(tm) platforms, applications & content. Register by 3/29 & save $300 http://ads.osdn.com/?ad_id=6883&alloc_id=15149&op=click _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer |
|
From: Dan W. <dan...@gm...> - 2005-03-28 05:24:51
|
Awesome, thanks Juergen... On Fri, 25 Mar 2005 09:43:53 +0100, Juergen Hoeller <ju...@in...> wrote: > FYI, I've extended the signature of AbstractLobType's "nullSafeGetInterna= l" > to include the owner object and also the full array of column names as > passed in by Hibernate. The concrete subclasses that we ship don't use > those, so this is only meant for custom subclasses. >=20 > I've only applied this change to the Hibernate3 support. I don't think th= at > it is necessary to perform an analogous change in the Hibernate2 support. > After all, noone has asked for it before; I assume that new developments > will use Hibernate3 anyway. >=20 > I've committed the change yesterday evening; this will make it into 1.2 R= C1! >=20 > Juergen >=20 > -----Original Message----- > From: spr...@li... > [mailto:spr...@li...]On Behalf > Of Colin Sampaleanu > Sent: Wednesday, March 23, 2005 11:58 PM > To: spr...@li... > Subject: Re: [Springframework-developer] > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is > missing a parameter... >=20 > I doubt there are many people subclassing it, and it would be trivial > for anybody making the change to fix-up their code for the difference. > They're going to be modifying their code anyway to account for package > changes. >=20 > Colin >=20 > Washusen, Dan wrote: >=20 > > It would make the upgrade from Hibernate 2 to Hibernate 3 a little > > harder. Although, I wouldn't think many people have custom > > implementations of AbstractLobType=85 > > > > -----------------------------------------------------------------------= - > > > > *From:* spr...@li... > > [mailto:spr...@li...] *On > > Behalf Of *Juergen Hoeller > > *Sent:* Thursday, 24 March 2005 12:59 AM > > *To:* spr...@li... > > *Subject:* Re: [Springframework-developer] > > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is > > missing a parameter... > > > > Well, backwards compatibility just affects the Hibernate 2.x version. > > The Hibernate3 version was migrated straight from that. We could add > > the owner object in the Hibernate3 version; after all, we haven't > > officially release the Hibernate3 support yet, so are not constrained > > by backwards compatibility there. > > > > Juergen > > > > -----Original Message----- > > *From:* spr...@li... > > [mailto:spr...@li...]*On > > Behalf Of *Washusen, Dan > > *Sent:* Tuesday, March 22, 2005 11:39 PM > > *To:* spr...@li... > > *Subject:* RE: [Springframework-developer] > > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) > > is missing a parameter... > > > > Hi Juergen, > > > > The version I was looking at (hibernate3) has a since of 1.2. I > > mistakenly presumed it was new; backward-compatibility is a very > > good reason not to change it... > > > > I was trying to make an implementation of AbstractLobType that > > didn't read everything into memory. The code is available here > > (http://forum.springframework.org/viewtopic.php?t=3D4237). I was > > going to use the owner to generate a hash to use as a temporary > > file name=85 > > > > I guess I'll re-implement the logic in AbstractLobType=85 > > > > Cheers, > > > > Dan > > > > -------------------------------------------------------------------= --- > -- > > > > *From:* spr...@li... > > [mailto:spr...@li...] *On > > Behalf Of *Juergen Hoeller > > *Sent:* Tuesday, 22 March 2005 5:32 PM > > *To:* spr...@li... > > *Subject:* Re: [Springframework-developer] > > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) > > is missing a parameter... > > > > Hi Dan, > > > > I guess there simply hasn't been a need to access the owner object > > in one of the subclasses yet. AbstractLobType mainly serves as > > base class for the concrete LOB types that we ship in Spring, > > which don't need owner access. > > > > The problem is that the "nullSafeGetInternal" method would have to > > change in a non-backwards-compatible fashion to expose the owner, > > so I'm reluctant to change this without a compelling reason. > > > > Juergen > > > > -----Original Message----- > > *From:* spr...@li... > > [mailto:spr...@li...]*= On > > Behalf Of *Washusen, Dan > > *Sent:* Tuesday, March 22, 2005 4:05 AM > > *To:* spr...@li... > > *Subject:* [Springframework-developer] > > AbstractLobType#nullSafeGetInternal((ResultSet, int, > > LobHandler) is missing a parameter... > > > > Hey guys, > > > > I'm trying to use the new > > org.springframework.orm.hibernate3.support.AbstractLobType and > > I'm wondering why the nullSafeGet implementation doesn't pass > > the owner parameter to the abstract nullSafeGetInternal method. > > > > Should I raise a Jira issue? > > > > Cheers, > > > > Dan > > > >www.about.sensis.com.au > > > >A leading Australian advertising, information and directories business. > > > >www.sensis.com.au > > > >www.yellowpages.com.au > > > >www.whitepages.com.au > > > >www.citysearch.com.au > > > >www.whereis.com.au > > > >www.telstra.com.au > > > >www.tradingpost.com.au > > > >This email and any attachments are intended only for the use of the > recipient and may be confidential and/or legally privileged. > > > >Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, l= oss > and/or damage arising from using, opening or transmitting this email. > > > >If you are not the intended recipient you must not use, interfere with, > disclose, copy or retain this email and you should notify the sender > immediately by return email or by contacting Sensis Pty Ltd by telephone = on > [+61 3 8653 5000] > > > >www.about.sensis.com.au > > > >A leading Australian advertising, information and directories business. > > > >www.sensis.com.au > > > >www.yellowpages.com.au > > > >www.whitepages.com.au > > > >www.citysearch.com.au > > > >www.whereis.com.au > > > >www.telstra.com.au > > > >www.tradingpost.com.au > > > >This email and any attachments are intended only for the use of the > recipient and may be confidential and/or legally privileged. > > > >Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, l= oss > and/or damage arising from using, opening or transmitting this email. > > > >If you are not the intended recipient you must not use, interfere with, > disclose, copy or retain this email and you should notify the sender > immediately by return email or by contacting Sensis Pty Ltd by telephone = on > [+61 3 8653 5000] > > > >www.about.sensis.com.au > >A leading Australian advertising, information and directories business. > >www.sensis.com.au > >www.yellowpages.com.au > >www.whitepages.com.au > >www.citysearch.com.au > >www.whereis.com.au > >www.telstra.com.au > >www.tradingpost.com.au > >This email and any attachments are intended only for the use of the > recipient and may be confidential and/or legally privileged. > >Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, l= oss > and/or damage arising from using, opening or transmitting this email. > >If you are not the intended recipient you must not use, interfere with, > disclose, copy or retain this email and you should notify the sender > immediately by return email or by contacting Sensis Pty Ltd by telephone = on > [+61 3 8653 5000] > > > > >=20 > ------------------------------------------------------- > This SF.net email is sponsored by Microsoft Mobile & Embedded DevCon 2005 > Attend MEDC 2005 May 9-12 in Vegas. Learn more about the latest Windows > Embedded(r) & Windows Mobile(tm) platforms, applications & content. > Register > by 3/29 & save $300 http://ads.osdn.com/?ad_id=3D6883&alloc_id=3D15149&op= =3Dclick > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer >=20 > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_id=3D6595&alloc_id=3D14396&op=3Dclick > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer >=20 --=20 Jar-Jar makes the Ewoks look like f*%#ing Shaft! - Tim Bisley |
|
From: Dan W. <dan...@gm...> - 2005-03-28 07:23:07
|
Hi All, I've posted an updated implementation of FileType on the forum (http://forum.springframework.org/viewtopic.php?p=3D17265#17265). I'd be interested in any feedback people might have. I'm leaning toward making the temporary file name more unique by adding a random number to the end of the owner.hashCode() value then letting the user manage the caching of files.. Cheers, Dan. =20 On Mon, 28 Mar 2005 15:24:37 +1000, Dan Washusen <dan...@gm...> w= rote: > Awesome, thanks Juergen... >=20 > On Fri, 25 Mar 2005 09:43:53 +0100, Juergen Hoeller > <ju...@in...> wrote: > > FYI, I've extended the signature of AbstractLobType's "nullSafeGetInter= nal" > > to include the owner object and also the full array of column names as > > passed in by Hibernate. The concrete subclasses that we ship don't use > > those, so this is only meant for custom subclasses. > > > > I've only applied this change to the Hibernate3 support. I don't think = that > > it is necessary to perform an analogous change in the Hibernate2 suppor= t. > > After all, noone has asked for it before; I assume that new development= s > > will use Hibernate3 anyway. > > > > I've committed the change yesterday evening; this will make it into 1.2= RC1! > > > > Juergen > > > > -----Original Message----- > > From: spr...@li... > > [mailto:spr...@li...]On Behalf > > Of Colin Sampaleanu > > Sent: Wednesday, March 23, 2005 11:58 PM > > To: spr...@li... > > Subject: Re: [Springframework-developer] > > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is > > missing a parameter... > > > > I doubt there are many people subclassing it, and it would be trivial > > for anybody making the change to fix-up their code for the difference. > > They're going to be modifying their code anyway to account for package > > changes. > > > > Colin > > > > Washusen, Dan wrote: > > > > > It would make the upgrade from Hibernate 2 to Hibernate 3 a little > > > harder. Although, I wouldn't think many people have custom > > > implementations of AbstractLobType=85 > > > > > > ---------------------------------------------------------------------= --- > > > > > > *From:* spr...@li... > > > [mailto:spr...@li...] *On > > > Behalf Of *Juergen Hoeller > > > *Sent:* Thursday, 24 March 2005 12:59 AM > > > *To:* spr...@li... > > > *Subject:* Re: [Springframework-developer] > > > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is > > > missing a parameter... > > > > > > Well, backwards compatibility just affects the Hibernate 2.x version. > > > The Hibernate3 version was migrated straight from that. We could add > > > the owner object in the Hibernate3 version; after all, we haven't > > > officially release the Hibernate3 support yet, so are not constrained > > > by backwards compatibility there. > > > > > > Juergen > > > > > > -----Original Message----- > > > *From:* spr...@li... > > > [mailto:spr...@li...]*On > > > Behalf Of *Washusen, Dan > > > *Sent:* Tuesday, March 22, 2005 11:39 PM > > > *To:* spr...@li... > > > *Subject:* RE: [Springframework-developer] > > > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) > > > is missing a parameter... > > > > > > Hi Juergen, > > > > > > The version I was looking at (hibernate3) has a since of 1.2. I > > > mistakenly presumed it was new; backward-compatibility is a very > > > good reason not to change it... > > > > > > I was trying to make an implementation of AbstractLobType that > > > didn't read everything into memory. The code is available here > > > (http://forum.springframework.org/viewtopic.php?t=3D4237). I was > > > going to use the owner to generate a hash to use as a temporary > > > file name=85 > > > > > > I guess I'll re-implement the logic in AbstractLobType=85 > > > > > > Cheers, > > > > > > Dan > > > > > > -----------------------------------------------------------------= ----- > > -- > > > > > > *From:* spr...@li... > > > [mailto:spr...@li...] *O= n > > > Behalf Of *Juergen Hoeller > > > *Sent:* Tuesday, 22 March 2005 5:32 PM > > > *To:* spr...@li... > > > *Subject:* Re: [Springframework-developer] > > > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) > > > is missing a parameter... > > > > > > Hi Dan, > > > > > > I guess there simply hasn't been a need to access the owner objec= t > > > in one of the subclasses yet. AbstractLobType mainly serves as > > > base class for the concrete LOB types that we ship in Spring, > > > which don't need owner access. > > > > > > The problem is that the "nullSafeGetInternal" method would have t= o > > > change in a non-backwards-compatible fashion to expose the owner, > > > so I'm reluctant to change this without a compelling reason. > > > > > > Juergen > > > > > > -----Original Message----- > > > *From:* spr...@li... > > > [mailto:spr...@li...= ]*On > > > Behalf Of *Washusen, Dan > > > *Sent:* Tuesday, March 22, 2005 4:05 AM > > > *To:* spr...@li... > > > *Subject:* [Springframework-developer] > > > AbstractLobType#nullSafeGetInternal((ResultSet, int, > > > LobHandler) is missing a parameter... > > > > > > Hey guys, > > > > > > I'm trying to use the new > > > org.springframework.orm.hibernate3.support.AbstractLobType an= d > > > I'm wondering why the nullSafeGet implementation doesn't pass > > > the owner parameter to the abstract nullSafeGetInternal metho= d. > > > > > > Should I raise a Jira issue? > > > > > > Cheers, > > > > > > Dan > > > |
|
From: Juergen H. <ju...@in...> - 2005-03-23 13:59:23
|
Well, backwards compatibility just affects the Hibernate 2.x version. The Hibernate3 version was migrated straight from that. We could add the owner object in the Hibernate3 version; after all, we haven't officially release the Hibernate3 support yet, so are not constrained by backwards compatibility there. Juergen -----Original Message----- From: spr...@li... [mailto:spr...@li...]On Behalf Of Washusen, Dan Sent: Tuesday, March 22, 2005 11:39 PM To: spr...@li... Subject: RE: [Springframework-developer] AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is missing a parameter... Hi Juergen, The version I was looking at (hibernate3) has a since of 1.2. I mistakenly presumed it was new; backward-compatibility is a very good reason not to change it... I was trying to make an implementation of AbstractLobType that didn't read everything into memory. The code is available here (http://forum.springframework.org/viewtopic.php?t=4237). I was going to use the owner to generate a hash to use as a temporary file name. I guess I'll re-implement the logic in AbstractLobType. Cheers, Dan ---------------------------------------------------------------------------- -- From: spr...@li... [mailto:spr...@li...] On Behalf Of Juergen Hoeller Sent: Tuesday, 22 March 2005 5:32 PM To: spr...@li... Subject: Re: [Springframework-developer] AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is missing a parameter... Hi Dan, I guess there simply hasn't been a need to access the owner object in one of the subclasses yet. AbstractLobType mainly serves as base class for the concrete LOB types that we ship in Spring, which don't need owner access. The problem is that the "nullSafeGetInternal" method would have to change in a non-backwards-compatible fashion to expose the owner, so I'm reluctant to change this without a compelling reason. Juergen -----Original Message----- From: spr...@li... [mailto:spr...@li...]On Behalf Of Washusen, Dan Sent: Tuesday, March 22, 2005 4:05 AM To: spr...@li... Subject: [Springframework-developer] AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is missing a parameter... Hey guys, I'm trying to use the new org.springframework.orm.hibernate3.support.AbstractLobType and I'm wondering why the nullSafeGet implementation doesn't pass the owner parameter to the abstract nullSafeGetInternal method. Should I raise a Jira issue? Cheers, Dan www.about.sensis.com.auA leading Australian advertising, information and directories business.www.sensis.com.auwww.yellowpages.com.auwww.whitepages.com.auwww.cit ysearch.com.auwww.whereis.com.auwww.telstra.com.auwww.tradingpost.com.auThis email and any attachments are intended only for the use of the recipient and may be confidential and/or legally privileged.Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, loss and/or damage arising from using, opening or transmitting this email.If you are not the intended recipient you must not use, interfere with, disclose, copy or retain this email and you should notify the sender immediately by return email or by contacting Sensis Pty Ltd by telephone on [+61 3 8653 5000] www.about.sensis.com.au A leading Australian advertising, information and directories business. www.sensis.com.au www.yellowpages.com.au www.whitepages.com.au www.citysearch.com.au www.whereis.com.au www.telstra.com.au www.tradingpost.com.au This email and any attachments are intended only for the use of the recipient and may be confidential and/or legally privileged. Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, loss and/or damage arising from using, opening or transmitting this email. If you are not the intended recipient you must not use, interfere with, disclose, copy or retain this email and you should notify the sender immediately by return email or by contacting Sensis Pty Ltd by telephone on [+61 3 8653 5000] |