|
From: Colin S. <col...@ex...> - 2005-03-23 22:57:45
|
I doubt there are many people subclassing it, and it would be trivial for anybody making the change to fix-up their code for the difference. They're going to be modifying their code anyway to account for package changes. Colin Washusen, Dan wrote: > It would make the upgrade from Hibernate 2 to Hibernate 3 a little > harder. Although, I wouldn’t think many people have custom > implementations of AbstractLobType… > > ------------------------------------------------------------------------ > > *From:* spr...@li... > [mailto:spr...@li...] *On > Behalf Of *Juergen Hoeller > *Sent:* Thursday, 24 March 2005 12:59 AM > *To:* spr...@li... > *Subject:* Re: [Springframework-developer] > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) is > missing a parameter... > > Well, backwards compatibility just affects the Hibernate 2.x version. > The Hibernate3 version was migrated straight from that. We could add > the owner object in the Hibernate3 version; after all, we haven't > officially release the Hibernate3 support yet, so are not constrained > by backwards compatibility there. > > Juergen > > -----Original Message----- > *From:* spr...@li... > [mailto:spr...@li...]*On > Behalf Of *Washusen, Dan > *Sent:* Tuesday, March 22, 2005 11:39 PM > *To:* spr...@li... > *Subject:* RE: [Springframework-developer] > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) > is missing a parameter... > > Hi Juergen, > > The version I was looking at (hibernate3) has a since of 1.2. I > mistakenly presumed it was new; backward-compatibility is a very > good reason not to change it... > > I was trying to make an implementation of AbstractLobType that > didn’t read everything into memory. The code is available here > (http://forum.springframework.org/viewtopic.php?t=4237). I was > going to use the owner to generate a hash to use as a temporary > file name… > > I guess I’ll re-implement the logic in AbstractLobType… > > Cheers, > > Dan > > ------------------------------------------------------------------------ > > *From:* spr...@li... > [mailto:spr...@li...] *On > Behalf Of *Juergen Hoeller > *Sent:* Tuesday, 22 March 2005 5:32 PM > *To:* spr...@li... > *Subject:* Re: [Springframework-developer] > AbstractLobType#nullSafeGetInternal((ResultSet, int, LobHandler) > is missing a parameter... > > Hi Dan, > > I guess there simply hasn't been a need to access the owner object > in one of the subclasses yet. AbstractLobType mainly serves as > base class for the concrete LOB types that we ship in Spring, > which don't need owner access. > > The problem is that the "nullSafeGetInternal" method would have to > change in a non-backwards-compatible fashion to expose the owner, > so I'm reluctant to change this without a compelling reason. > > Juergen > > -----Original Message----- > *From:* spr...@li... > [mailto:spr...@li...]*On > Behalf Of *Washusen, Dan > *Sent:* Tuesday, March 22, 2005 4:05 AM > *To:* spr...@li... > *Subject:* [Springframework-developer] > AbstractLobType#nullSafeGetInternal((ResultSet, int, > LobHandler) is missing a parameter... > > Hey guys, > > I’m trying to use the new > org.springframework.orm.hibernate3.support.AbstractLobType and > I’m wondering why the nullSafeGet implementation doesn’t pass > the owner parameter to the abstract nullSafeGetInternal method. > > Should I raise a Jira issue? > > Cheers, > > Dan > >www.about.sensis.com.au > >A leading Australian advertising, information and directories business. > >www.sensis.com.au > >www.yellowpages.com.au > >www.whitepages.com.au > >www.citysearch.com.au > >www.whereis.com.au > >www.telstra.com.au > >www.tradingpost.com.au > >This email and any attachments are intended only for the use of the recipient and may be confidential and/or legally privileged. > >Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, loss and/or damage arising from using, opening or transmitting this email. > >If you are not the intended recipient you must not use, interfere with, disclose, copy or retain this email and you should notify the sender immediately by return email or by contacting Sensis Pty Ltd by telephone on [+61 3 8653 5000] > >www.about.sensis.com.au > >A leading Australian advertising, information and directories business. > >www.sensis.com.au > >www.yellowpages.com.au > >www.whitepages.com.au > >www.citysearch.com.au > >www.whereis.com.au > >www.telstra.com.au > >www.tradingpost.com.au > >This email and any attachments are intended only for the use of the recipient and may be confidential and/or legally privileged. > >Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, loss and/or damage arising from using, opening or transmitting this email. > >If you are not the intended recipient you must not use, interfere with, disclose, copy or retain this email and you should notify the sender immediately by return email or by contacting Sensis Pty Ltd by telephone on [+61 3 8653 5000] > >www.about.sensis.com.au >A leading Australian advertising, information and directories business. >www.sensis.com.au >www.yellowpages.com.au >www.whitepages.com.au >www.citysearch.com.au >www.whereis.com.au >www.telstra.com.au >www.tradingpost.com.au >This email and any attachments are intended only for the use of the recipient and may be confidential and/or legally privileged. >Sensis Pty Ltd disclaims liability for any errors, omissions, viruses, loss and/or damage arising from using, opening or transmitting this email. >If you are not the intended recipient you must not use, interfere with, disclose, copy or retain this email and you should notify the sender immediately by return email or by contacting Sensis Pty Ltd by telephone on [+61 3 8653 5000] > > |