Menu
▾
▴
springframework-developer
|
From: <jue...@we...> - 2004-11-07 17:31:29
|
Actually, I consider removing the pdfbox jar completely... It's 1.7 MB = (!!) and just used in a unit test. As we need to ship everything that's = needed to build and run the test suite, we'd need to include it in the = distribution if we kept that unit test. =20 I just noticed that we have already shipped that jar in the 1.1.1 = download. Still, I vote for removing it: 1.7 MB is too large just for a = unit test - in particular if the unit test is testing iText itself = rather than our AbstractPdfView. =20 I don't mean to intend that the particular unit test isn't valuable - = just that a 1.7 MB increase in download size is a bad tradeoff for such = a unit test. =20 Juergen =20 ________________________________ Von: spr...@li... im Auftrag = von Dmitriy Kopylenko Gesendet: So 07.11.2004 18:05 An: spr...@li... Betreff: Re: [Springframework-developer] Re: pdfbox and itext Let's move it to "pdfbox" directory Dmitriy. Rob Harrop wrote: > I think pdfbox is used in the iText unit tests - it has support for > getting at the PDF text which is used in some of the unit tests. > > Rob > j=FCrgen h=F6ller [werk3AT] writes: > >> Where's pdfbox used? Quite certainly not in the main sources... In >> any case, I vote for moving it to a separate "pdfbox" directory. >>=20 >> Juergen >>=20 >> ________________________________ >> Von: spr...@li... im Auftrag >> von Dmitriy Kopylenko >> Gesendet: Do 04.11.2004 15:13 >> An: spr...@li... >> Betreff: [Springframework-developer] pdfbox and itext >>=20 >> >> Hello everyone. >> I've noticed in our lib/itext directory there are two jars for both >> itext and pdfbox. As they're two different libraries, would it make = more >> sense to rename top level directory into something like pdf? Or maybe >> create two separate directories one for itext and one for pdfbox? >> Any thoughts? >> Regards, >> Dmitriy. >> >> ------------------------------------------------------- >> This SF.Net email is sponsored by: >> Sybase ASE Linux Express Edition - download now for FREE >> LinuxWorld Reader's Choice Award Winner for best database on Linux. >> http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick >> _______________________________________________ >> Springframework-developer mailing list >> Spr...@li... >> = https://lists.sourceforge.net/lists/listinfo/springframework-developer >>=20 >> >> >> ------------------------------------------------------- >> This SF.Net email is sponsored by: >> Sybase ASE Linux Express Edition - download now for FREE >> LinuxWorld Reader's Choice Award Winner for best database on Linux. >> http://ads.osdn.com/?ad_idU88&alloc_id=12065&opclick >> _______________________________________________ >> Springframework-developer mailing list >> Spr...@li... >> = https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Sybase ASE Linux Express Edition - download now for FREE > LinuxWorld Reader's Choice Award Winner for best database on Linux. > http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer |
|
From: <jue...@we...> - 2004-11-07 18:34:21
|
Thanks for the offer, but I already rewrote the test: It rebuilds a = iText document with the same content, checking whether the result has = the same size as the content generated by AbstractPdfView, and also = checking that the differing bytes are below a certain limit (as the = content will differ in the encryption of the content - but only there). = That should be good enough for this unit test: After all, it should test = AbstractPdfView rather than iText itself. =20 Juergen =20 ________________________________ Von: spr...@li... im Auftrag = von Rob Harrop Gesendet: So 07.11.2004 19:19 An: spr...@li... Betreff: [Springframework-developer] Re: pdfbox and itext If the unit test is very important, I can write a custom parser to the = test the PDF contents without pdfbox. Rob j=FCrgen h=F6ller [werk3AT] writes: > Actually, I consider removing the pdfbox jar completely... It's 1.7 MB = (!!) and just used in a unit test. As we need to ship everything that's = needed to build and run the test suite, we'd need to include it in the = distribution if we kept that unit test. >=20 > I just noticed that we have already shipped that jar in the 1.1.1 = download. Still, I vote for removing it: 1.7 MB is too large just for a = unit test - in particular if the unit test is testing iText itself = rather than our AbstractPdfView. >=20 > I don't mean to intend that the particular unit test isn't valuable - = just that a 1.7 MB increase in download size is a bad tradeoff for such = a unit test. >=20 > Juergen > =20 > > ________________________________ > > Von: spr...@li... im Auftrag = von Dmitriy Kopylenko > Gesendet: So 07.11.2004 18:05 > An: spr...@li... > Betreff: Re: [Springframework-developer] Re: pdfbox and itext > >=20 > > Let's move it to "pdfbox" directory > > Dmitriy. > > Rob Harrop wrote: > >> I think pdfbox is used in the iText unit tests - it has support for >> getting at the PDF text which is used in some of the unit tests. >> >> Rob >> j=FCrgen h=F6ller [werk3AT] writes: >> >>> Where's pdfbox used? Quite certainly not in the main sources... In >>> any case, I vote for moving it to a separate "pdfbox" directory. >>> >>> Juergen >>> >>> ________________________________ >>> Von: spr...@li... im = Auftrag >>> von Dmitriy Kopylenko >>> Gesendet: Do 04.11.2004 15:13 >>> An: spr...@li... >>> Betreff: [Springframework-developer] pdfbox and itext >>> >>> >>> Hello everyone. >>> I've noticed in our lib/itext directory there are two jars for both >>> itext and pdfbox. As they're two different libraries, would it make = more >>> sense to rename top level directory into something like pdf? Or = maybe >>> create two separate directories one for itext and one for pdfbox? >>> Any thoughts? >>> Regards, >>> Dmitriy. >>> >>> ------------------------------------------------------- >>> This SF.Net email is sponsored by: >>> Sybase ASE Linux Express Edition - download now for FREE >>> LinuxWorld Reader's Choice Award Winner for best database on Linux. >>> http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick >>> _______________________________________________ >>> Springframework-developer mailing list >>> Spr...@li... >>> = https://lists.sourceforge.net/lists/listinfo/springframework-developer >>> >>> >>> >>> ------------------------------------------------------- >>> This SF.Net email is sponsored by: >>> Sybase ASE Linux Express Edition - download now for FREE >>> LinuxWorld Reader's Choice Award Winner for best database on Linux. >>> http://ads.osdn.com/?ad_idU88&alloc_id=12065&opclick >>> _______________________________________________ >>> Springframework-developer mailing list >>> Spr...@li... >>> = https://lists.sourceforge.net/lists/listinfo/springframework-developer >> >> >> >> >> ------------------------------------------------------- >> This SF.Net email is sponsored by: >> Sybase ASE Linux Express Edition - download now for FREE >> LinuxWorld Reader's Choice Award Winner for best database on Linux. >> http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick >> _______________________________________________ >> Springframework-developer mailing list >> Spr...@li... >> = https://lists.sourceforge.net/lists/listinfo/springframework-developer >=20 > >=20 > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Sybase ASE Linux Express Edition - download now for FREE > LinuxWorld Reader's Choice Award Winner for best database on Linux. > http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > >=20 > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Sybase ASE Linux Express Edition - download now for FREE > LinuxWorld Reader's Choice Award Winner for best database on Linux. > http://ads.osdn.com/?ad_idU88&alloc_id=12065&opclick > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer |
|
From: Alef A. <al...@jt...> - 2004-11-07 18:47:18
|
Sorry for not responding ealier. Yes, pdfbox is only used in the tests. = From the iText doco I concluded that it's not possible to read PDFs with = iText, so I used pdfbox. To be honest, I'm not a big fan of removing a = unit test because the download size increases (not just because I wrote = the test ;-). =20 I've just revised the test to check for length and appropriate document = instances and stuff... =20 -- err, I see you already updated it ;-). Nevermind. =20 Alef =20 =20 ________________________________ From: spr...@li... on behalf of = j=FCrgen h=F6ller [werk3AT] Sent: Sun 11/7/2004 7:00 PM To: spr...@li... Subject: Re: [Springframework-developer] Re: pdfbox and itext Actually, I consider removing the pdfbox jar completely... It's 1.7 MB = (!!) and just used in a unit test. As we need to ship everything that's = needed to build and run the test suite, we'd need to include it in the = distribution if we kept that unit test. I just noticed that we have already shipped that jar in the 1.1.1 = download. Still, I vote for removing it: 1.7 MB is too large just for a = unit test - in particular if the unit test is testing iText itself = rather than our AbstractPdfView. I don't mean to intend that the particular unit test isn't valuable - = just that a 1.7 MB increase in download size is a bad tradeoff for such = a unit test. Juergen ________________________________ Von: spr...@li... im Auftrag = von Dmitriy Kopylenko Gesendet: So 07.11.2004 18:05 An: spr...@li... Betreff: Re: [Springframework-developer] Re: pdfbox and itext Let's move it to "pdfbox" directory Dmitriy. Rob Harrop wrote: > I think pdfbox is used in the iText unit tests - it has support for > getting at the PDF text which is used in some of the unit tests. > > Rob > j=FCrgen h=F6ller [werk3AT] writes: > >> Where's pdfbox used? Quite certainly not in the main sources... In >> any case, I vote for moving it to a separate "pdfbox" directory. >> >> Juergen >> >> ________________________________ >> Von: spr...@li... im Auftrag >> von Dmitriy Kopylenko >> Gesendet: Do 04.11.2004 15:13 >> An: spr...@li... >> Betreff: [Springframework-developer] pdfbox and itext >> >> >> Hello everyone. >> I've noticed in our lib/itext directory there are two jars for both >> itext and pdfbox. As they're two different libraries, would it make = more >> sense to rename top level directory into something like pdf? Or maybe >> create two separate directories one for itext and one for pdfbox? >> Any thoughts? >> Regards, >> Dmitriy. >> >> ------------------------------------------------------- >> This SF.Net email is sponsored by: >> Sybase ASE Linux Express Edition - download now for FREE >> LinuxWorld Reader's Choice Award Winner for best database on Linux. >> http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick >> _______________________________________________ >> Springframework-developer mailing list >> Spr...@li... >> = https://lists.sourceforge.net/lists/listinfo/springframework-developer >> >> >> >> ------------------------------------------------------- >> This SF.Net email is sponsored by: >> Sybase ASE Linux Express Edition - download now for FREE >> LinuxWorld Reader's Choice Award Winner for best database on Linux. >> http://ads.osdn.com/?ad_idU88&alloc_id=12065&opclick >> _______________________________________________ >> Springframework-developer mailing list >> Spr...@li... >> = https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Sybase ASE Linux Express Edition - download now for FREE > LinuxWorld Reader's Choice Award Winner for best database on Linux. > http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_idU88&alloc_id=12065&op=3Dick _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer |
|
From: Dmitriy K. <dko...@ru...> - 2004-11-07 19:51:48
|
> -- err, I see you already updated it ;-). Nevermind. > Can't compete with Juergen on the speed ;-)) D. |
|
From: <jue...@we...> - 2004-11-07 22:44:42
|
I hope you don't mind the change, Alef! I guess the current test = implementation (which seems to be the same that you just tried to = achieve) still tests AbstractPdfView well enough - i.e. we didn't really = remove the test, we just rewrote it. =20 Indeed, iText doesn't allow to read PDF content... That's why I created = a document for comparisons in the rewritten unit test, instead of = reading in the AbstractPdfView-generated content. I see what your = original intention was; that goal was perfectly fine, of course, aside = from introducing a pdfbox dependency. =20 In general, I don't believe that dependencies specifically introduced = for unit tests are a bad thing. However, 1.7 MB extra binaries is a bit = large, in particular if just used for a single unit test that can be = rewritten to test differently... =20 I'm worried that some people might use the size of = spring-framework-x.x.x-with-dependencies.zip as an indicator for the = "bloatedness" of the framework. I guess it should be a goal to keep it = free from dependencies that are not strictly necessary, in particular as = we're about to add further feature-driven dependencies for Spring 1.2. =20 Juergen =20 ________________________________ Von: spr...@li... im Auftrag = von Alef Arendsen Gesendet: So 07.11.2004 19:48 An: spr...@li...; = spr...@li... Betreff: RE: [Springframework-developer] Re: pdfbox and itext Sorry for not responding ealier. Yes, pdfbox is only used in the tests. = From the iText doco I concluded that it's not possible to read PDFs with = iText, so I used pdfbox. To be honest, I'm not a big fan of removing a = unit test because the download size increases (not just because I wrote = the test ;-). =20 I've just revised the test to check for length and appropriate document = instances and stuff... =20 -- err, I see you already updated it ;-). Nevermind. =20 Alef =20 =20 ________________________________ From: spr...@li... on behalf of = j=FCrgen h=F6ller [werk3AT] Sent: Sun 11/7/2004 7:00 PM To: spr...@li... Subject: Re: [Springframework-developer] Re: pdfbox and itext Actually, I consider removing the pdfbox jar completely... It's 1.7 MB = (!!) and just used in a unit test. As we need to ship everything that's = needed to build and run the test suite, we'd need to include it in the = distribution if we kept that unit test. I just noticed that we have already shipped that jar in the 1.1.1 = download. Still, I vote for removing it: 1.7 MB is too large just for a = unit test - in particular if the unit test is testing iText itself = rather than our AbstractPdfView. I don't mean to intend that the particular unit test isn't valuable - = just that a 1.7 MB increase in download size is a bad tradeoff for such = a unit test. Juergen ________________________________ Von: spr...@li... im Auftrag = von Dmitriy Kopylenko Gesendet: So 07.11.2004 18:05 An: spr...@li... Betreff: Re: [Springframework-developer] Re: pdfbox and itext Let's move it to "pdfbox" directory Dmitriy. Rob Harrop wrote: > I think pdfbox is used in the iText unit tests - it has support for > getting at the PDF text which is used in some of the unit tests. > > Rob > j=FCrgen h=F6ller [werk3AT] writes: > >> Where's pdfbox used? Quite certainly not in the main sources... In >> any case, I vote for moving it to a separate "pdfbox" directory. >> >> Juergen >> >> ________________________________ >> Von: spr...@li... im Auftrag >> von Dmitriy Kopylenko >> Gesendet: Do 04.11.2004 15:13 >> An: spr...@li... >> Betreff: [Springframework-developer] pdfbox and itext >> >> >> Hello everyone. >> I've noticed in our lib/itext directory there are two jars for both >> itext and pdfbox. As they're two different libraries, would it make = more >> sense to rename top level directory into something like pdf? Or maybe >> create two separate directories one for itext and one for pdfbox? >> Any thoughts? >> Regards, >> Dmitriy. >> >> ------------------------------------------------------- >> This SF.Net email is sponsored by: >> Sybase ASE Linux Express Edition - download now for FREE >> LinuxWorld Reader's Choice Award Winner for best database on Linux. >> http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick >> _______________________________________________ >> Springframework-developer mailing list >> Spr...@li... >> = https://lists.sourceforge.net/lists/listinfo/springframework-developer >> >> >> >> ------------------------------------------------------- >> This SF.Net email is sponsored by: >> Sybase ASE Linux Express Edition - download now for FREE >> LinuxWorld Reader's Choice Award Winner for best database on Linux. >> http://ads.osdn.com/?ad_idU88&alloc_id=12065&opclick >> _______________________________________________ >> Springframework-developer mailing list >> Spr...@li... >> = https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Sybase ASE Linux Express Edition - download now for FREE > LinuxWorld Reader's Choice Award Winner for best database on Linux. > http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_idU88&alloc_id=12065&op=3Dick _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer |
|
From: Rod J. <ro...@in...> - 2004-11-08 08:22:27
|
I have to agree with Juergen here. So long as we can test to the same effect otherwise. jürgen höller [werk3AT] wrote: > I hope you don't mind the change, Alef! I guess the current test implementation (which seems to be the same that you just tried to achieve) still tests AbstractPdfView well enough - i.e. we didn't really remove the test, we just rewrote it. > > Indeed, iText doesn't allow to read PDF content... That's why I created a document for comparisons in the rewritten unit test, instead of reading in the AbstractPdfView-generated content. I see what your original intention was; that goal was perfectly fine, of course, aside from introducing a pdfbox dependency. > > In general, I don't believe that dependencies specifically introduced for unit tests are a bad thing. However, 1.7 MB extra binaries is a bit large, in particular if just used for a single unit test that can be rewritten to test differently... > > I'm worried that some people might use the size of spring-framework-x.x.x-with-dependencies.zip as an indicator for the "bloatedness" of the framework. I guess it should be a goal to keep it free from dependencies that are not strictly necessary, in particular as we're about to add further feature-driven dependencies for Spring 1.2. > > Juergen > > > ________________________________ > > Von: spr...@li... im Auftrag von Alef Arendsen > Gesendet: So 07.11.2004 19:48 > An: spr...@li...; spr...@li... > Betreff: RE: [Springframework-developer] Re: pdfbox and itext > > > Sorry for not responding ealier. Yes, pdfbox is only used in the tests. >From the iText doco I concluded that it's not possible to read PDFs with iText, so I used pdfbox. To be honest, I'm not a big fan of removing a unit test because the download size increases (not just because I wrote the test ;-). > > I've just revised the test to check for length and appropriate document instances and stuff... > > -- err, I see you already updated it ;-). Nevermind. > > Alef > > > > ________________________________ > > From: spr...@li... on behalf of jürgen höller [werk3AT] > Sent: Sun 11/7/2004 7:00 PM > To: spr...@li... > Subject: Re: [Springframework-developer] Re: pdfbox and itext > > > > Actually, I consider removing the pdfbox jar completely... It's 1.7 MB (!!) and just used in a unit test. As we need to ship everything that's needed to build and run the test suite, we'd need to include it in the distribution if we kept that unit test. > > I just noticed that we have already shipped that jar in the 1.1.1 download. Still, I vote for removing it: 1.7 MB is too large just for a unit test - in particular if the unit test is testing iText itself rather than our AbstractPdfView. > > I don't mean to intend that the particular unit test isn't valuable - just that a 1.7 MB increase in download size is a bad tradeoff for such a unit test. > > Juergen > > > ________________________________ > > Von: spr...@li... im Auftrag von Dmitriy Kopylenko > Gesendet: So 07.11.2004 18:05 > An: spr...@li... > Betreff: Re: [Springframework-developer] Re: pdfbox and itext > > > > Let's move it to "pdfbox" directory > > Dmitriy. > > Rob Harrop wrote: > > >>I think pdfbox is used in the iText unit tests - it has support for >>getting at the PDF text which is used in some of the unit tests. >> >>Rob >>jürgen höller [werk3AT] writes: >> >> >>>Where's pdfbox used? Quite certainly not in the main sources... In >>>any case, I vote for moving it to a separate "pdfbox" directory. >>> >>>Juergen >>> >>>________________________________ >>>Von: spr...@li... im Auftrag >>>von Dmitriy Kopylenko >>>Gesendet: Do 04.11.2004 15:13 >>>An: spr...@li... >>>Betreff: [Springframework-developer] pdfbox and itext >>> >>> >>>Hello everyone. >>>I've noticed in our lib/itext directory there are two jars for both >>>itext and pdfbox. As they're two different libraries, would it make more >>>sense to rename top level directory into something like pdf? Or maybe >>>create two separate directories one for itext and one for pdfbox? >>>Any thoughts? >>>Regards, >>>Dmitriy. >>> >>>------------------------------------------------------- >>>This SF.Net email is sponsored by: >>>Sybase ASE Linux Express Edition - download now for FREE >>>LinuxWorld Reader's Choice Award Winner for best database on Linux. >>>http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click >>>_______________________________________________ >>>Springframework-developer mailing list >>>Spr...@li... >>>https://lists.sourceforge.net/lists/listinfo/springframework-developer >>> >>> >>> >>>------------------------------------------------------- >>>This SF.Net email is sponsored by: >>>Sybase ASE Linux Express Edition - download now for FREE >>>LinuxWorld Reader's Choice Award Winner for best database on Linux. >>>http://ads.osdn.com/?ad_idU88&alloc_id065&opclick >>>_______________________________________________ >>>Springframework-developer mailing list >>>Spr...@li... >>>https://lists.sourceforge.net/lists/listinfo/springframework-developer >> >> >> >> >>------------------------------------------------------- >>This SF.Net email is sponsored by: >>Sybase ASE Linux Express Edition - download now for FREE >>LinuxWorld Reader's Choice Award Winner for best database on Linux. >>http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click >>_______________________________________________ >>Springframework-developer mailing list >>Spr...@li... >>https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Sybase ASE Linux Express Edition - download now for FREE > LinuxWorld Reader's Choice Award Winner for best database on Linux. > http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Sybase ASE Linux Express Edition - download now for FREE > LinuxWorld Reader's Choice Award Winner for best database on Linux. > http://ads.osdn.com/?ad_idU88&alloc_id065&op=ick > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Sybase ASE Linux Express Edition - download now for FREE > LinuxWorld Reader's Choice Award Winner for best database on Linux. > http://ads.osdn.com/?ad_idU88&alloc_id065&op=click > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > -- ____________________________________________________ Rod Johnson Interface21 - Spring Services from the Source http://www.springframework.com Founder, Spring Framework: http://www.springframework.org Author, "Expert One-on-One J2EE Development Without EJB" (May 2004, with Juergen Hoeller). http://www.amazon.com/exec/obidos/ASIN/0764558315/ Author, "Expert One-on-One J2EE Design and Development" (October 2002). http://www.amazon.com/exec/obidos/tg/detail/-/0764543857/ ____________________________________________________ Interface21 Limited Registered Office Summit House, 2-2a Highfield Road, Dartford, Kent DA1 2JY Registered in England and Wales No. 5187766 ____________________________________________________ |
|
From: Alef A. <al...@jt...> - 2004-11-08 08:59:54
|
I guess I expressed myself a bit too strong ;-). I rewrote the test in = about the same way as you did... Rewriting is okay, I was just objecting = to removing it since then the whole class would have been left untested. =20 So in other words, no worries ;-). =20 Alef =20 ________________________________ From: spr...@li... on behalf of = j=FCrgen h=F6ller [werk3AT] Sent: Mon 11/8/2004 12:00 AM To: spr...@li... Subject: Re: [Springframework-developer] Re: pdfbox and itext I hope you don't mind the change, Alef! I guess the current test = implementation (which seems to be the same that you just tried to = achieve) still tests AbstractPdfView well enough - i.e. we didn't really = remove the test, we just rewrote it. Indeed, iText doesn't allow to read PDF content... That's why I created = a document for comparisons in the rewritten unit test, instead of = reading in the AbstractPdfView-generated content. I see what your = original intention was; that goal was perfectly fine, of course, aside = from introducing a pdfbox dependency. In general, I don't believe that dependencies specifically introduced = for unit tests are a bad thing. However, 1.7 MB extra binaries is a bit = large, in particular if just used for a single unit test that can be = rewritten to test differently... I'm worried that some people might use the size of = spring-framework-x.x.x-with-dependencies.zip as an indicator for the = "bloatedness" of the framework. I guess it should be a goal to keep it = free from dependencies that are not strictly necessary, in particular as = we're about to add further feature-driven dependencies for Spring 1.2. Juergen ________________________________ Von: spr...@li... im Auftrag = von Alef Arendsen Gesendet: So 07.11.2004 19:48 An: spr...@li...; = spr...@li... Betreff: RE: [Springframework-developer] Re: pdfbox and itext Sorry for not responding ealier. Yes, pdfbox is only used in the tests. = From the iText doco I concluded that it's not possible to read PDFs with = iText, so I used pdfbox. To be honest, I'm not a big fan of removing a = unit test because the download size increases (not just because I wrote = the test ;-). I've just revised the test to check for length and appropriate document = instances and stuff... -- err, I see you already updated it ;-). Nevermind. Alef ________________________________ From: spr...@li... on behalf of = j=FCrgen h=F6ller [werk3AT] Sent: Sun 11/7/2004 7:00 PM To: spr...@li... Subject: Re: [Springframework-developer] Re: pdfbox and itext Actually, I consider removing the pdfbox jar completely... It's 1.7 MB = (!!) and just used in a unit test. As we need to ship everything that's = needed to build and run the test suite, we'd need to include it in the = distribution if we kept that unit test. I just noticed that we have already shipped that jar in the 1.1.1 = download. Still, I vote for removing it: 1.7 MB is too large just for a = unit test - in particular if the unit test is testing iText itself = rather than our AbstractPdfView. I don't mean to intend that the particular unit test isn't valuable - = just that a 1.7 MB increase in download size is a bad tradeoff for such = a unit test. Juergen ________________________________ Von: spr...@li... im Auftrag = von Dmitriy Kopylenko Gesendet: So 07.11.2004 18:05 An: spr...@li... Betreff: Re: [Springframework-developer] Re: pdfbox and itext Let's move it to "pdfbox" directory Dmitriy. Rob Harrop wrote: > I think pdfbox is used in the iText unit tests - it has support for > getting at the PDF text which is used in some of the unit tests. > > Rob > j=FCrgen h=F6ller [werk3AT] writes: > >> Where's pdfbox used? Quite certainly not in the main sources... In >> any case, I vote for moving it to a separate "pdfbox" directory. >> >> Juergen >> >> ________________________________ >> Von: spr...@li... im Auftrag >> von Dmitriy Kopylenko >> Gesendet: Do 04.11.2004 15:13 >> An: spr...@li... >> Betreff: [Springframework-developer] pdfbox and itext >> >> >> Hello everyone. >> I've noticed in our lib/itext directory there are two jars for both >> itext and pdfbox. As they're two different libraries, would it make = more >> sense to rename top level directory into something like pdf? Or maybe >> create two separate directories one for itext and one for pdfbox? >> Any thoughts? >> Regards, >> Dmitriy. >> >> ------------------------------------------------------- >> This SF.Net email is sponsored by: >> Sybase ASE Linux Express Edition - download now for FREE >> LinuxWorld Reader's Choice Award Winner for best database on Linux. >> http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick >> _______________________________________________ >> Springframework-developer mailing list >> Spr...@li... >> = https://lists.sourceforge.net/lists/listinfo/springframework-developer >> >> >> >> ------------------------------------------------------- >> This SF.Net email is sponsored by: >> Sybase ASE Linux Express Edition - download now for FREE >> LinuxWorld Reader's Choice Award Winner for best database on Linux. >> http://ads.osdn.com/?ad_idU88&alloc_id=12065&opclick >> _______________________________________________ >> Springframework-developer mailing list >> Spr...@li... >> = https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Sybase ASE Linux Express Edition - download now for FREE > LinuxWorld Reader's Choice Award Winner for best database on Linux. > http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_idU88&alloc_id=12065&op=3Dick _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_idU88&alloc_id=12065&op=3Dick _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer |
|
From: Rob H. <ro...@ca...> - 2004-11-07 18:19:16
|
If the unit test is very important, I can write a custom parser to the test the PDF contents without pdfbox. Rob jürgen höller [werk3AT] writes: > Actually, I consider removing the pdfbox jar completely... It's 1.7 MB (!!) and just used in a unit test. As we need to ship everything that's needed to build and run the test suite, we'd need to include it in the distribution if we kept that unit test. > > I just noticed that we have already shipped that jar in the 1.1.1 download. Still, I vote for removing it: 1.7 MB is too large just for a unit test - in particular if the unit test is testing iText itself rather than our AbstractPdfView. > > I don't mean to intend that the particular unit test isn't valuable - just that a 1.7 MB increase in download size is a bad tradeoff for such a unit test. > > Juergen > > > ________________________________ > > Von: spr...@li... im Auftrag von Dmitriy Kopylenko > Gesendet: So 07.11.2004 18:05 > An: spr...@li... > Betreff: Re: [Springframework-developer] Re: pdfbox and itext > > > > Let's move it to "pdfbox" directory > > Dmitriy. > > Rob Harrop wrote: > >> I think pdfbox is used in the iText unit tests - it has support for >> getting at the PDF text which is used in some of the unit tests. >> >> Rob >> jürgen höller [werk3AT] writes: >> >>> Where's pdfbox used? Quite certainly not in the main sources... In >>> any case, I vote for moving it to a separate "pdfbox" directory. >>> >>> Juergen >>> >>> ________________________________ >>> Von: spr...@li... im Auftrag >>> von Dmitriy Kopylenko >>> Gesendet: Do 04.11.2004 15:13 >>> An: spr...@li... >>> Betreff: [Springframework-developer] pdfbox and itext >>> >>> >>> Hello everyone. >>> I've noticed in our lib/itext directory there are two jars for both >>> itext and pdfbox. As they're two different libraries, would it make more >>> sense to rename top level directory into something like pdf? Or maybe >>> create two separate directories one for itext and one for pdfbox? >>> Any thoughts? >>> Regards, >>> Dmitriy. >>> >>> ------------------------------------------------------- >>> This SF.Net email is sponsored by: >>> Sybase ASE Linux Express Edition - download now for FREE >>> LinuxWorld Reader's Choice Award Winner for best database on Linux. >>> http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click >>> _______________________________________________ >>> Springframework-developer mailing list >>> Spr...@li... >>> https://lists.sourceforge.net/lists/listinfo/springframework-developer >>> >>> >>> >>> ------------------------------------------------------- >>> This SF.Net email is sponsored by: >>> Sybase ASE Linux Express Edition - download now for FREE >>> LinuxWorld Reader's Choice Award Winner for best database on Linux. >>> http://ads.osdn.com/?ad_idU88&alloc_id065&opclick >>> _______________________________________________ >>> Springframework-developer mailing list >>> Spr...@li... >>> https://lists.sourceforge.net/lists/listinfo/springframework-developer >> >> >> >> >> ------------------------------------------------------- >> This SF.Net email is sponsored by: >> Sybase ASE Linux Express Edition - download now for FREE >> LinuxWorld Reader's Choice Award Winner for best database on Linux. >> http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click >> _______________________________________________ >> Springframework-developer mailing list >> Spr...@li... >> https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Sybase ASE Linux Express Edition - download now for FREE > LinuxWorld Reader's Choice Award Winner for best database on Linux. > http://ads.osdn.com/?ad_id=5588&alloc_id=12065&op=click > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Sybase ASE Linux Express Edition - download now for FREE > LinuxWorld Reader's Choice Award Winner for best database on Linux. > http://ads.osdn.com/?ad_idU88&alloc_id065&opclick > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer |
