Menu
▾
▴
RE: [Springframework-developer] Re: pdfbox and itext
|
From: Alef A. <al...@jt...> - 2004-11-08 08:59:54
|
I guess I expressed myself a bit too strong ;-). I rewrote the test in = about the same way as you did... Rewriting is okay, I was just objecting = to removing it since then the whole class would have been left untested. =20 So in other words, no worries ;-). =20 Alef =20 ________________________________ From: spr...@li... on behalf of = j=FCrgen h=F6ller [werk3AT] Sent: Mon 11/8/2004 12:00 AM To: spr...@li... Subject: Re: [Springframework-developer] Re: pdfbox and itext I hope you don't mind the change, Alef! I guess the current test = implementation (which seems to be the same that you just tried to = achieve) still tests AbstractPdfView well enough - i.e. we didn't really = remove the test, we just rewrote it. Indeed, iText doesn't allow to read PDF content... That's why I created = a document for comparisons in the rewritten unit test, instead of = reading in the AbstractPdfView-generated content. I see what your = original intention was; that goal was perfectly fine, of course, aside = from introducing a pdfbox dependency. In general, I don't believe that dependencies specifically introduced = for unit tests are a bad thing. However, 1.7 MB extra binaries is a bit = large, in particular if just used for a single unit test that can be = rewritten to test differently... I'm worried that some people might use the size of = spring-framework-x.x.x-with-dependencies.zip as an indicator for the = "bloatedness" of the framework. I guess it should be a goal to keep it = free from dependencies that are not strictly necessary, in particular as = we're about to add further feature-driven dependencies for Spring 1.2. Juergen ________________________________ Von: spr...@li... im Auftrag = von Alef Arendsen Gesendet: So 07.11.2004 19:48 An: spr...@li...; = spr...@li... Betreff: RE: [Springframework-developer] Re: pdfbox and itext Sorry for not responding ealier. Yes, pdfbox is only used in the tests. = From the iText doco I concluded that it's not possible to read PDFs with = iText, so I used pdfbox. To be honest, I'm not a big fan of removing a = unit test because the download size increases (not just because I wrote = the test ;-). I've just revised the test to check for length and appropriate document = instances and stuff... -- err, I see you already updated it ;-). Nevermind. Alef ________________________________ From: spr...@li... on behalf of = j=FCrgen h=F6ller [werk3AT] Sent: Sun 11/7/2004 7:00 PM To: spr...@li... Subject: Re: [Springframework-developer] Re: pdfbox and itext Actually, I consider removing the pdfbox jar completely... It's 1.7 MB = (!!) and just used in a unit test. As we need to ship everything that's = needed to build and run the test suite, we'd need to include it in the = distribution if we kept that unit test. I just noticed that we have already shipped that jar in the 1.1.1 = download. Still, I vote for removing it: 1.7 MB is too large just for a = unit test - in particular if the unit test is testing iText itself = rather than our AbstractPdfView. I don't mean to intend that the particular unit test isn't valuable - = just that a 1.7 MB increase in download size is a bad tradeoff for such = a unit test. Juergen ________________________________ Von: spr...@li... im Auftrag = von Dmitriy Kopylenko Gesendet: So 07.11.2004 18:05 An: spr...@li... Betreff: Re: [Springframework-developer] Re: pdfbox and itext Let's move it to "pdfbox" directory Dmitriy. Rob Harrop wrote: > I think pdfbox is used in the iText unit tests - it has support for > getting at the PDF text which is used in some of the unit tests. > > Rob > j=FCrgen h=F6ller [werk3AT] writes: > >> Where's pdfbox used? Quite certainly not in the main sources... In >> any case, I vote for moving it to a separate "pdfbox" directory. >> >> Juergen >> >> ________________________________ >> Von: spr...@li... im Auftrag >> von Dmitriy Kopylenko >> Gesendet: Do 04.11.2004 15:13 >> An: spr...@li... >> Betreff: [Springframework-developer] pdfbox and itext >> >> >> Hello everyone. >> I've noticed in our lib/itext directory there are two jars for both >> itext and pdfbox. As they're two different libraries, would it make = more >> sense to rename top level directory into something like pdf? Or maybe >> create two separate directories one for itext and one for pdfbox? >> Any thoughts? >> Regards, >> Dmitriy. >> >> ------------------------------------------------------- >> This SF.Net email is sponsored by: >> Sybase ASE Linux Express Edition - download now for FREE >> LinuxWorld Reader's Choice Award Winner for best database on Linux. >> http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick >> _______________________________________________ >> Springframework-developer mailing list >> Spr...@li... >> = https://lists.sourceforge.net/lists/listinfo/springframework-developer >> >> >> >> ------------------------------------------------------- >> This SF.Net email is sponsored by: >> Sybase ASE Linux Express Edition - download now for FREE >> LinuxWorld Reader's Choice Award Winner for best database on Linux. >> http://ads.osdn.com/?ad_idU88&alloc_id=12065&opclick >> _______________________________________________ >> Springframework-developer mailing list >> Spr...@li... >> = https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > > ------------------------------------------------------- > This SF.Net email is sponsored by: > Sybase ASE Linux Express Edition - download now for FREE > LinuxWorld Reader's Choice Award Winner for best database on Linux. > http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_id=3D5588&alloc_id=3D12065&op=3Dclick _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_idU88&alloc_id=12065&op=3Dick _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer ------------------------------------------------------- This SF.Net email is sponsored by: Sybase ASE Linux Express Edition - download now for FREE LinuxWorld Reader's Choice Award Winner for best database on Linux. http://ads.osdn.com/?ad_idU88&alloc_id=12065&op=3Dick _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer |
