Menu
▾
▴
springframework-developer
|
From: Kopylenko, D. <dko...@ac...> - 2003-11-11 21:13:30
|
All, I've just commited some minor refactorings to the aop package: - Refactored some names and javadocs to be compatable with new API Please re-sync. Regards, Dmitriy. -----Original Message----- From: Rod Johnson [mailto:rod...@in...] Sent: Tuesday, November 11, 2003 1:34 PM To: spr...@li... Subject: [Springframework-developer] AOP API changes Importance: High All, I've just committed the current version of the AOP proposal (#2). All unit tests pass (naturally). However, there will be an impact on code using the AOP API. Interceptors are unaffected, unless they relied on the AttributeRegistry, now removed. Pointcuts _are_ affected. If you want the old Pointcut concept (Interceptor + when to apply it) subclass StaticMethodMatcherPointcutAdvice and it should work the same. The RegexpPointcut is also pretty similar, but does need a reference to an Interceptor now. (A subclass that also implemented Advice could easily add this.) The ProxyConfig API has changed significantly: code using this will also be broken. There's definitely scope for more abstract classes etc. to make the API more usable. However, it is definitely more powerful now. I'll be producing a migration guide from the old API. I need to refine the comments considerably. (Help welcome!) I also need to improve the tests for pointcut composition. Volunteers for any of these tasks are welcome. Please update from CVS and check your code ASAP. With M3 coming up, it's important that we are all sure everything works. AOP transactions shouldn't be affected, unless they did something fancy like provided their own MethodPointcut (now Pointcut). Regards, Rod ------------------------------------------------------- This SF.Net email sponsored by: ApacheCon 2003, 16-19 November in Las Vegas. Learn firsthand the latest developments in Apache, PHP, Perl, XML, Java, MySQL, WebDAV, and more! http://www.apachecon.com/ _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer |
|
From: Kopylenko, D. <dko...@ac...> - 2003-11-11 22:23:17
|
I just fixed it. Please re-sync.
Dmitriy.
-----Original Message-----
From: Colin Sampaleanu
To: spr...@li...;
dko...@ac...
Sent: 11/11/2003 4:49 PM
Subject: Re: [Springframework-developer] AOP API changes
I get a javac build failure on the testsuite, as follows. What is really
weird too, is that it doesn't break the build, ie testing with the
limited set of classes that has been produced, commences after the javac
failure:
buildtests:
[mkdir] Created dir: D:\src\open\spring-colin\spring\.testclasses
[javac] Compiling 205 source files to
D:\src\open\spring-colin\spring\.testc
lasses
[javac]
D:\src\open\spring-colin\spring\test\org\springframework\context\sup
port\StaticApplicationContextTestSuite.java:117:
org.springframework.context.sup
port.StaticApplicationContextTestSuite.TestAutoProxyCreator is not
abstract and
does not override abstract method
getInterceptorsAndAdvicesForBean(java.lang.Obj
ect,java.lang.String) in
org.springframework.aop.framework.support.AbstractAutoP
roxyCreator
[javac] public static class TestAutoProxyCreator extends
AbstractAutoPro
xyCreator {
[javac] ^
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -deprecation for details.
[javac] 1 error
[javac] Compile failed; see the compiler error output for details.
[copy] Copying 19 files to
D:\src\open\spring-colin\spring\.testclasses
tests:
[mkdir] Created dir: D:\src\open\spring-colin\spring\junit-reports
[junit] Running org.springframework.aop.framework.AopProxyTests
...
Kopylenko, Dmitry wrote:
>All,
>
>I've just commited some minor refactorings to the aop package:
>- Refactored some names and javadocs to be compatable with new API
>
>Please re-sync.
>
>Regards,
>Dmitriy.
>
>-----Original Message-----
>From: Rod Johnson [mailto:rod...@in...]
>Sent: Tuesday, November 11, 2003 1:34 PM
>To: spr...@li...
>Subject: [Springframework-developer] AOP API changes
>Importance: High
>
>
>All,
>
>I've just committed the current version of the AOP proposal (#2).
>
>All unit tests pass (naturally). However, there will be an impact on
code
>using the AOP API. Interceptors are unaffected, unless they relied on
the
>AttributeRegistry, now removed. Pointcuts _are_ affected. If you want
the
>old Pointcut concept (Interceptor + when to apply it) subclass
>StaticMethodMatcherPointcutAdvice and it should work the same. The
>RegexpPointcut is also pretty similar, but does need a reference to an
>Interceptor now. (A subclass that also implemented Advice could easily
add
>this.)
>
>The ProxyConfig API has changed significantly: code using this will
also be
>broken.
>
>There's definitely scope for more abstract classes etc. to make the API
more
>usable. However, it is definitely more powerful now.
>
>I'll be producing a migration guide from the old API.
>
>I need to refine the comments considerably. (Help welcome!) I also need
to
>improve the tests for pointcut composition. Volunteers for any of these
>tasks are welcome.
>
>Please update from CVS and check your code ASAP. With M3 coming up,
it's
>important that we are all sure everything works. AOP transactions
shouldn't
>be affected, unless they did something fancy like provided their own
>MethodPointcut (now Pointcut).
>
>Regards,
>Rod
>
>
|
|
From: Colin S. <col...@ex...> - 2003-11-11 23:00:32
|
Ok, I am able to build and run all tests ok, with the exception of
FormatHelperTests, which builds ok but fails.
I've modified build.xml to fail on any javac errors on any of the
targets using javac.
I have also tried this build of Spring with my main app using Spring,
which does _not_ use any of the AOP stuff directly, and all seems to
work ok.
Kopylenko, Dmitry wrote:
>I just fixed it. Please re-sync.
>
>Dmitriy.
>
>-----Original Message-----
>From: Colin Sampaleanu
>To: spr...@li...;
>dko...@ac...
>Sent: 11/11/2003 4:49 PM
>Subject: Re: [Springframework-developer] AOP API changes
>
>I get a javac build failure on the testsuite, as follows. What is really
>
>weird too, is that it doesn't break the build, ie testing with the
>limited set of classes that has been produced, commences after the javac
>
>failure:
>
>buildtests:
> [mkdir] Created dir: D:\src\open\spring-colin\spring\.testclasses
> [javac] Compiling 205 source files to
>D:\src\open\spring-colin\spring\.testc
>lasses
> [javac]
>D:\src\open\spring-colin\spring\test\org\springframework\context\sup
>port\StaticApplicationContextTestSuite.java:117:
>org.springframework.context.sup
>port.StaticApplicationContextTestSuite.TestAutoProxyCreator is not
>abstract and
>does not override abstract method
>getInterceptorsAndAdvicesForBean(java.lang.Obj
>ect,java.lang.String) in
>org.springframework.aop.framework.support.AbstractAutoP
>roxyCreator
> [javac] public static class TestAutoProxyCreator extends
>AbstractAutoPro
>xyCreator {
> [javac] ^
> [javac] Note: Some input files use or override a deprecated API.
> [javac] Note: Recompile with -deprecation for details.
> [javac] 1 error
> [javac] Compile failed; see the compiler error output for details.
> [copy] Copying 19 files to
>D:\src\open\spring-colin\spring\.testclasses
>
>tests:
> [mkdir] Created dir: D:\src\open\spring-colin\spring\junit-reports
> [junit] Running org.springframework.aop.framework.AopProxyTests
> ...
>
>
>Kopylenko, Dmitry wrote:
>
>
>
>>All,
>>
>>I've just commited some minor refactorings to the aop package:
>>- Refactored some names and javadocs to be compatable with new API
>>
>>Please re-sync.
>>
>>Regards,
>>Dmitriy.
>>
>>-----Original Message-----
>>From: Rod Johnson [mailto:rod...@in...]
>>Sent: Tuesday, November 11, 2003 1:34 PM
>>To: spr...@li...
>>Subject: [Springframework-developer] AOP API changes
>>Importance: High
>>
>>
>>All,
>>
>>I've just committed the current version of the AOP proposal (#2).
>>
>>All unit tests pass (naturally). However, there will be an impact on
>>
>>
>code
>
>
>>using the AOP API. Interceptors are unaffected, unless they relied on
>>
>>
>the
>
>
>>AttributeRegistry, now removed. Pointcuts _are_ affected. If you want
>>
>>
>the
>
>
>>old Pointcut concept (Interceptor + when to apply it) subclass
>>StaticMethodMatcherPointcutAdvice and it should work the same. The
>>RegexpPointcut is also pretty similar, but does need a reference to an
>>Interceptor now. (A subclass that also implemented Advice could easily
>>
>>
>add
>
>
>>this.)
>>
>>The ProxyConfig API has changed significantly: code using this will
>>
>>
>also be
>
>
>>broken.
>>
>>There's definitely scope for more abstract classes etc. to make the API
>>
>>
>more
>
>
>>usable. However, it is definitely more powerful now.
>>
>>I'll be producing a migration guide from the old API.
>>
>>I need to refine the comments considerably. (Help welcome!) I also need
>>
>>
>to
>
>
>>improve the tests for pointcut composition. Volunteers for any of these
>>tasks are welcome.
>>
>>Please update from CVS and check your code ASAP. With M3 coming up,
>>
>>
>it's
>
>
>>important that we are all sure everything works. AOP transactions
>>
>>
>shouldn't
>
>
>>be affected, unless they did something fancy like provided their own
>>MethodPointcut (now Pointcut).
>>
>>Regards,
>>Rod
>>
>>
|
|
From: Rod J. <rod...@in...> - 2003-11-11 23:30:52
|
Does it use AOP behind the scenes for declarative transaction management?
----- Original Message -----
From: "Colin Sampaleanu" <col...@ex...>
To: <spr...@li...>
Sent: Tuesday, November 11, 2003 11:00 PM
Subject: Re: [Springframework-developer] AOP API changes
> Ok, I am able to build and run all tests ok, with the exception of
> FormatHelperTests, which builds ok but fails.
>
> I've modified build.xml to fail on any javac errors on any of the
> targets using javac.
>
> I have also tried this build of Spring with my main app using Spring,
> which does _not_ use any of the AOP stuff directly, and all seems to
> work ok.
>
>
>
> Kopylenko, Dmitry wrote:
>
> >I just fixed it. Please re-sync.
> >
> >Dmitriy.
> >
> >-----Original Message-----
> >From: Colin Sampaleanu
> >To: spr...@li...;
> >dko...@ac...
> >Sent: 11/11/2003 4:49 PM
> >Subject: Re: [Springframework-developer] AOP API changes
> >
> >I get a javac build failure on the testsuite, as follows. What is really
> >
> >weird too, is that it doesn't break the build, ie testing with the
> >limited set of classes that has been produced, commences after the javac
> >
> >failure:
> >
> >buildtests:
> > [mkdir] Created dir: D:\src\open\spring-colin\spring\.testclasses
> > [javac] Compiling 205 source files to
> >D:\src\open\spring-colin\spring\.testc
> >lasses
> > [javac]
> >D:\src\open\spring-colin\spring\test\org\springframework\context\sup
> >port\StaticApplicationContextTestSuite.java:117:
> >org.springframework.context.sup
> >port.StaticApplicationContextTestSuite.TestAutoProxyCreator is not
> >abstract and
> >does not override abstract method
> >getInterceptorsAndAdvicesForBean(java.lang.Obj
> >ect,java.lang.String) in
> >org.springframework.aop.framework.support.AbstractAutoP
> >roxyCreator
> > [javac] public static class TestAutoProxyCreator extends
> >AbstractAutoPro
> >xyCreator {
> > [javac] ^
> > [javac] Note: Some input files use or override a deprecated API.
> > [javac] Note: Recompile with -deprecation for details.
> > [javac] 1 error
> > [javac] Compile failed; see the compiler error output for details.
> > [copy] Copying 19 files to
> >D:\src\open\spring-colin\spring\.testclasses
> >
> >tests:
> > [mkdir] Created dir: D:\src\open\spring-colin\spring\junit-reports
> > [junit] Running org.springframework.aop.framework.AopProxyTests
> > ...
> >
> >
> >Kopylenko, Dmitry wrote:
> >
> >
> >
> >>All,
> >>
> >>I've just commited some minor refactorings to the aop package:
> >>- Refactored some names and javadocs to be compatable with new API
> >>
> >>Please re-sync.
> >>
> >>Regards,
> >>Dmitriy.
> >>
> >>-----Original Message-----
> >>From: Rod Johnson [mailto:rod...@in...]
> >>Sent: Tuesday, November 11, 2003 1:34 PM
> >>To: spr...@li...
> >>Subject: [Springframework-developer] AOP API changes
> >>Importance: High
> >>
> >>
> >>All,
> >>
> >>I've just committed the current version of the AOP proposal (#2).
> >>
> >>All unit tests pass (naturally). However, there will be an impact on
> >>
> >>
> >code
> >
> >
> >>using the AOP API. Interceptors are unaffected, unless they relied on
> >>
> >>
> >the
> >
> >
> >>AttributeRegistry, now removed. Pointcuts _are_ affected. If you want
> >>
> >>
> >the
> >
> >
> >>old Pointcut concept (Interceptor + when to apply it) subclass
> >>StaticMethodMatcherPointcutAdvice and it should work the same. The
> >>RegexpPointcut is also pretty similar, but does need a reference to an
> >>Interceptor now. (A subclass that also implemented Advice could easily
> >>
> >>
> >add
> >
> >
> >>this.)
> >>
> >>The ProxyConfig API has changed significantly: code using this will
> >>
> >>
> >also be
> >
> >
> >>broken.
> >>
> >>There's definitely scope for more abstract classes etc. to make the API
> >>
> >>
> >more
> >
> >
> >>usable. However, it is definitely more powerful now.
> >>
> >>I'll be producing a migration guide from the old API.
> >>
> >>I need to refine the comments considerably. (Help welcome!) I also need
> >>
> >>
> >to
> >
> >
> >>improve the tests for pointcut composition. Volunteers for any of these
> >>tasks are welcome.
> >>
> >>Please update from CVS and check your code ASAP. With M3 coming up,
> >>
> >>
> >it's
> >
> >
> >>important that we are all sure everything works. AOP transactions
> >>
> >>
> >shouldn't
> >
> >
> >>be affected, unless they did something fancy like provided their own
> >>MethodPointcut (now Pointcut).
> >>
> >>Regards,
> >>Rod
> >>
> >>
>
>
>
>
> -------------------------------------------------------
> This SF.Net email sponsored by: ApacheCon 2003,
> 16-19 November in Las Vegas. Learn firsthand the latest
> developments in Apache, PHP, Perl, XML, Java, MySQL,
> WebDAV, and more! http://www.apachecon.com/
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>
|
|
From: Colin S. <col...@ex...> - 2003-11-12 03:24:22
|
Yes. Most of the app is actually unusable right now due to an ongoing
refactoring that's affecting a lot of things, so I can't say that this
is a very thorough test, but I did run through some functionality that
reads data (ultimately via Hibernate) via some services wrapped with
declarative transactions. The log output from the
TransactionInterceptor is there, so it's definitely kicking in. All the
other Spring functionality I'm using (contexts and the Hibernate related
code) seems to be ok too.
Rod Johnson wrote:
>Does it use AOP behind the scenes for declarative transaction management?
>
>----- Original Message -----
>From: "Colin Sampaleanu" <col...@ex...>
>To: <spr...@li...>
>Sent: Tuesday, November 11, 2003 11:00 PM
>Subject: Re: [Springframework-developer] AOP API changes
>
>
>
>
>>Ok, I am able to build and run all tests ok, with the exception of
>>FormatHelperTests, which builds ok but fails.
>>
>>I've modified build.xml to fail on any javac errors on any of the
>>targets using javac.
>>
>>I have also tried this build of Spring with my main app using Spring,
>>which does _not_ use any of the AOP stuff directly, and all seems to
>>work ok.
>>
>>
>>
>>Kopylenko, Dmitry wrote:
>>
>>
>>
>>>I just fixed it. Please re-sync.
>>>
>>>Dmitriy.
>>>
>>>-----Original Message-----
>>>From: Colin Sampaleanu
>>>To: spr...@li...;
>>>dko...@ac...
>>>Sent: 11/11/2003 4:49 PM
>>>Subject: Re: [Springframework-developer] AOP API changes
>>>
>>>I get a javac build failure on the testsuite, as follows. What is really
>>>
>>>weird too, is that it doesn't break the build, ie testing with the
>>>limited set of classes that has been produced, commences after the javac
>>>
>>>failure:
>>>
>>>buildtests:
>>> [mkdir] Created dir: D:\src\open\spring-colin\spring\.testclasses
>>> [javac] Compiling 205 source files to
>>>D:\src\open\spring-colin\spring\.testc
>>>lasses
>>> [javac]
>>>D:\src\open\spring-colin\spring\test\org\springframework\context\sup
>>>port\StaticApplicationContextTestSuite.java:117:
>>>org.springframework.context.sup
>>>port.StaticApplicationContextTestSuite.TestAutoProxyCreator is not
>>>abstract and
>>>does not override abstract method
>>>getInterceptorsAndAdvicesForBean(java.lang.Obj
>>>ect,java.lang.String) in
>>>org.springframework.aop.framework.support.AbstractAutoP
>>>roxyCreator
>>> [javac] public static class TestAutoProxyCreator extends
>>>AbstractAutoPro
>>>xyCreator {
>>> [javac] ^
>>> [javac] Note: Some input files use or override a deprecated API.
>>> [javac] Note: Recompile with -deprecation for details.
>>> [javac] 1 error
>>> [javac] Compile failed; see the compiler error output for details.
>>> [copy] Copying 19 files to
>>>D:\src\open\spring-colin\spring\.testclasses
>>>
>>>tests:
>>> [mkdir] Created dir: D:\src\open\spring-colin\spring\junit-reports
>>> [junit] Running org.springframework.aop.framework.AopProxyTests
>>> ...
>>>
>>>
>>>Kopylenko, Dmitry wrote:
>>>
>>>
>>>
>>>
>>>
>>>>All,
>>>>
>>>>I've just commited some minor refactorings to the aop package:
>>>>- Refactored some names and javadocs to be compatable with new API
>>>>
>>>>Please re-sync.
>>>>
>>>>Regards,
>>>>Dmitriy.
>>>>
>>>>-----Original Message-----
>>>>From: Rod Johnson [mailto:rod...@in...]
>>>>Sent: Tuesday, November 11, 2003 1:34 PM
>>>>To: spr...@li...
>>>>Subject: [Springframework-developer] AOP API changes
>>>>Importance: High
>>>>
>>>>
>>>>All,
>>>>
>>>>I've just committed the current version of the AOP proposal (#2).
>>>>
>>>>All unit tests pass (naturally). However, there will be an impact on
>>>>
>>>>
>>>>
>>>>
>>>code
>>>
>>>
>>>
>>>
>>>>using the AOP API. Interceptors are unaffected, unless they relied on
>>>>
>>>>
>>>>
>>>>
>>>the
>>>
>>>
>>>
>>>
>>>>AttributeRegistry, now removed. Pointcuts _are_ affected. If you want
>>>>
>>>>
>>>>
>>>>
>>>the
>>>
>>>
>>>
>>>
>>>>old Pointcut concept (Interceptor + when to apply it) subclass
>>>>StaticMethodMatcherPointcutAdvice and it should work the same. The
>>>>RegexpPointcut is also pretty similar, but does need a reference to an
>>>>Interceptor now. (A subclass that also implemented Advice could easily
>>>>
>>>>
>>>>
>>>>
>>>add
>>>
>>>
>>>
>>>
>>>>this.)
>>>>
>>>>The ProxyConfig API has changed significantly: code using this will
>>>>
>>>>
>>>>
>>>>
>>>also be
>>>
>>>
>>>
>>>
>>>>broken.
>>>>
>>>>There's definitely scope for more abstract classes etc. to make the API
>>>>
>>>>
>>>>
>>>>
>>>more
>>>
>>>
>>>
>>>
>>>>usable. However, it is definitely more powerful now.
>>>>
>>>>I'll be producing a migration guide from the old API.
>>>>
>>>>I need to refine the comments considerably. (Help welcome!) I also need
>>>>
>>>>
>>>>
>>>>
>>>to
>>>
>>>
>>>
>>>
>>>>improve the tests for pointcut composition. Volunteers for any of these
>>>>tasks are welcome.
>>>>
>>>>Please update from CVS and check your code ASAP. With M3 coming up,
>>>>
>>>>
>>>>
>>>>
>>>it's
>>>
>>>
>>>
>>>
>>>>important that we are all sure everything works. AOP transactions
>>>>
>>>>
>>>>
>>>>
>>>shouldn't
>>>
>>>
>>>
>>>
>>>>be affected, unless they did something fancy like provided their own
>>>>MethodPointcut (now Pointcut).
>>>>
>>>>Regards,
>>>>Rod
>>>>
>>>>
|
|
From: Colin S. <col...@ex...> - 2003-11-11 21:49:35
|
I get a javac build failure on the testsuite, as follows. What is really
weird too, is that it doesn't break the build, ie testing with the
limited set of classes that has been produced, commences after the javac
failure:
buildtests:
[mkdir] Created dir: D:\src\open\spring-colin\spring\.testclasses
[javac] Compiling 205 source files to
D:\src\open\spring-colin\spring\.testc
lasses
[javac]
D:\src\open\spring-colin\spring\test\org\springframework\context\sup
port\StaticApplicationContextTestSuite.java:117:
org.springframework.context.sup
port.StaticApplicationContextTestSuite.TestAutoProxyCreator is not
abstract and
does not override abstract method
getInterceptorsAndAdvicesForBean(java.lang.Obj
ect,java.lang.String) in
org.springframework.aop.framework.support.AbstractAutoP
roxyCreator
[javac] public static class TestAutoProxyCreator extends
AbstractAutoPro
xyCreator {
[javac] ^
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -deprecation for details.
[javac] 1 error
[javac] Compile failed; see the compiler error output for details.
[copy] Copying 19 files to D:\src\open\spring-colin\spring\.testclasses
tests:
[mkdir] Created dir: D:\src\open\spring-colin\spring\junit-reports
[junit] Running org.springframework.aop.framework.AopProxyTests
...
Kopylenko, Dmitry wrote:
>All,
>
>I've just commited some minor refactorings to the aop package:
>- Refactored some names and javadocs to be compatable with new API
>
>Please re-sync.
>
>Regards,
>Dmitriy.
>
>-----Original Message-----
>From: Rod Johnson [mailto:rod...@in...]
>Sent: Tuesday, November 11, 2003 1:34 PM
>To: spr...@li...
>Subject: [Springframework-developer] AOP API changes
>Importance: High
>
>
>All,
>
>I've just committed the current version of the AOP proposal (#2).
>
>All unit tests pass (naturally). However, there will be an impact on code
>using the AOP API. Interceptors are unaffected, unless they relied on the
>AttributeRegistry, now removed. Pointcuts _are_ affected. If you want the
>old Pointcut concept (Interceptor + when to apply it) subclass
>StaticMethodMatcherPointcutAdvice and it should work the same. The
>RegexpPointcut is also pretty similar, but does need a reference to an
>Interceptor now. (A subclass that also implemented Advice could easily add
>this.)
>
>The ProxyConfig API has changed significantly: code using this will also be
>broken.
>
>There's definitely scope for more abstract classes etc. to make the API more
>usable. However, it is definitely more powerful now.
>
>I'll be producing a migration guide from the old API.
>
>I need to refine the comments considerably. (Help welcome!) I also need to
>improve the tests for pointcut composition. Volunteers for any of these
>tasks are welcome.
>
>Please update from CVS and check your code ASAP. With M3 coming up, it's
>important that we are all sure everything works. AOP transactions shouldn't
>be affected, unless they did something fancy like provided their own
>MethodPointcut (now Pointcut).
>
>Regards,
>Rod
>
>
|
|
From: Colin S. <col...@ex...> - 2003-11-11 21:56:59
|
Ok, w/regards to the compile failure not breaking the build, that's
because build.xml sets failonerror="false" for the test classes.
<javac destdir="${testbuild.dir}" target="1.3" debug="${debug}"
deprecation="false" optimize="false" failonerror="false">
<src path="${test.dir}"/>
<classpath refid="master-classpath"/>
<classpath location="${build.dir}"/>
</javac>
I can not see a good use case for having it set this way. Can I change
it to true (or take out that attr., which will default to true)?
Colin Sampaleanu wrote:
> I get a javac build failure on the testsuite, as follows. What is
> really weird too, is that it doesn't break the build, ie testing with
> the limited set of classes that has been produced, commences after the
> javac failure:
>
> buildtests:
> [mkdir] Created dir: D:\src\open\spring-colin\spring\.testclasses
> [javac] Compiling 205 source files to
> D:\src\open\spring-colin\spring\.testc
> lasses
> [javac]
> D:\src\open\spring-colin\spring\test\org\springframework\context\sup
> port\StaticApplicationContextTestSuite.java:117:
> org.springframework.context.sup
> port.StaticApplicationContextTestSuite.TestAutoProxyCreator is not
> abstract and
> does not override abstract method
> getInterceptorsAndAdvicesForBean(java.lang.Obj
> ect,java.lang.String) in
> org.springframework.aop.framework.support.AbstractAutoP
> roxyCreator
> [javac] public static class TestAutoProxyCreator extends
> AbstractAutoPro
> xyCreator {
> [javac] ^
> [javac] Note: Some input files use or override a deprecated API.
> [javac] Note: Recompile with -deprecation for details.
> [javac] 1 error
> [javac] Compile failed; see the compiler error output for details.
> [copy] Copying 19 files to
> D:\src\open\spring-colin\spring\.testclasses
>
> tests:
> [mkdir] Created dir: D:\src\open\spring-colin\spring\junit-reports
> [junit] Running org.springframework.aop.framework.AopProxyTests
> ...
>
>
> Kopylenko, Dmitry wrote:
>
>> All,
>>
>> I've just commited some minor refactorings to the aop package:
>> - Refactored some names and javadocs to be compatable with new API
>>
>> Please re-sync.
>>
>> Regards,
>> Dmitriy.
>>
>> -----Original Message-----
>> From: Rod Johnson [mailto:rod...@in...] Sent: Tuesday,
>> November 11, 2003 1:34 PM
>> To: spr...@li...
>> Subject: [Springframework-developer] AOP API changes
>> Importance: High
>>
>>
>> All,
>>
>> I've just committed the current version of the AOP proposal (#2).
>>
>> All unit tests pass (naturally). However, there will be an impact on
>> code
>> using the AOP API. Interceptors are unaffected, unless they relied on
>> the
>> AttributeRegistry, now removed. Pointcuts _are_ affected. If you want
>> the
>> old Pointcut concept (Interceptor + when to apply it) subclass
>> StaticMethodMatcherPointcutAdvice and it should work the same. The
>> RegexpPointcut is also pretty similar, but does need a reference to an
>> Interceptor now. (A subclass that also implemented Advice could
>> easily add
>> this.)
>>
>> The ProxyConfig API has changed significantly: code using this will
>> also be
>> broken.
>>
>> There's definitely scope for more abstract classes etc. to make the
>> API more
>> usable. However, it is definitely more powerful now.
>>
>> I'll be producing a migration guide from the old API.
>>
>> I need to refine the comments considerably. (Help welcome!) I also
>> need to
>> improve the tests for pointcut composition. Volunteers for any of these
>> tasks are welcome.
>>
>> Please update from CVS and check your code ASAP. With M3 coming up, it's
>> important that we are all sure everything works. AOP transactions
>> shouldn't
>> be affected, unless they did something fancy like provided their own
>> MethodPointcut (now Pointcut).
>>
>> Regards,
>> Rod
>>
>
|
|
From: Alef A. \(JTeam\) <al...@jt...> - 2003-11-11 22:14:01
|
Probably from way back, when metadata tests where not compiling, might
have been me committing it... Not sure...
Anyway, as far as I'm concerned you can change it back to true
Alef
> -----Oorspronkelijk bericht-----
> Van: spr...@li...
> [mailto:spr...@li...]
> Namens Colin Sampaleanu
> Verzonden: Tuesday, November 11, 2003 10:57 PM
> Aan: spr...@li...
> Onderwerp: Re: [Springframework-developer] AOP API changes
>
>
> Ok, w/regards to the compile failure not breaking the build, that's
> because build.xml sets failonerror="false" for the test classes.
> <javac destdir="${testbuild.dir}" target="1.3"
> debug="${debug}"
> deprecation="false" optimize="false" failonerror="false">
> <src path="${test.dir}"/>
> <classpath refid="master-classpath"/>
> <classpath location="${build.dir}"/>
> </javac>
> I can not see a good use case for having it set this way. Can
> I change
> it to true (or take out that attr., which will default to true)?
>
>
>
> Colin Sampaleanu wrote:
>
> > I get a javac build failure on the testsuite, as follows. What is
> > really weird too, is that it doesn't break the build, ie
> testing with
> > the limited set of classes that has been produced,
> commences after the
> > javac failure:
> >
> > buildtests:
> > [mkdir] Created dir: D:\src\open\spring-colin\spring\.testclasses
> > [javac] Compiling 205 source files to
> > D:\src\open\spring-colin\spring\.testc
> > lasses
> > [javac]
> > D:\src\open\spring-colin\spring\test\org\springframework\context\sup
> > port\StaticApplicationContextTestSuite.java:117:
> > org.springframework.context.sup
> > port.StaticApplicationContextTestSuite.TestAutoProxyCreator is not
> > abstract and
> > does not override abstract method
> > getInterceptorsAndAdvicesForBean(java.lang.Obj
> > ect,java.lang.String) in
> > org.springframework.aop.framework.support.AbstractAutoP
> > roxyCreator
> > [javac] public static class TestAutoProxyCreator extends
> > AbstractAutoPro
> > xyCreator {
> > [javac] ^
> > [javac] Note: Some input files use or override a deprecated API.
> > [javac] Note: Recompile with -deprecation for details.
> > [javac] 1 error
> > [javac] Compile failed; see the compiler error output
> for details.
> > [copy] Copying 19 files to
> > D:\src\open\spring-colin\spring\.testclasses
> >
> > tests:
> > [mkdir] Created dir:
> D:\src\open\spring-colin\spring\junit-reports
> > [junit] Running org.springframework.aop.framework.AopProxyTests
> > ...
> >
> >
> > Kopylenko, Dmitry wrote:
> >
> >> All,
> >>
> >> I've just commited some minor refactorings to the aop package:
> >> - Refactored some names and javadocs to be compatable with new API
> >>
> >> Please re-sync.
> >>
> >> Regards,
> >> Dmitriy.
> >>
> >> -----Original Message-----
> >> From: Rod Johnson [mailto:rod...@in...]
> Sent: Tuesday,
> >> November 11, 2003 1:34 PM
> >> To: spr...@li...
> >> Subject: [Springframework-developer] AOP API changes
> >> Importance: High
> >>
> >>
> >> All,
> >>
> >> I've just committed the current version of the AOP proposal (#2).
> >>
> >> All unit tests pass (naturally). However, there will be an
> impact on
> >> code
> >> using the AOP API. Interceptors are unaffected, unless
> they relied on
> >> the
> >> AttributeRegistry, now removed. Pointcuts _are_ affected.
> If you want
> >> the
> >> old Pointcut concept (Interceptor + when to apply it) subclass
> >> StaticMethodMatcherPointcutAdvice and it should work the same. The
> >> RegexpPointcut is also pretty similar, but does need a
> reference to an
> >> Interceptor now. (A subclass that also implemented Advice could
> >> easily add
> >> this.)
> >>
> >> The ProxyConfig API has changed significantly: code using this will
> >> also be
> >> broken.
> >>
> >> There's definitely scope for more abstract classes etc. to make the
> >> API more
> >> usable. However, it is definitely more powerful now.
> >>
> >> I'll be producing a migration guide from the old API.
> >>
> >> I need to refine the comments considerably. (Help welcome!) I also
> >> need to
> >> improve the tests for pointcut composition. Volunteers for
> any of these
> >> tasks are welcome.
> >>
> >> Please update from CVS and check your code ASAP. With M3
> coming up,
> >> it's important that we are all sure everything works. AOP
> >> transactions shouldn't be affected, unless they did
> something fancy
> >> like provided their own MethodPointcut (now Pointcut).
> >>
> >> Regards,
> >> Rod
> >>
> >
>
>
>
>
> -------------------------------------------------------
> This SF.Net email sponsored by: ApacheCon 2003,
> 16-19 November in Las Vegas. Learn firsthand the latest
> developments in Apache, PHP, Perl, XML, Java, MySQL, WebDAV,
> and more! http://www.apachecon.com/
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>
|
|
From: Colin S. <col...@ex...> - 2003-11-11 22:25:34
|
But that flag doesn't work the way somebody thought it does. If javac
breaks in the middle of compiling 150 files, I think whoever set it that
way thought it would still compile the other 149 files, but in fact it
just gives up completely on the rest of the files. In my case for
example, only 19 tests got compiled ok, then the build continued because
of the flag, and all those (19) tests ran ok. Unless you actually look
at the output during the compilation stage, you would never know that
most of the files never got compiled or run.
I'll set the flag back the other way.
Alef Arendsen (JTeam) wrote:
>Probably from way back, when metadata tests where not compiling, might
>have been me committing it... Not sure...
>
>Anyway, as far as I'm concerned you can change it back to true
>
>Alef
>
>
>
>>-----Oorspronkelijk bericht-----
>>Van: spr...@li...
>>[mailto:spr...@li...]
>> Namens Colin Sampaleanu
>>Verzonden: Tuesday, November 11, 2003 10:57 PM
>>Aan: spr...@li...
>>Onderwerp: Re: [Springframework-developer] AOP API changes
>>
>>
>>Ok, w/regards to the compile failure not breaking the build, that's
>>because build.xml sets failonerror="false" for the test classes.
>> <javac destdir="${testbuild.dir}" target="1.3"
>>debug="${debug}"
>> deprecation="false" optimize="false" failonerror="false">
>> <src path="${test.dir}"/>
>> <classpath refid="master-classpath"/>
>> <classpath location="${build.dir}"/>
>> </javac>
>>I can not see a good use case for having it set this way. Can
>>I change
>>it to true (or take out that attr., which will default to true)?
>>
>>
>>
>>Colin Sampaleanu wrote:
>>
>>
>>
>>>I get a javac build failure on the testsuite, as follows. What is
>>>really weird too, is that it doesn't break the build, ie
>>>
>>>
>>testing with
>>
>>
>>>the limited set of classes that has been produced,
>>>
>>>
>>commences after the
>>
>>
>>>javac failure:
>>>
>>>buildtests:
>>> [mkdir] Created dir: D:\src\open\spring-colin\spring\.testclasses
>>> [javac] Compiling 205 source files to
>>>D:\src\open\spring-colin\spring\.testc
>>>lasses
>>> [javac]
>>>D:\src\open\spring-colin\spring\test\org\springframework\context\sup
>>>port\StaticApplicationContextTestSuite.java:117:
>>>org.springframework.context.sup
>>>port.StaticApplicationContextTestSuite.TestAutoProxyCreator is not
>>>abstract and
>>>does not override abstract method
>>>getInterceptorsAndAdvicesForBean(java.lang.Obj
>>>ect,java.lang.String) in
>>>org.springframework.aop.framework.support.AbstractAutoP
>>>roxyCreator
>>> [javac] public static class TestAutoProxyCreator extends
>>>AbstractAutoPro
>>>xyCreator {
>>> [javac] ^
>>> [javac] Note: Some input files use or override a deprecated API.
>>> [javac] Note: Recompile with -deprecation for details.
>>> [javac] 1 error
>>> [javac] Compile failed; see the compiler error output
>>>
>>>
>>for details.
>>
>>
>>> [copy] Copying 19 files to
>>>D:\src\open\spring-colin\spring\.testclasses
>>>
>>>tests:
>>> [mkdir] Created dir:
>>>
>>>
>>D:\src\open\spring-colin\spring\junit-reports
>>
>>
>>> [junit] Running org.springframework.aop.framework.AopProxyTests
>>> ...
>>>
>>>
>>>Kopylenko, Dmitry wrote:
>>>
>>>
>>>
>>>>All,
>>>>
>>>>I've just commited some minor refactorings to the aop package:
>>>>- Refactored some names and javadocs to be compatable with new API
>>>>
>>>>Please re-sync.
>>>>
>>>>Regards,
>>>>Dmitriy.
>>>>
>>>>-----Original Message-----
>>>>From: Rod Johnson [mailto:rod...@in...]
>>>>
>>>>
>>Sent: Tuesday,
>>
>>
>>>>November 11, 2003 1:34 PM
>>>>To: spr...@li...
>>>>Subject: [Springframework-developer] AOP API changes
>>>>Importance: High
>>>>
>>>>
>>>>All,
>>>>
>>>>I've just committed the current version of the AOP proposal (#2).
>>>>
>>>>All unit tests pass (naturally). However, there will be an
>>>>
>>>>
>>impact on
>>
>>
>>>>code
>>>>using the AOP API. Interceptors are unaffected, unless
>>>>
>>>>
>>they relied on
>>
>>
>>>>the
>>>>AttributeRegistry, now removed. Pointcuts _are_ affected.
>>>>
>>>>
>>If you want
>>
>>
>>>>the
>>>>old Pointcut concept (Interceptor + when to apply it) subclass
>>>>StaticMethodMatcherPointcutAdvice and it should work the same. The
>>>>RegexpPointcut is also pretty similar, but does need a
>>>>
>>>>
>>reference to an
>>
>>
>>>>Interceptor now. (A subclass that also implemented Advice could
>>>>easily add
>>>>this.)
>>>>
>>>>The ProxyConfig API has changed significantly: code using this will
>>>>also be
>>>>broken.
>>>>
>>>>There's definitely scope for more abstract classes etc. to make the
>>>>API more
>>>>usable. However, it is definitely more powerful now.
>>>>
>>>>I'll be producing a migration guide from the old API.
>>>>
>>>>I need to refine the comments considerably. (Help welcome!) I also
>>>>need to
>>>>improve the tests for pointcut composition. Volunteers for
>>>>
>>>>
>>any of these
>>
>>
>>>>tasks are welcome.
>>>>
>>>>Please update from CVS and check your code ASAP. With M3
>>>>
>>>>
>>coming up,
>>
>>
>>>>it's important that we are all sure everything works. AOP
>>>>transactions shouldn't be affected, unless they did
>>>>
>>>>
>>something fancy
>>
>>
>>>>like provided their own MethodPointcut (now Pointcut).
>>>>
>>>>Regards,
>>>>Rod
>>>>
>>>>
>>>>
|
|
From: Rod J. <rod...@in...> - 2003-11-11 23:30:38
|
+1. Should be true.
----- Original Message -----
From: "Alef Arendsen (JTeam)" <al...@jt...>
To: <spr...@li...>
Sent: Tuesday, November 11, 2003 10:12 PM
Subject: RE: [Springframework-developer] AOP API changes
> Probably from way back, when metadata tests where not compiling, might
> have been me committing it... Not sure...
>
> Anyway, as far as I'm concerned you can change it back to true
>
> Alef
>
> > -----Oorspronkelijk bericht-----
> > Van: spr...@li...
> > [mailto:spr...@li...]
> > Namens Colin Sampaleanu
> > Verzonden: Tuesday, November 11, 2003 10:57 PM
> > Aan: spr...@li...
> > Onderwerp: Re: [Springframework-developer] AOP API changes
> >
> >
> > Ok, w/regards to the compile failure not breaking the build, that's
> > because build.xml sets failonerror="false" for the test classes.
> > <javac destdir="${testbuild.dir}" target="1.3"
> > debug="${debug}"
> > deprecation="false" optimize="false" failonerror="false">
> > <src path="${test.dir}"/>
> > <classpath refid="master-classpath"/>
> > <classpath location="${build.dir}"/>
> > </javac>
> > I can not see a good use case for having it set this way. Can
> > I change
> > it to true (or take out that attr., which will default to true)?
> >
> >
> >
> > Colin Sampaleanu wrote:
> >
> > > I get a javac build failure on the testsuite, as follows. What is
> > > really weird too, is that it doesn't break the build, ie
> > testing with
> > > the limited set of classes that has been produced,
> > commences after the
> > > javac failure:
> > >
> > > buildtests:
> > > [mkdir] Created dir: D:\src\open\spring-colin\spring\.testclasses
> > > [javac] Compiling 205 source files to
> > > D:\src\open\spring-colin\spring\.testc
> > > lasses
> > > [javac]
> > > D:\src\open\spring-colin\spring\test\org\springframework\context\sup
> > > port\StaticApplicationContextTestSuite.java:117:
> > > org.springframework.context.sup
> > > port.StaticApplicationContextTestSuite.TestAutoProxyCreator is not
> > > abstract and
> > > does not override abstract method
> > > getInterceptorsAndAdvicesForBean(java.lang.Obj
> > > ect,java.lang.String) in
> > > org.springframework.aop.framework.support.AbstractAutoP
> > > roxyCreator
> > > [javac] public static class TestAutoProxyCreator extends
> > > AbstractAutoPro
> > > xyCreator {
> > > [javac] ^
> > > [javac] Note: Some input files use or override a deprecated API.
> > > [javac] Note: Recompile with -deprecation for details.
> > > [javac] 1 error
> > > [javac] Compile failed; see the compiler error output
> > for details.
> > > [copy] Copying 19 files to
> > > D:\src\open\spring-colin\spring\.testclasses
> > >
> > > tests:
> > > [mkdir] Created dir:
> > D:\src\open\spring-colin\spring\junit-reports
> > > [junit] Running org.springframework.aop.framework.AopProxyTests
> > > ...
> > >
> > >
> > > Kopylenko, Dmitry wrote:
> > >
> > >> All,
> > >>
> > >> I've just commited some minor refactorings to the aop package:
> > >> - Refactored some names and javadocs to be compatable with new API
> > >>
> > >> Please re-sync.
> > >>
> > >> Regards,
> > >> Dmitriy.
> > >>
> > >> -----Original Message-----
> > >> From: Rod Johnson [mailto:rod...@in...]
> > Sent: Tuesday,
> > >> November 11, 2003 1:34 PM
> > >> To: spr...@li...
> > >> Subject: [Springframework-developer] AOP API changes
> > >> Importance: High
> > >>
> > >>
> > >> All,
> > >>
> > >> I've just committed the current version of the AOP proposal (#2).
> > >>
> > >> All unit tests pass (naturally). However, there will be an
> > impact on
> > >> code
> > >> using the AOP API. Interceptors are unaffected, unless
> > they relied on
> > >> the
> > >> AttributeRegistry, now removed. Pointcuts _are_ affected.
> > If you want
> > >> the
> > >> old Pointcut concept (Interceptor + when to apply it) subclass
> > >> StaticMethodMatcherPointcutAdvice and it should work the same. The
> > >> RegexpPointcut is also pretty similar, but does need a
> > reference to an
> > >> Interceptor now. (A subclass that also implemented Advice could
> > >> easily add
> > >> this.)
> > >>
> > >> The ProxyConfig API has changed significantly: code using this will
> > >> also be
> > >> broken.
> > >>
> > >> There's definitely scope for more abstract classes etc. to make the
> > >> API more
> > >> usable. However, it is definitely more powerful now.
> > >>
> > >> I'll be producing a migration guide from the old API.
> > >>
> > >> I need to refine the comments considerably. (Help welcome!) I also
> > >> need to
> > >> improve the tests for pointcut composition. Volunteers for
> > any of these
> > >> tasks are welcome.
> > >>
> > >> Please update from CVS and check your code ASAP. With M3
> > coming up,
> > >> it's important that we are all sure everything works. AOP
> > >> transactions shouldn't be affected, unless they did
> > something fancy
> > >> like provided their own MethodPointcut (now Pointcut).
> > >>
> > >> Regards,
> > >> Rod
> > >>
> > >
> >
> >
> >
> >
> > -------------------------------------------------------
> > This SF.Net email sponsored by: ApacheCon 2003,
> > 16-19 November in Las Vegas. Learn firsthand the latest
> > developments in Apache, PHP, Perl, XML, Java, MySQL, WebDAV,
> > and more! http://www.apachecon.com/
> > _______________________________________________
> > Springframework-developer mailing list
> > Spr...@li...
> > https://lists.sourceforge.net/lists/listinfo/springframework-developer
> >
>
>
>
> -------------------------------------------------------
> This SF.Net email sponsored by: ApacheCon 2003,
> 16-19 November in Las Vegas. Learn firsthand the latest
> developments in Apache, PHP, Perl, XML, Java, MySQL,
> WebDAV, and more! http://www.apachecon.com/
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>
|
