Re: [Springframework-developer] AOP API changes

[Colin S. <col...@ex...>]

Ok, I am able to build and run all tests ok, with the exception of 
FormatHelperTests, which builds ok but fails.

I've modified build.xml to fail on any javac errors on any of the 
targets using javac.

I have also tried this build of Spring with my main app using Spring, 
which does _not_ use any of the AOP stuff directly, and all seems to 
work ok.



Kopylenko, Dmitry wrote:

>I just fixed it. Please re-sync.
>
>Dmitriy.
>
>-----Original Message-----
>From: Colin Sampaleanu
>To: spr...@li...;
>dko...@ac...
>Sent: 11/11/2003 4:49 PM
>Subject: Re: [Springframework-developer] AOP API changes
>
>I get a javac build failure on the testsuite, as follows. What is really
>
>weird too, is that it doesn't break the build, ie testing with the 
>limited set of classes that has been produced, commences after the javac
>
>failure:
>
>buildtests:
>    [mkdir] Created dir: D:\src\open\spring-colin\spring\.testclasses
>    [javac] Compiling 205 source files to 
>D:\src\open\spring-colin\spring\.testc
>lasses
>    [javac] 
>D:\src\open\spring-colin\spring\test\org\springframework\context\sup
>port\StaticApplicationContextTestSuite.java:117: 
>org.springframework.context.sup
>port.StaticApplicationContextTestSuite.TestAutoProxyCreator is not 
>abstract and
>does not override abstract method 
>getInterceptorsAndAdvicesForBean(java.lang.Obj
>ect,java.lang.String) in 
>org.springframework.aop.framework.support.AbstractAutoP
>roxyCreator
>    [javac]     public static class TestAutoProxyCreator extends 
>AbstractAutoPro
>xyCreator {
>    [javac]                       ^
>    [javac] Note: Some input files use or override a deprecated API.
>    [javac] Note: Recompile with -deprecation for details.
>    [javac] 1 error
>    [javac] Compile failed; see the compiler error output for details.
>     [copy] Copying 19 files to
>D:\src\open\spring-colin\spring\.testclasses
>
>tests:
>    [mkdir] Created dir: D:\src\open\spring-colin\spring\junit-reports
>    [junit] Running org.springframework.aop.framework.AopProxyTests
>   ...
>
>
>Kopylenko, Dmitry wrote:
>
>  
>
>>All,
>>
>>I've just commited some minor refactorings to the aop package:
>>- Refactored some names and javadocs to be compatable with new API
>>
>>Please re-sync.
>>
>>Regards,
>>Dmitriy.
>>
>>-----Original Message-----
>>From: Rod Johnson [mailto:rod...@in...] 
>>Sent: Tuesday, November 11, 2003 1:34 PM
>>To: spr...@li...
>>Subject: [Springframework-developer] AOP API changes
>>Importance: High
>>
>>
>>All,
>>
>>I've just committed the current version of the AOP proposal (#2).
>>
>>All unit tests pass (naturally). However, there will be an impact on
>>    
>>
>code
>  
>
>>using the AOP API. Interceptors are unaffected, unless they relied on
>>    
>>
>the
>  
>
>>AttributeRegistry, now removed. Pointcuts _are_ affected. If you want
>>    
>>
>the
>  
>
>>old Pointcut concept (Interceptor + when to apply it) subclass
>>StaticMethodMatcherPointcutAdvice and it should work the same. The
>>RegexpPointcut is also pretty similar, but does need a reference to an
>>Interceptor now. (A subclass that also implemented Advice could easily
>>    
>>
>add
>  
>
>>this.)
>>
>>The ProxyConfig API has changed significantly: code using this will
>>    
>>
>also be
>  
>
>>broken.
>>
>>There's definitely scope for more abstract classes etc. to make the API
>>    
>>
>more
>  
>
>>usable. However, it is definitely more powerful now.
>>
>>I'll be producing a migration guide from the old API.
>>
>>I need to refine the comments considerably. (Help welcome!) I also need
>>    
>>
>to
>  
>
>>improve the tests for pointcut composition. Volunteers for any of these
>>tasks are welcome.
>>
>>Please update from CVS and check your code ASAP. With M3 coming up,
>>    
>>
>it's
>  
>
>>important that we are all sure everything works. AOP transactions
>>    
>>
>shouldn't
>  
>
>>be affected, unless they did something fancy like provided their own
>>MethodPointcut (now Pointcut).
>>
>>Regards,
>>Rod
>> 
>>