springframework-developer — Spring Framework developers list

RE: [Springframework-developer] i21.tld -> spring.tld

[<pr...@se...>]

>>The only name change left should be "com.interface21" -
> "org.springframework" 
>>then. I still consider the first 1.0 RC the best candidate for that
>>move. Can someone try to figure out what we need to in terms of CVS 
>>and SourceForge to avoid losing our version history?

I've done this in personal work, were I have command-line access to the 
repository.  You can't do this, but you can email SF and have them do it for 
you (see https://sourceforge.net/docman/display_doc.php?
docid=768&group_id=1#moveandpreservehistory).  

Just to remind you of the locations, you need to rquest them to rename the  
directories "com" and "interface21" to "org" and "springframework" under the 
directories "src", "test", "livetest", and "sandbox".  Once they (SF) make 
this name change, simply check out a fresh copy of the project, and you'll 
need to manually change all references in the source (package declarations, 
imports, etc.).  Also realize that for a brief period CVS will be "VERY" 
corrupt (naming problems, etc.).  You can't lock CVS from public, so just post 
note on website letting people know.  For developers, everyone should 
basically be told "hands off" while CVS is corrupt.  Either have 1 person do 
all naming changes, or "split up" the code into sections and have everyone 
name change a piece.  All sections should then be checked in with the updated 
naming (note that no tests will pass during this commmit :) ), and then 1 or 
more people should check out the name-changed project and start running tests 
to make sure nothing was missed.

Sorry for such a long email, but I've done this before (and it can be 
painful ;) ).

Trevor D. Cook

RE: [Springframework-developer] Summary of pending points

[<jue...@we...>]

I've just tested the issue with Tomcat 4.0, Tomcat 4.1, Resin 2.1, and =
Orion 2.0.2: All of these extract the URL path correctly both with and =
without a URL-encoded session id. So I wonder what web container you're =
using - does JBoss/Jetty have an issue here?

The root cause is that the container incorrectly resolves =
request.getRequestURI so that it includes the ";" part in your case. =
Simply checking for ";" and cutting the URI before it in WebUtils should =
help, instead of explicitly checking for ";jsessionid".

Juergen


-----Original Message-----
From: Alef Arendsen (JTeam) [mailto:al...@jt...]
Sent: Friday, July 25, 2003 2:56 PM
To: jp....@ti...
Cc: 'springframework-developer'
Subject: RE: [Springframework-developer] Summary of pending points


Arghh, stupid,

Anyway, the modified WebUtils is now included...

Alef

-----Oorspronkelijk bericht-----
Van: jp....@ti... [mailto:jp....@ti...]=20
Verzonden: Friday, July 25, 2003 2:49 PM
Aan: alef
CC: springframework-developer
Onderwerp: RE: [Springframework-developer] Summary of pending points


Hi Alef,

It seems you joined twice the testSuite and not the Webutils itself.

I didn't, for now, take the time for searching a solution for the
";jsessionid" issue, but I am still tired with it. So, it's very good to
hear anyone works at this.

Regards,
Jean-Pierre=20

---------- Initial Header -----------

From      : spr...@li...
To          : "'springframework-developer'"
<spr...@li...>
Cc          :=20
Date      : Fri, 25 Jul 2003 13:28:59 +0200
Subject : RE: [Springframework-developer] Summary of pending points

There's an (for my situation major) issue with the WebUtils :(

I've got an UrlMapping saying **/*.view --> SomeController

http://localhost/site/external/login-login.view
works, while
http://localhost/site/external/login-login.view;jsessionid=3D2c4s7a1vds3g=
b
.jboss1
does not. But actually it should!

I've prepared a fix for the issue, which involves adding a
conditionality to the getPathWithinServletMapping() and the
getPathWithinApplication() methods (in WebUtils). I've been able to test
the getPathWithinApplication()-method (using the WebUtilsTestSuite) and
basically it works. However, the getPathWithinServletMapping() method I
can't really test, because in the MockServlet*** classes, there's no
MockServletMapping yet (and I haven't got the time to add this before
the 0.9.1 release).

The fix works however for my application (for both URL-rewriting
requests and non-URL-rewriting requests). All other tests still succeed.

But, since I'm not able to test everything enough and don't know the
rest of the web stuff enough to know what the impact is, I am kind of
reluctant to add it, with the 0.9.1 release coming next week...

Is there somebody that can find the time to figure out everything still
works (or just says, yeah, it's ok ;-)?? The modified WebUtils and the
WebUtilsTestSuite are attached to the email...

Cheers,

Alef


********** L'ADSL A 20 EUR/MOIS**********
Tiscali propose l'ADSL le moins cher du march=E9 : 20 EUR/mois et le =
modem
ADSL offert !=20
Pour profiter de cette offre exceptionnelle, cliquez ici :
http://register.tiscali.fr/adsl/ Offre soumise =E0 conditions.

RE: [Springframework-developer] Summary of pending points

[Alef A. \(JTeam\) <al...@jt...>]

Arghh, stupid,

Anyway, the modified WebUtils is now included...

Alef

-----Oorspronkelijk bericht-----
Van: jp....@ti... [mailto:jp....@ti...]=20
Verzonden: Friday, July 25, 2003 2:49 PM
Aan: alef
CC: springframework-developer
Onderwerp: RE: [Springframework-developer] Summary of pending points


Hi Alef,

It seems you joined twice the testSuite and not the Webutils itself.

I didn't, for now, take the time for searching a solution for the
";jsessionid" issue, but I am still tired with it. So, it's very good to
hear anyone works at this.

Regards,
Jean-Pierre=20

---------- Initial Header -----------

From      : spr...@li...
To          : "'springframework-developer'"
<spr...@li...>
Cc          :=20
Date      : Fri, 25 Jul 2003 13:28:59 +0200
Subject : RE: [Springframework-developer] Summary of pending points

There's an (for my situation major) issue with the WebUtils :(

I've got an UrlMapping saying **/*.view --> SomeController

http://localhost/site/external/login-login.view
works, while
http://localhost/site/external/login-login.view;jsessionid=3D2c4s7a1vds3g=
b
.jboss1
does not. But actually it should!

I've prepared a fix for the issue, which involves adding a
conditionality to the getPathWithinServletMapping() and the
getPathWithinApplication() methods (in WebUtils). I've been able to test
the getPathWithinApplication()-method (using the WebUtilsTestSuite) and
basically it works. However, the getPathWithinServletMapping() method I
can't really test, because in the MockServlet*** classes, there's no
MockServletMapping yet (and I haven't got the time to add this before
the 0.9.1 release).

The fix works however for my application (for both URL-rewriting
requests and non-URL-rewriting requests). All other tests still succeed.

But, since I'm not able to test everything enough and don't know the
rest of the web stuff enough to know what the impact is, I am kind of
reluctant to add it, with the 0.9.1 release coming next week...

Is there somebody that can find the time to figure out everything still
works (or just says, yeah, it's ok ;-)?? The modified WebUtils and the
WebUtilsTestSuite are attached to the email...

Cheers,

Alef


********** L'ADSL A 20 EUR/MOIS**********
Tiscali propose l'ADSL le moins cher du march=E9 : 20 EUR/mois et le =
modem
ADSL offert !=20
Pour profiter de cette offre exceptionnelle, cliquez ici :
http://register.tiscali.fr/adsl/ Offre soumise =E0 conditions.

[Springframework-developer] =?iso-8859-1?Q?RE:_[Springframework-developer]_Summary_of_pending_points?=

[=?iso-8859-1?Q?<jp....@ti...>]

Hi Alef,=0D=0A=0D=0AIt seems you joined twice the testSuite and not the W=
ebutils itself.=0D=0A=0D=0AI didn't, for now, take the time for searching=
 a solution for the ";jsessionid" issue, but I am still tired with it. So=
, it's very good to hear anyone works at this.=0D=0A=0D=0ARegards,=0D=0AJ=
ean-Pierre =0D=0A=0D=0A---------- Initial Header -----------=0D=0A=0D=0AF=
rom      : spr...@li...=0D=0ATo =
         : "'springframework-developer'" <springframework-developer@lists=
.sourceforge.net>=0D=0ACc          : =0D=0ADate      : Fri, 25 Jul 2003 1=
3:28:59 +0200=0D=0ASubject : RE: [Springframework-developer] Summary of p=
ending points=0D=0A=0D=0AThere's an (for my situation major) issue with t=
he WebUtils :(=0D=0A=0D=0AI've got an UrlMapping saying **/*.view --> Som=
eController=0D=0A=0D=0Ahttp://localhost/site/external/login-login.view=0D=
=0Aworks, while=0D=0Ahttp://localhost/site/external/login-login.view;jses=
sionid=3D2c4s7a1vds3gb=0D=0A.jboss1=0D=0Adoes not. But actually it should=
!=0D=0A=0D=0AI've prepared a fix for the issue, which involves adding a=0D=
=0Aconditionality to the getPathWithinServletMapping() and the=0D=0AgetPa=
thWithinApplication() methods (in WebUtils). I've been able to test=0D=0A=
the getPathWithinApplication()-method (using the WebUtilsTestSuite) and=0D=
=0Abasically it works. However, the getPathWithinServletMapping() method =
I=0D=0Acan't really test, because in the MockServlet*** classes, there's =
no=0D=0AMockServletMapping yet (and I haven't got the time to add this be=
fore=0D=0Athe 0.9.1 release).=0D=0A=0D=0AThe fix works however for my app=
lication (for both URL-rewriting=0D=0Arequests and non-URL-rewriting requ=
ests). All other tests still succeed.=0D=0A=0D=0ABut, since I'm not able =
to test everything enough and don't know the=0D=0Arest of the web stuff e=
nough to know what the impact is, I am kind of=0D=0Areluctant to add it, =
with the 0.9.1 release coming next week...=0D=0A=0D=0AIs there somebody t=
hat can find the time to figure out everything still=0D=0Aworks (or just =
says, yeah, it's ok ;-)?? The modified WebUtils and the=0D=0AWebUtilsTest=
Suite are attached to the email...=0D=0A=0D=0ACheers,=0D=0A=0D=0AAlef=0D=0A=
=0A=0A********** L'ADSL A 20 EUR/MOIS**********=0ATiscali propose l'ADSL =
le moins cher du march=E9 : 20 EUR/mois et le modem ADSL offert ! =0APour=
 profiter de cette offre exceptionnelle, cliquez ici : http://register.ti=
scali.fr/adsl/=0AOffre soumise =E0 conditions.=0A

RE: [Springframework-developer] Summary of pending points

[Alef A. \(JTeam\) <al...@jt...>]

There's an (for my situation major) issue with the WebUtils :(

I've got an UrlMapping saying **/*.view --> SomeController

http://localhost/site/external/login-login.view
works, while
http://localhost/site/external/login-login.view;jsessionid=2c4s7a1vds3gb
.jboss1
does not. But actually it should!

I've prepared a fix for the issue, which involves adding a
conditionality to the getPathWithinServletMapping() and the
getPathWithinApplication() methods (in WebUtils). I've been able to test
the getPathWithinApplication()-method (using the WebUtilsTestSuite) and
basically it works. However, the getPathWithinServletMapping() method I
can't really test, because in the MockServlet*** classes, there's no
MockServletMapping yet (and I haven't got the time to add this before
the 0.9.1 release).

The fix works however for my application (for both URL-rewriting
requests and non-URL-rewriting requests). All other tests still succeed.

But, since I'm not able to test everything enough and don't know the
rest of the web stuff enough to know what the impact is, I am kind of
reluctant to add it, with the 0.9.1 release coming next week...

Is there somebody that can find the time to figure out everything still
works (or just says, yeah, it's ok ;-)?? The modified WebUtils and the
WebUtilsTestSuite are attached to the email...

Cheers,

Alef

Re: [Springframework-developer] Summary of pending points

[<jue...@we...>]

V2UncmUgYWxyZWFkeSB1c2luZyB0aGUgY3VycmVudCB2ZXJzaW9uIG9mIEFPUCBzdXBwb3J0IGZv
ciBkZWNsYXJhdGl2ZSB0cmFuc2FjdGlvbnMgaW4gYSBuZXcgcHJvamVjdCAoYW4gaW1hZ2UgbWFu
YWdlbWVudCBzeXN0ZW0gYmFzZWQgb24gT3JhY2xlIEludGVybWVkaWEpIC0gd29ya3MgbmljZWx5
IHNvIGZhciEgUmVnYXJkaW5nIHRoZSBFSkIgc3VwcG9ydCBjbGFzc2VzOiBJIHRoaW5rIHRoZXkg
Y2FuIHNhZmVseSBnbyBpbnRvIDAuOS4xLiANCg0KQlRXLCBJJ3ZlIHBvbGlzaGVkIHF1aXRlIGEg
bG90IG9mIHN0dWZmIGluIHRoZSBsYXN0IGZldyBkYXlzLCBmb3IgZXhhbXBsZSByZW1vdmVkIGFs
bCBKYXZhZG9jIGVycm9ycyBldGMuIEplYW4tUGllcnJlIGFuZCBUaG9tYXMsIGFyZSB5b3UgYm90
aCBoYXBweSB3aXRoIHRoZSByZXdvcmtlZCBNYXBwaW5nU3FsUXVlcnlXaXRoUGFyYW1ldGVycz8g
SWYgeWVzLCBwbGVhc2UgY2FyZSBmb3IgY29uc2lzdGVudCBKYXZhZG9jcywgdGhlbiBsZXQncyBj
b25zaWRlciBpdCBkb25lIQ0KDQpKZWFuLVBpZXJyZSBhbmQgS2VuOiBQbGVhc2UgcmUtdGVzdCBD
b3VudHJpZXMgYW5kIFBldGNsaW5pYyAoYmV0dGVyIGFmdGVyIHRoZSBUTEQgbmFtZSBjaGFuZ2Up
LCBlc3BlY2lhbGx5IHRoZSB2ZXJzaW9ucyB0aGF0IHRoZSByZWxlYXNlIHRhcmdldCBpbiBvdXIg
U3ByaW5nIEFudCBzY3JpcHQgZ2VuZXJhdGVzLiBTaW1wbHkgdW56aXAgdGhlIGdlbmVyYXRlZCBz
cHJpbmctZnJhbWV3b3JrLTAuOS4xLnppcCBzb21ld2hlcmUgYW5kICJhY3QgbGlrZSBhIHVzZXIi
Lg0KDQpBZ2FpbiwgaWYgYW55b25lIGhhcyBub3RpY2VkIHNvbWUgaW5jb25zaXN0ZW5jeSBvciBv
dGhlciBzdHVmZiB0aGF0IG1pZ2h0IGJlIGVhc3kgdG8gZml4IChsaWtlIHRoZSBtaXNzaW5nIHJl
dHVybiB2YWx1ZSBvZiBIaWJlcm5hdGVUZW1wbGF0ZS5zYXZlIGFzIHJlcG9ydGVkIGJ5IENvbGlu
KSwgcGxlYXNlIGxldCBldmVyeWJvZHkga25vdyENCg0KSnVlcmdlbg0KDQo=

[Springframework-developer] i21.tld -> spring.tld

[<jue...@we...>]

SGkgZXZlcnlib2R5LA0KDQpJJ3ZlIGp1c3QgcmVuYW1lZCBpMjEudGxkIHRvIHNwcmluZy50bGQg
aW4gdGhlIG1haW4gc291cmNlIHRyZWUsIHJlZmxlY3RpbmcgdGhlIHVwY29taW5nIGZvY3VzIG9u
IHRoZSBuYW1lIFNwcmluZy4gRnJvbSBub3cgb24sIGl0J3MgcmVjb21tZW5kZWQgdG8gdXNlIG1h
cCB0aGUgVVJJICIvc3ByaW5nIiB0byAiL3NwcmluZy50bGQiLCB3aXRoIGEgdGFnIHByZWZpeCAi
PHNwcmluZzoiLCBpbnN0ZWFkIG9mICI8aTIxOiIuDQoNCkknbSBrZWVuIG9uIGJyaW5naW5nIDAu
OS4xIG9uZSBzdGVwIGNsb3NlciB0byBhbiAib3JnLnNwcmluZ2ZyYW1ld29yayIgMS4wIFJDIGJ5
IG1ha2luZyB0aGlzIGNoYW5nZSBub3cuIEkndmUgYWxzbyBhbHJlYWR5IGFkYXB0ZWQgdGhlIHdl
YmFwcC10eXBpY2FsIHNrZWxldG9uLCBhbmQgYm90aCBDb3VudHJpZXMgYW5kIFBldGNsaW5pYy4g
SSdsbCBjb21taXQgdGhlbSB0b2RheSBpZiBub29uZSBvYmplY3RzLiBXZSBzaG91bGQgcmVmbGVj
dCB0aGUgbmV3IHJlY29tbWVuZGF0aW9uIGFzIGVhcmx5IGFzIHBvc3NpYmxlLg0KDQpJZiBhbnlv
bmUgaGFzIGFuIGlkZWEgZm9yIGEgYmV0dGVyIHJlY29tbWVuZGVkIHByZWZpeCB0aGVuICI8c3By
aW5nOiIsIHBsZWFzZSBzYXkgc28uIEJ1dCBJIGd1ZXNzICI8c3ByaW5nOiIgaXMgc3RyYWlnaHRm
b3J3YXJkIGFuZCBzdGlsbCBub3QgdG9vIGxvbmcsIHRoaW5rIG9mICI8c3RydXRzOiIuIEFuZCBh
bnlvbmUgd2hvIGRvZXNuJ3QgbGlrZSBpdCBjYW4gc3RpbGwgdXNlIHdoYXRldmVyIHByZWZpeCBo
ZS9zaGUgcHJlZmVycy4NCg0KVGhlIG9ubHkgbmFtZSBjaGFuZ2UgbGVmdCBzaG91bGQgYmUgImNv
bS5pbnRlcmZhY2UyMSIgLT4gIm9yZy5zcHJpbmdmcmFtZXdvcmsiIHRoZW4uIEkgc3RpbGwgY29u
c2lkZXIgdGhlIGZpcnN0IDEuMCBSQyB0aGUgYmVzdCBjYW5kaWRhdGUgZm9yIHRoYXQgbW92ZS4g
Q2FuIHNvbWVvbmUgdHJ5IHRvIGZpZ3VyZSBvdXQgd2hhdCB3ZSBuZWVkIHRvIGluIHRlcm1zIG9m
IENWUyBhbmQgU291cmNlRm9yZ2UgdG8gYXZvaWQgbG9zaW5nIG91ciB2ZXJzaW9uIGhpc3Rvcnk/
DQoNCkJUVyBKZWFuLVBpZXJyZSBhbmQgS2VuLCBwbGVhc2UgcG9saXNoIHRoZSBjdXJyZW50IGNv
bmZpZyBmaWxlcyBvZiBDb3VudHJpZXMgYW5kIFBldGNsaW5pYyBhIGJpdCwgdG8gbWFrZSB0aGVt
IGFzIGNsZWFyIGFuZCBjb25zaXN0ZW50IGFzIHBvc3NpYmxlLiBJIG1haW5seSB0aGlua2luZyBh
Ym91dCB0aGUgYXBwbGljYXRpb24gY29udGV4dCBYTUwgZmlsZXMgaGVyZTogQSBjbGVhciBvcmRl
ciBvZiBiZWFuIGRlZmluaXRpb25zIGV0YyBjYW4gbWFrZSB1bmRlcnN0YW5kaW5nIG11Y2ggZWFz
aWVyLCBlc3BlY2lhbGx5IGluIGNvbWJpbmF0aW9uIHdpdGggb3VyIHNrZWxldG9ucy4NCg0KSnVl
cmdlbg0KDQoNCkRJIErDvHJnZW4gSMO2bGxlciANClNlbmlvciBTeXN0ZW0gQXJjaGl0ZWN0IA0K
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18gDQoNCndlcmszQVRTIC0gZGl2
aXNpb24gc3lzdGVtZW50d2lja2x1bmcgDQpwYXJ0IG9mIHdlcmszQVQgaW50ZXJuZXRtZWRpZW4g
b2VnIA0KDQpldXJvcGFwbGF0eiA0IA0KQSAtIDQwMjAgbGlueiANCg0KdC4gICs0MyAoMCkgNzMy
IDcxIDY1IDI5IDUwMiANCmYuICArNDMgKDApIDczMiA3MSA2NSAyOSAzIA0KanVlcmdlbi5ob2Vs
bGVyQHdlcmszYXQuY29tIA0Kd3d3LndlcmszYXQuY29tIA0KX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18gDQp3ZXJrM0FUUyAtIFdJUiBFTlRXSUNLRUxOIEVSRk9MRyANCg0K

RE : [Springframework-developer] Summary of pending points

[JP P. <jp....@ti...>]

Hi Juergen,

I have committed earlier.

The sources themselves are ok, including the doc.

I switched my application and run well with the new context param.

The testSuite doesn't for now having additional tests. This rests to
make.

In the current tests, one breaks for a non ultra-critic reason.
Nevertheless, I discarded for now the failing test by changing its name
from testAnonCustomerQuery to XtestAnonCustomerQuery.

I am not able to very quickly see what exactly is wrong. It is about the
SqlQueryTestSuite, see the Junit output:

Testcase: testAnonCustomerQuery took 0 sec
	FAILED
CommonMockConnection.PreparedStatements has un-used objects.
expected:<0> but was:<1>
junit.framework.AssertionFailedError:
CommonMockConnection.PreparedStatements has un-used objects.
expected:<0> but was:<1>
	at
com.mockobjects.ReturnObjectList.verify(ReturnObjectList.java:70)
	at com.mockobjects.util.Verifier.verifyField(Verifier.java:77)
	at
com.mockobjects.util.Verifier.verifyFieldsForClass(Verifier.java:63)
	at
com.mockobjects.util.Verifier.verifyFieldsForClass(Verifier.java:57)
	at
com.mockobjects.util.Verifier.verifyFieldsForClass(Verifier.java:57)
	at com.mockobjects.util.Verifier.verifyObject(Verifier.java:49)
	at com.mockobjects.MockObject.verify(MockObject.java:44)
	at com.mockobjects.util.Verifier.verifyField(Verifier.java:77)
	at
com.mockobjects.util.Verifier.verifyFieldsForClass(Verifier.java:63)
	at
com.mockobjects.util.Verifier.verifyFieldsForClass(Verifier.java:57)
	at
com.mockobjects.util.Verifier.verifyFieldsForClass(Verifier.java:57)
	at com.mockobjects.util.Verifier.verifyObject(Verifier.java:49)
	at com.mockobjects.MockObject.verify(MockObject.java:44)
	at
com.interface21.jdbc.object.SqlQueryTestSuite.tearDown(SqlQueryTestSuite
.java:62)

Testcase: testAnonCustomerQuery





-----Message d'origine-----
De=A0: j=FCrgen h=F6ller [werk3AT] [mailto:jue...@we...]=20
Envoy=E9=A0: jeudi 24 juillet 2003 10:36
=C0=A0: jp....@ti...
Cc=A0: trisberg; springframework-developer
Objet=A0: RE: [Springframework-developer] Summary of pending points

Fine! It would be nice if we could finish this by the end of the week.

Is anybody working on other concrete issues? I'd like to finally release
0.9.1 early next week. As far as I'm concerned, all urgent issues are
resolved, and the AOP support has already been updated.

BTW Alef, if you'd like to introduce the hooks in BindTag already for
0.9.1, feel free to do so!

Juergen


-----Original Message-----
From: jp....@ti... [mailto:jp....@ti...]
Sent: Thursday, July 24, 2003 10:36 AM
To: j=FCrgen h=F6ller [werk3AT]
Cc: trisberg; springframework-developer
Subject: RE: [Springframework-developer] Summary of pending points


>>>
 Jean-Pierre, if we agree on the above, could you make the introduction
of the context map and migrate your current application to it? I'd like
to have an actual usage of this feature before we finalize it. Thomas,
you're invited to review this stuff, of course!

Juergen
>>>


Ok, Juergen, I will do so and commit this evening.

In summary, from backward compatibility aspect, the sole change is :

the mapRow signature with parameters will have the map added.


Regards,
Jean-Pierre


********** L'ADSL A 20 EUR/MOIS**********
Tiscali propose l'ADSL le moins cher du march=E9 : 20 EUR/mois et le =
modem
ADSL offert !=20
Pour profiter de cette offre exceptionnelle, cliquez ici :
http://register.tiscali.fr/adsl/
Offre soumise =E0 conditions.

RE: [Springframework-developer] Summary of pending points

[<rod...@in...>]

>Is anybody working on other concrete issues? I'd like to 
finally release 0.9.1 early next week. As far as I'm 
concerned, all urgent issues are resolved, and the AOP 
support has already been updated. 

So long as I haven't broken anything in my fairly extensive 
AOP-oriented commits last night, I'm not working on anything 
else critical. 
**** Can anyone working with Spring AOP please check that 
their code works with the necessary changes before 0.9.1? ****

I'm planning to revise the EJB support classes by pushing up 
some of the stuff I've been doing at work. This means that 
there will again be a BeanFactory associated with an EJB 
instance (someone posted in the forum about this). I'm 
planning to introduce a BeanFactoryLoader interface so that 
an EJB could choose where the BeanFactory comes from. The 
default will be to look for an environment variable 
specifying the classpath of an XML BeanFactory 
(like /com/foo/bar/myfile.xml). I think this is nicer than 
the old JNDI way, which I've demoted to the sandbox.

Unfortunately enterprise bean and resource manager access 
isn't permitted in setSessionContext() so I've had to do it 
in ejbCreate() and introduce a protected abstract onEjbCreate
() method. Sound reasonable?

However, this is fairly low priority, and won't break 
anything else. So I'm not too bothered about getting it in 
0.9.1. I can probably safely commit it over the weekend.

In other recent checked in changes, I've introduced a static 
emptyActivatedContextBuilder() method on 
SimpleNamingContextBuilder. This allows multiple test cases 
to populate a JNDI context without ordering becoming an issue.

Regards,
Rod

RE: [Springframework-developer] Summary of pending points

[Alef A. \(JTeam\) <al...@jt...>]

The hooks for the tags are in there,

I don't really have other additions/changes before the end of this week,
I might get into documentation a little bit, but that's it...

Alef


-----Oorspronkelijk bericht-----
Van: spr...@li...
[mailto:spr...@li...] Namens
j=FCrgen h=F6ller [werk3AT]
Verzonden: Thursday, July 24, 2003 10:36 AM
Aan: jp....@ti...
CC: trisberg; springframework-developer
Onderwerp: RE: [Springframework-developer] Summary of pending points


Fine! It would be nice if we could finish this by the end of the week.

Is anybody working on other concrete issues? I'd like to finally release
0.9.1 early next week. As far as I'm concerned, all urgent issues are
resolved, and the AOP support has already been updated.

BTW Alef, if you'd like to introduce the hooks in BindTag already for
0.9.1, feel free to do so!

Juergen


-----Original Message-----
From: jp....@ti... [mailto:jp....@ti...]
Sent: Thursday, July 24, 2003 10:36 AM
To: j=FCrgen h=F6ller [werk3AT]
Cc: trisberg; springframework-developer
Subject: RE: [Springframework-developer] Summary of pending points


>>>
 Jean-Pierre, if we agree on the above, could you make the introduction
of the context map and migrate your current application to it? I'd like
to have an actual usage of this feature before we finalize it. Thomas,
you're invited to review this stuff, of course!

Juergen
>>>


Ok, Juergen, I will do so and commit this evening.

In summary, from backward compatibility aspect, the sole change is :

the mapRow signature with parameters will have the map added.


Regards,
Jean-Pierre


********** L'ADSL A 20 EUR/MOIS**********
Tiscali propose l'ADSL le moins cher du march=E9 : 20 EUR/mois et le =
modem
ADSL offert !=20
Pour profiter de cette offre exceptionnelle, cliquez ici :
http://register.tiscali.fr/adsl/ Offre soumise =E0 conditions.




-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01
/01
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

RE: [Springframework-developer] Summary of pending points

[<jue...@we...>]

Fine! It would be nice if we could finish this by the end of the week.

Is anybody working on other concrete issues? I'd like to finally release =
0.9.1 early next week. As far as I'm concerned, all urgent issues are =
resolved, and the AOP support has already been updated.

BTW Alef, if you'd like to introduce the hooks in BindTag already for =
0.9.1, feel free to do so!

Juergen


-----Original Message-----
From: jp....@ti... [mailto:jp....@ti...]
Sent: Thursday, July 24, 2003 10:36 AM
To: j=FCrgen h=F6ller [werk3AT]
Cc: trisberg; springframework-developer
Subject: RE: [Springframework-developer] Summary of pending points


>>>
 Jean-Pierre, if we agree on the above, could you make the introduction =
of the context map and migrate your current application to it? I'd like =
to have an actual usage of this feature before we finalize it. Thomas, =
you're invited to review this stuff, of course!

Juergen
>>>


Ok, Juergen, I will do so and commit this evening.

In summary, from backward compatibility aspect, the sole change is :

the mapRow signature with parameters will have the map added.


Regards,
Jean-Pierre


********** L'ADSL A 20 EUR/MOIS**********
Tiscali propose l'ADSL le moins cher du march=E9 : 20 EUR/mois et le =
modem ADSL offert !=20
Pour profiter de cette offre exceptionnelle, cliquez ici : =
http://register.tiscali.fr/adsl/
Offre soumise =E0 conditions.

[Springframework-developer] =?iso-8859-1?Q?RE:_[Springframework-developer]_Summary_of_pending_points?=

[=?iso-8859-1?Q?<jp....@ti...>]

>>>=0D=0A Jean-Pierre, if we agree on the above, could you make the intro=
duction of the context map and migrate your current application to it? I'=
d like to have an actual usage of this feature before we finalize it. Tho=
mas, you're invited to review this stuff, of course!=0D=0A=0D=0AJuergen=0D=
=0A>>>=0D=0A=0D=0A=0D=0AOk, Juergen, I will do so and commit this evening=
.=0D=0A=0D=0AIn summary, from backward compatibility aspect, the sole cha=
nge is :=0D=0A=0D=0Athe mapRow signature with parameters will have the ma=
p added.=0D=0A=0D=0A=0D=0ARegards,=0D=0AJean-Pierre=0D=0A=0A=0A**********=
 L'ADSL A 20 EUR/MOIS**********=0ATiscali propose l'ADSL le moins cher du=
 march=E9 : 20 EUR/mois et le modem ADSL offert ! =0APour profiter de cet=
te offre exceptionnelle, cliquez ici : http://register.tiscali.fr/adsl/=0A=
Offre soumise =E0 conditions.=0A

RE: [Springframework-developer] AOP Alliance API changes

[<jue...@we...>]

I've reworked TransactionAttributeSourceEditor: It now matches _all_ =
methods of a given name if overloaded, not just the first one, and =
supports "xxx*" for method names. The need arose from a concrete =
application at werk3AT that uses declarative transactions now.

BTW, I've considered using regular expressions for pattern matching, but =
I consider "java\.lang\.object\.notify.*" somewhat unintuitive. The =
"xxx*" way should just be a simple alternative to specifying each =
individual method. And switching to regex would even make individual =
specifications harder and less intuitive, as dots would have to be =
escaped.

Juergen


-----Original Message-----
From: Rod Johnson [mailto:rod...@in...]
Sent: Wednesday, July 23, 2003 9:17 PM
To: spr...@li...
Subject: [Springframework-developer] AOP Alliance API changes
Importance: High


All,

You'll recall that AOP Alliance and AOPI merged a month or so ago. The
result has been some changes to the old AOP Alliance interfaces, which
Spring 0.9 implements.

These changes don't really affect how things work, just package and =
method
naming.

I've just checked in the necessary changes (and current AOP Alliance =
jar).

This will break any interceptors you have. However, it's easy to make =
the
changes. In nearly all cases, it will involve 2 easy steps:

1. imports org.aopalliance.* -> org.aopalliance.intercept.*

2. MethodInvocation.invokeNext() -> proceed(). This is more in line with =
AOP
terminology, and still intelligible to us J2EE folk.

I was able to migrate my code in projects using Spring AOP in minutes,
including my interceptors. (The changes shouldn't affect you if you =
haven't
written your own interceptors).

**** NB: Clean before rebuilding your local copy of Spring.

I really like the new AOP Alliance APIs. I think they're very powerful =
and
quite elegant.

As an added bonus, I've checked in a regular expression pointcut:
com.interface21.aop.framework.RegexpMethodPointcut

Set a Perl5 reg exp (such as ".*set.*") as the "pattern" property and an
interceptor ref as the "interceptor" property and drop the regexp =
pointcut
name in your interceptor names for your ProxyFactoryBean and you're all =
set.

This depends on Jakarta ORO. I chose this because Struts uses it and it
seems to work well. If anyone objects strongly to this choice of reg exp
(obviously we can't go to 1.4 yet) please let me know.

I've also recently introduced a distinction between static and dynamic
pointcuts. Static pointcuts depend on the method invoked and perhaps
attributes; dynamic pointcuts also get to see the arguments.

The WildcardAttributeRegistry is a move towards a better attributes
solution, although I'm still keen to pursue source-level attributes. I =
would
love a volunteer to help drive the attributes side of things as my time =
is
limited.

Regards,
Rod




-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100003ave/direct;at.aspnet_072303_01/=
01
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

RE: [Springframework-developer] Tags using expression language??

[<jue...@we...>]

You've just been promoted to a Spring Framework developer :-)

As long as its about added getters or convenience methods or the like, =
you can simply go ahead as far as I'm concerned. I see a need for =
discussion mainly when you intend to introduce completely new classes.

Juergen


-----Original Message-----
From: Alef Arendsen (JTeam) [mailto:al...@jt...]
Sent: Thursday, July 24, 2003 9:38 AM
To: j=FCrgen h=F6ller [werk3AT];
spr...@li...
Subject: RE: [Springframework-developer] Tags using expression
language??


Yeah, of course prototypes will be discussed, I'm not even into the
framework enough to see the best possible option for some things I have
to do... I'm working on a partially publicly available version of the
site we're building that'll show the listcontroller... But I'll mention
that when it's done.

Thanx for the fix in EL-stuff...

Alef

Ah, before I forget, The unixname: 'aarendsen'




Just fixed - ExpressionEvaluationUtils supports partial expressions now!
And as I've already hinted at, you're welcome to become a developer -
just tell me your SourceForge Unix username... :-)
=20
BTW, feel free to make BindTag support nested tags. You're generally
invited to extend the tag suite if you like to, as that is low on my
personal priority list. Regarding a ListController: Sounds interesting,
but I'd suggest to discuss prototypical code before committing anything
to the main source tree.
=20
Juergen
=20
=20

	-----Urspr=FCngliche Nachricht-----=20
	Von: Alef Arendsen (JTeam) [mailto:al...@jt...]=20
	Gesendet: Mi 23.07.2003 18:54=20
	An: j=FCrgen h=F6ller [werk3AT];
spr...@li...=20
	Cc:=20
	Betreff: RE: [Springframework-developer] Tags using expression
language??
=09
=09

	Hi Juergen (I still can't find the ALT-code for u-umlaut),
=09
	There's a slight bug in the ExpressionEvaluationUtils.
	Expressionlanguage supports partial expressions combined with
strings.
	Something like this: <i21:bind path=3D"Account.${item}"/>...
=09
	The isExpressionLanguage()-method says: 'value.startsWith("${")'
while
	it should read 'value.indexOf("${") !=3D -1'. This will fix the
tag in
	order to make the example above work...
=09
	Cheers,
=09
	Alef
=09
	P.s. In one of your replies, you stated that it might be handier
for me
	(and some other people I'm constantly bothering ;-) to become a
	developer. I kind of agree with and since I'm currently
developing kind
	of a large application using Spring, I'll probably run into some
more
	minor things I would be able to commit myself directly... So if
nobody
	objects...
=09
=09
=09

RE: [Springframework-developer] Tags using expression language??

[Alef A. \(JTeam\) <al...@jt...>]

Yeah, of course prototypes will be discussed, I'm not even into the
framework enough to see the best possible option for some things I have
to do... I'm working on a partially publicly available version of the
site we're building that'll show the listcontroller... But I'll mention
that when it's done.

Thanx for the fix in EL-stuff...

Alef

Ah, before I forget, The unixname: 'aarendsen'




Just fixed - ExpressionEvaluationUtils supports partial expressions now!
And as I've already hinted at, you're welcome to become a developer -
just tell me your SourceForge Unix username... :-)
=20
BTW, feel free to make BindTag support nested tags. You're generally
invited to extend the tag suite if you like to, as that is low on my
personal priority list. Regarding a ListController: Sounds interesting,
but I'd suggest to discuss prototypical code before committing anything
to the main source tree.
=20
Juergen
=20
=20

	-----Urspr=FCngliche Nachricht-----=20
	Von: Alef Arendsen (JTeam) [mailto:al...@jt...]=20
	Gesendet: Mi 23.07.2003 18:54=20
	An: j=FCrgen h=F6ller [werk3AT];
spr...@li...=20
	Cc:=20
	Betreff: RE: [Springframework-developer] Tags using expression
language??
=09
=09

	Hi Juergen (I still can't find the ALT-code for u-umlaut),
=09
	There's a slight bug in the ExpressionEvaluationUtils.
	Expressionlanguage supports partial expressions combined with
strings.
	Something like this: <i21:bind path=3D"Account.${item}"/>...
=09
	The isExpressionLanguage()-method says: 'value.startsWith("${")'
while
	it should read 'value.indexOf("${") !=3D -1'. This will fix the
tag in
	order to make the example above work...
=09
	Cheers,
=09
	Alef
=09
	P.s. In one of your replies, you stated that it might be handier
for me
	(and some other people I'm constantly bothering ;-) to become a
	developer. I kind of agree with and since I'm currently
developing kind
	of a large application using Spring, I'll probably run into some
more
	minor things I would be able to commit myself directly... So if
nobody
	objects...
=09
=09
=09

RE: [Springframework-developer] Summary of pending points

[<tri...@tr...>]

Jürgen & Jean-Pierre,

> Let me refine your proposal a bit. We would need "Map context" on
> MappingSqlQueryWithParameters too, to be able to cascade down to the simpler
> mapRow methods. But why not avoid MappingSqlQueryWithContext in the first
> place and just add "Map context" to MappingSqlQueryWithParameters?
> 
> MappingSqlQueryWithParameters
>  abstract Object mapRow(ResultSet rs, int rowNum, Object[] parameters, Map
> context)
> 
> MappingSqlQuery
>  abstract Object mapRow(ResultSet rs, int rowNum)
> 
> Whoever wants to use the context map will probably not mind the parameters
> even if they are not needed. Of course, existing custom subclasses of
> MappingSqlQueryWithParameters would still need to be changed then. But I
> don't consider that a problem, as I assume that most users use
> MappingSqlQuery anyway, and as migration is straightforward.

I'm OK with this solution.  

Only other fully backward compatible solution would be:


    MappingSqlQueryWithParametersAndContext
       |                             |
       |                             |
MappingSqlQueryWithParameters   MappingSqlQueryWithContext
       |
       |
MappingSqlQuery


And that seems a bit too much.


Thomas

[Springframework-developer] AOP Alliance API changes

[Rod J. <rod...@in...>]

All,

You'll recall that AOP Alliance and AOPI merged a month or so ago. The
result has been some changes to the old AOP Alliance interfaces, which
Spring 0.9 implements.

These changes don't really affect how things work, just package and method
naming.

I've just checked in the necessary changes (and current AOP Alliance jar).

This will break any interceptors you have. However, it's easy to make the
changes. In nearly all cases, it will involve 2 easy steps:

1. imports org.aopalliance.* -> org.aopalliance.intercept.*

2. MethodInvocation.invokeNext() -> proceed(). This is more in line with AOP
terminology, and still intelligible to us J2EE folk.

I was able to migrate my code in projects using Spring AOP in minutes,
including my interceptors. (The changes shouldn't affect you if you haven't
written your own interceptors).

**** NB: Clean before rebuilding your local copy of Spring.

I really like the new AOP Alliance APIs. I think they're very powerful and
quite elegant.

As an added bonus, I've checked in a regular expression pointcut:
com.interface21.aop.framework.RegexpMethodPointcut

Set a Perl5 reg exp (such as ".*set.*") as the "pattern" property and an
interceptor ref as the "interceptor" property and drop the regexp pointcut
name in your interceptor names for your ProxyFactoryBean and you're all set.

This depends on Jakarta ORO. I chose this because Struts uses it and it
seems to work well. If anyone objects strongly to this choice of reg exp
(obviously we can't go to 1.4 yet) please let me know.

I've also recently introduced a distinction between static and dynamic
pointcuts. Static pointcuts depend on the method invoked and perhaps
attributes; dynamic pointcuts also get to see the arguments.

The WildcardAttributeRegistry is a move towards a better attributes
solution, although I'm still keen to pursue source-level attributes. I would
love a volunteer to help drive the attributes side of things as my time is
limited.

Regards,
Rod

Re: [Springframework-developer] Tags using expression language??

[<jue...@we...>]

SnVzdCBmaXhlZCAtIEV4cHJlc3Npb25FdmFsdWF0aW9uVXRpbHMgc3VwcG9ydHMgcGFydGlhbCBl
eHByZXNzaW9ucyBub3chIEFuZCBhcyBJJ3ZlIGFscmVhZHkgaGludGVkIGF0LCB5b3UncmUgd2Vs
Y29tZSB0byBiZWNvbWUgYSBkZXZlbG9wZXIgLSBqdXN0IHRlbGwgbWUgeW91ciBTb3VyY2VGb3Jn
ZSBVbml4IHVzZXJuYW1lLi4uIDotKQ0KIA0KQlRXLCBmZWVsIGZyZWUgdG8gbWFrZSBCaW5kVGFn
IHN1cHBvcnQgbmVzdGVkIHRhZ3MuIFlvdSdyZSBnZW5lcmFsbHkgaW52aXRlZCB0byBleHRlbmQg
dGhlIHRhZyBzdWl0ZSBpZiB5b3UgbGlrZSB0bywgYXMgdGhhdCBpcyBsb3cgb24gbXkgcGVyc29u
YWwgcHJpb3JpdHkgbGlzdC4gUmVnYXJkaW5nIGEgTGlzdENvbnRyb2xsZXI6IFNvdW5kcyBpbnRl
cmVzdGluZywgYnV0IEknZCBzdWdnZXN0IHRvIGRpc2N1c3MgcHJvdG90eXBpY2FsIGNvZGUgYmVm
b3JlIGNvbW1pdHRpbmcgYW55dGhpbmcgdG8gdGhlIG1haW4gc291cmNlIHRyZWUuDQogDQpKdWVy
Z2VuDQogDQogDQoNCgktLS0tLVVyc3Byw7xuZ2xpY2hlIE5hY2hyaWNodC0tLS0tIA0KCVZvbjog
QWxlZiBBcmVuZHNlbiAoSlRlYW0pIFttYWlsdG86YWxlZkBqdGVhbS5ubF0gDQoJR2VzZW5kZXQ6
IE1pIDIzLjA3LjIwMDMgMTg6NTQgDQoJQW46IGrDvHJnZW4gaMO2bGxlciBbd2VyazNBVF07IHNw
cmluZ2ZyYW1ld29yay1kZXZlbG9wZXJAbGlzdHMuc291cmNlZm9yZ2UubmV0IA0KCUNjOiANCglC
ZXRyZWZmOiBSRTogW1NwcmluZ2ZyYW1ld29yay1kZXZlbG9wZXJdIFRhZ3MgdXNpbmcgZXhwcmVz
c2lvbiBsYW5ndWFnZT8/DQoJDQoJDQoNCglIaSBKdWVyZ2VuIChJIHN0aWxsIGNhbid0IGZpbmQg
dGhlIEFMVC1jb2RlIGZvciB1LXVtbGF1dCksDQoJDQoJVGhlcmUncyBhIHNsaWdodCBidWcgaW4g
dGhlIEV4cHJlc3Npb25FdmFsdWF0aW9uVXRpbHMuDQoJRXhwcmVzc2lvbmxhbmd1YWdlIHN1cHBv
cnRzIHBhcnRpYWwgZXhwcmVzc2lvbnMgY29tYmluZWQgd2l0aCBzdHJpbmdzLg0KCVNvbWV0aGlu
ZyBsaWtlIHRoaXM6IDxpMjE6YmluZCBwYXRoPSJBY2NvdW50LiR7aXRlbX0iLz4uLi4NCgkNCglU
aGUgaXNFeHByZXNzaW9uTGFuZ3VhZ2UoKS1tZXRob2Qgc2F5czogJ3ZhbHVlLnN0YXJ0c1dpdGgo
IiR7IiknIHdoaWxlDQoJaXQgc2hvdWxkIHJlYWQgJ3ZhbHVlLmluZGV4T2YoIiR7IikgIT0gLTEn
LiBUaGlzIHdpbGwgZml4IHRoZSB0YWcgaW4NCglvcmRlciB0byBtYWtlIHRoZSBleGFtcGxlIGFi
b3ZlIHdvcmsuLi4NCgkNCglDaGVlcnMsDQoJDQoJQWxlZg0KCQ0KCVAucy4gSW4gb25lIG9mIHlv
dXIgcmVwbGllcywgeW91IHN0YXRlZCB0aGF0IGl0IG1pZ2h0IGJlIGhhbmRpZXIgZm9yIG1lDQoJ
KGFuZCBzb21lIG90aGVyIHBlb3BsZSBJJ20gY29uc3RhbnRseSBib3RoZXJpbmcgOy0pIHRvIGJl
Y29tZSBhDQoJZGV2ZWxvcGVyLiBJIGtpbmQgb2YgYWdyZWUgd2l0aCBhbmQgc2luY2UgSSdtIGN1
cnJlbnRseSBkZXZlbG9waW5nIGtpbmQNCglvZiBhIGxhcmdlIGFwcGxpY2F0aW9uIHVzaW5nIFNw
cmluZywgSSdsbCBwcm9iYWJseSBydW4gaW50byBzb21lIG1vcmUNCgltaW5vciB0aGluZ3MgSSB3
b3VsZCBiZSBhYmxlIHRvIGNvbW1pdCBteXNlbGYgZGlyZWN0bHkuLi4gU28gaWYgbm9ib2R5DQoJ
b2JqZWN0cy4uLg0KCQ0KCQ0KCQ0KDQo=

RE: [Springframework-developer] Tags using expression language??

[Alef A. \(JTeam\) <al...@jt...>]

Hi Juergen (I still can't find the ALT-code for u-umlaut),

There's a slight bug in the ExpressionEvaluationUtils.
Expressionlanguage supports partial expressions combined with strings.
Something like this: <i21:bind path="Account.${item}"/>...

The isExpressionLanguage()-method says: 'value.startsWith("${")' while
it should read 'value.indexOf("${") != -1'. This will fix the tag in
order to make the example above work...

Cheers,

Alef

P.s. In one of your replies, you stated that it might be handier for me
(and some other people I'm constantly bothering ;-) to become a
developer. I kind of agree with and since I'm currently developing kind
of a large application using Spring, I'll probably run into some more
minor things I would be able to commit myself directly... So if nobody
objects...

RE: [Springframework-developer] Summary of pending points

[<jue...@we...>]

Thomas,

You're right, there's an issue with mapRow(ResultSet rs, int rowNum) =
having to be abstract. On the contrary, SimpleFormController has a =
default implementation of its last onSubmit method. So let's scrap that =
merging idea.

Let me refine your proposal a bit. We would need "Map context" on =
MappingSqlQueryWithParameters too, to be able to cascade down to the =
simpler mapRow methods. But why not avoid MappingSqlQueryWithContext in =
the first place and just add "Map context" to =
MappingSqlQueryWithParameters?

MappingSqlQueryWithParameters
 abstract Object mapRow(ResultSet rs, int rowNum, Object[] parameters, =
Map context)

MappingSqlQuery
 abstract Object mapRow(ResultSet rs, int rowNum)

Whoever wants to use the context map will probably not mind the =
parameters even if they are not needed. Of course, existing custom =
subclasses of MappingSqlQueryWithParameters would still need to be =
changed then. But I don't consider that a problem, as I assume that most =
users use MappingSqlQuery anyway, and as migration is straightforward.

Jean-Pierre, if we agree on the above, could you make the introduction =
of the context map and migrate your current application to it? I'd like =
to have an actual usage of this feature before we finalize it. Thomas, =
you're invited to review this stuff, of course!

Juergen

P.S.:
I wonder about finding the time myself every single day ;-) Seriously, =
I've reduced my working time at werk3AT from 40 to 30 hours per week, =
starting with May - to be able to put more effort into Spring =
development, evangelizing, and writing about it.


-----Original Message-----
From: tri...@tr... [mailto:tri...@tr...]
Sent: Wednesday, July 23, 2003 3:50 PM
To: j=FCrgen h=F6ller [werk3AT]
Cc: jp....@ti...; springframework-developer
Subject: Re: [Springframework-developer] Summary of pending points


Juergen, Jean-Pierre,

> I suggest to address the issue by offering overloaded execute and =
mapRow
> methods with a "Map context" parameter (instead of "Object context").
> Additionally, I suggest to offer just one single MappingSqlQuery class =
with 3
> mapRow hooks:
>=20

I think I'm finally starting to see the value in providing a context for =
the
mapping class.  Thanks for not giving up on this Jean-Pierre.

I'm not sure about merging the different classes since there is one =
specific
method in each implementation that is marked as abstract.  This will =
force the
user to implement the needed mapping method.  If you merge them this =
would not
be possible.  I'd vote for adding a new class MappingSqlQueryWithContext =
where
the parameters could be added to the context Map as "parameters".

So we would have:

MappingSqlQueryWithParameters
 abstract Object mapRow(ResultSet rs, int rowNum, Object[] parameters)

MappingSqlQueryWithContext
 abstract Object mapRow(ResultSet rs, int rowNum, Map context)

MappingSqlQuery
 abstract Object mapRow(ResultSet rs, int rowNum)

> As I consider both a context map and a consolidation of all overloaded =
mapRow
> methods into MappingSqlQuery sensible and straightforward changes, I =
suggest
> to implement them promptly. I'm even willing to include this in 0.9.1, =
to
> reflect the merging of MappingSqlQueryWithParameters and =
MappingSqlQuery as
> early as possible.
>=20

I don't think adding this to 0.9.1 would be a problem - it should be =
pretty
straightforward.  Juergen, I don't know where you find the time to do =
all you do
for Spring.  We're lucky to have you on the project.  If you want me to =
make
thiese changes, I should have some time towards the end of this week.

Thomas




-------------------------------------------------------
This SF.net email is sponsored by: VM Ware
With VMware you can run multiple operating systems on a single machine.
WITHOUT REBOOTING! Mix Linux / Windows / Novell virtual machines at the
same time. Free trial click here: http://www.vmware.com/wl/offer/345/0
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

RE: [Springframework-developer] Some proposals for MVC

[Alef A. \(JTeam\) <al...@jt...>]

Hmmm, I missed the whole CRUD thing JP was talking about, so to be
clear: the thing I'm talking about below is some kind of
ListViewController and not a ListFormController

Alef


-----Oorspronkelijk bericht-----
Van: spr...@li...
[mailto:spr...@li...] Namens
Alef Arendsen (JTeam)
Verzonden: Wednesday, July 23, 2003 5:15 PM
Aan: 'springframework-developer'
Onderwerp: [Springframework-developer] Some proposals for MVC


Hi everybody,

I've ran into some issues concerning some of the MVC stuff. Below I'll
discuss those issues. I'd like your opinions about it and see if we can
integrate some (or all) of changes (which are actually quite small).

1) ***** Changes to BindTag to support children tags to reach BindTag's
attributes One of the cool features of JSP is the possibilities to nest
tags and find attributes of parent tags to perform operation relative to
the parent tag. When considering i21:bind, custom tags in the body of
the i21:bind tag could perfectly use the Errors object and the
BindStatus object to perform extra BindStatus specific functionalities
(like localization based on the BindStatus). Giving child-tags of
i21:bind access to Errors and BindStatus would allow for a lot more
generic JSP code, like the following:

<i21:bind path="command.firstName">
    <tr>
        <td><jt:localizeField/></td>  (instead of <jt:localizeField
key="jteam.site.data.Account.firstName"/>
    </tr>
    <tr>
        <td><input type="blabla" value="blabla"></td>
    </tr>
</i21:bind>

Using the newly created EL-based i21:bind version, there's even more
powerful possibilities.

So the change I'm proposing is the following:
A) the adding of a getter for the Errors object in BindTag
B) the adding of a getter for the current property in BindTag (and the
creation of a class-global field to support this)

Modified source is included.

2) ***** Changes to BaseCommandController to allow for the creation of a
ListController We've created a ListController that simply extends the
AbstractController, but this does not really fulfil to our needs (we
need to have PropertyEditors here as well to render appropriate Strings
for for instance a date or a locale). Therefore we need to be able to
extend BaseCommandController which has all the functionality we need and
then be able to replace the target object in the BeanWrapper(Impl) to
support iteration over the List. To support lists we need an
ListDataBinder (extending ServletRequestDataBinder), which would allow
changing the target object in the BeanWrapper (by using the
setWrappedInstance method).

This addition would free the way for the creation of a ListController
that instead of a single command object, would insert a DataBinder for a
List of object. The c:forEach tag can then be used to iterate over the
list AND rendering the properties of the object in the list, using the
PropertyEditors including the the databinder!

Changes: nonfinal method createBinder() in BaseCommandController
protected ServletRequestDataBinder createBinder(HttpServletRequest
request, Object command)
Additions: ListDataBinder (extending ServletRequestDataBinder)
Additions: AbstractListController (overriding handleRequestInternal to
allow for lists to be returned in a DataBinder

I'm currently keeping track of the changes in a local source-distro of
Spring, I'll post some of the results later on, and I might be able to
set up a simple application that shows the behavior...

Maybe you guys already have some opinions about the implementation of
this?

Cheers,

Alef







-------------------------------------------------------
This SF.Net email sponsored by: Free pre-built ASP.NET sites including
Data Reports, E-commerce, Portals, and Forums are available now.
Download today and enter to win an XBOX or Visual Studio .NET.
http://aspnet.click-url.com/go/psa00100006ave/direct;at.asp_061203_01/01
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer

[Springframework-developer] Some proposals for MVC

[Alef A. \(JTeam\) <al...@jt...>]

Hi everybody,

I've ran into some issues concerning some of the MVC stuff. Below I'll
discuss those issues. I'd like your opinions about it and see if we can
integrate some (or all) of changes (which are actually quite small).

1) ***** Changes to BindTag to support children tags to reach BindTag's
attributes
One of the cool features of JSP is the possibilities to nest tags and
find attributes of parent tags to perform operation relative to the
parent tag. When considering i21:bind, custom tags in the body of the
i21:bind tag could perfectly use the Errors object and the BindStatus
object to perform extra BindStatus specific functionalities (like
localization based on the BindStatus). Giving child-tags of i21:bind
access to Errors and BindStatus would allow for a lot more generic JSP
code, like the following:

<i21:bind path="command.firstName">
    <tr>
        <td><jt:localizeField/></td>  (instead of <jt:localizeField
key="jteam.site.data.Account.firstName"/>
    </tr>
    <tr>
        <td><input type="blabla" value="blabla"></td>
    </tr>
</i21:bind>

Using the newly created EL-based i21:bind version, there's even more
powerful possibilities.

So the change I'm proposing is the following:
A) the adding of a getter for the Errors object in BindTag
B) the adding of a getter for the current property in BindTag (and the
creation of a class-global field to support this)

Modified source is included.

2) ***** Changes to BaseCommandController to allow for the creation of a
ListController
We've created a ListController that simply extends the
AbstractController, but this does not really fulfil to our needs (we
need to have PropertyEditors here as well to render appropriate Strings
for for instance a date or a locale). Therefore we need to be able to
extend BaseCommandController which has all the functionality we need and
then be able to replace the target object in the BeanWrapper(Impl) to
support iteration over the List. To support lists we need an
ListDataBinder (extending ServletRequestDataBinder), which would allow
changing the target object in the BeanWrapper (by using the
setWrappedInstance method).

This addition would free the way for the creation of a ListController
that instead of a single command object, would insert a DataBinder for a
List of object. The c:forEach tag can then be used to iterate over the
list AND rendering the properties of the object in the list, using the
PropertyEditors including the the databinder!

Changes: nonfinal method createBinder() in BaseCommandController
protected ServletRequestDataBinder createBinder(HttpServletRequest
request, Object command)
Additions: ListDataBinder (extending ServletRequestDataBinder)
Additions: AbstractListController (overriding handleRequestInternal to
allow for lists to be returned in a DataBinder

I'm currently keeping track of the changes in a local source-distro of
Spring, I'll post some of the results later on, and I might be able to
set up a simple application that shows the behavior...

Maybe you guys already have some opinions about the implementation of
this?

Cheers,

Alef

[Springframework-developer] =?iso-8859-1?Q?Re:_[Springframework-developer]_Summary_of_pending_points?=

[=?iso-8859-1?Q?<jp....@ti...>]

+1 for me,=0D=0A=0D=0AJean-Pierre=0D=0A=0D=0A---------- Initial Header --=
---------=0D=0A=0D=0AFrom      : j=FCrgen h=F6ller [werk3AT] <juergen.hoe=
ll...@we...>=0D=0ATo          : <jp....@ti...>,"springframew=
ork-developer" <spr...@li...>=0D=0ACc =
         : =0D=0ADate      : Wed, 23 Jul 2003 13:15:59 +0200=0D=0ASubject=
 : Re: [Springframework-developer] Summary of pending points=0D=0A=0D=0AJ=
ean-Pierre, Thomas, Rod, everybody,=0D=0A=0D=0AI suggest to address the i=
ssue by offering overloaded execute and mapRow methods with a "Map contex=
t" parameter (instead of "Object context"). Additionally, I suggest to of=
fer just one single MappingSqlQuery class with 3 mapRow hooks:=0D=0A=0D=0A=
- mapRow(ResultSet rs, int rowNum, Map context, Object[] parameters)=0D=0A=
- mapRow(ResultSet rs, int rowNum, Map context)=0D=0A- mapRow(ResultSet r=
s, int rowNum)=0D=0A=0D=0AThe default implementations of the former two c=
ould simply cascade towards the latter. A subclass can choose to override=
 any of those. This mechanism is inspired by our SimpleFormController tha=
t offers similar cascading methods for onSubmit.=0D=0A=0D=0AThis would ef=
fectively mean dissolving MappingSqlQueryWithParameters and merging it wi=
th MappingSqlQuery. As I assume that most people use MappingSqlQuery anyw=
ay, this shouldn't pose a problem. All former MappingSqlQueryWithParamete=
rs subclasses would simply have to extend the merged MappingSqlQuery then=
.=0D=0A=0D=0AAs I consider both a context map and a consolidation of all =
overloaded mapRow methods into MappingSqlQuery sensible and straightforwa=
rd changes, I suggest to implement them promptly. I'm even willing to inc=
lude this in 0.9.1, to reflect the merging of MappingSqlQueryWithParamete=
rs and MappingSqlQuery as early as possible.=0D=0A=0D=0AWhat do you think=
?=0D=0A=0D=0AJuergen=0D=0A=0A=0A********** L'ADSL A 20 EUR/MOIS**********=
=0ATiscali propose l'ADSL le moins cher du march=E9 : 20 EUR/mois et le m=
odem ADSL offert ! =0APour profiter de cette offre exceptionnelle, clique=
z ici : http://register.tiscali.fr/adsl/=0AOffre soumise =E0 conditions.=0A=

Re: [Springframework-developer] Summary of pending points

[<tri...@tr...>]

Juergen, Jean-Pierre,

> I suggest to address the issue by offering overloaded execute and mapRow
> methods with a "Map context" parameter (instead of "Object context").
> Additionally, I suggest to offer just one single MappingSqlQuery class with 3
> mapRow hooks:
> 

I think I'm finally starting to see the value in providing a context for the
mapping class.  Thanks for not giving up on this Jean-Pierre.

I'm not sure about merging the different classes since there is one specific
method in each implementation that is marked as abstract.  This will force the
user to implement the needed mapping method.  If you merge them this would not
be possible.  I'd vote for adding a new class MappingSqlQueryWithContext where
the parameters could be added to the context Map as "parameters".

So we would have:

MappingSqlQueryWithParameters
 abstract Object mapRow(ResultSet rs, int rowNum, Object[] parameters)

MappingSqlQueryWithContext
 abstract Object mapRow(ResultSet rs, int rowNum, Map context)

MappingSqlQuery
 abstract Object mapRow(ResultSet rs, int rowNum)

> As I consider both a context map and a consolidation of all overloaded mapRow
> methods into MappingSqlQuery sensible and straightforward changes, I suggest
> to implement them promptly. I'm even willing to include this in 0.9.1, to
> reflect the merging of MappingSqlQueryWithParameters and MappingSqlQuery as
> early as possible.
> 

I don't think adding this to 0.9.1 would be a problem - it should be pretty
straightforward.  Juergen, I don't know where you find the time to do all you do
for Spring.  We're lucky to have you on the project.  If you want me to make
thiese changes, I should have some time towards the end of this week.

Thomas

Re: [Springframework-developer] Summary of pending points

[<jue...@we...>]

Jean-Pierre, Thomas, Rod, everybody,

I suggest to address the issue by offering overloaded execute and mapRow =
methods with a "Map context" parameter (instead of "Object context"). =
Additionally, I suggest to offer just one single MappingSqlQuery class =
with 3 mapRow hooks:

- mapRow(ResultSet rs, int rowNum, Map context, Object[] parameters)
- mapRow(ResultSet rs, int rowNum, Map context)
- mapRow(ResultSet rs, int rowNum)

The default implementations of the former two could simply cascade =
towards the latter. A subclass can choose to override any of those. This =
mechanism is inspired by our SimpleFormController that offers similar =
cascading methods for onSubmit.

This would effectively mean dissolving MappingSqlQueryWithParameters and =
merging it with MappingSqlQuery. As I assume that most people use =
MappingSqlQuery anyway, this shouldn't pose a problem. All former =
MappingSqlQueryWithParameters subclasses would simply have to extend the =
merged MappingSqlQuery then.

As I consider both a context map and a consolidation of all overloaded =
mapRow methods into MappingSqlQuery sensible and straightforward =
changes, I suggest to implement them promptly. I'm even willing to =
include this in 0.9.1, to reflect the merging of =
MappingSqlQueryWithParameters and MappingSqlQuery as early as possible.

What do you think?

Juergen


-----Original Message-----
From: jp....@ti... [mailto:jp....@ti...]
Sent: Wednesday, July 23, 2003 10:08 AM
To: j=FCrgen h=F6ller [werk3AT]
Cc: springframework-developer
Subject: Re: [Springframework-developer] Summary of pending points


Hi Juergen,

It's the second case. In fact, the locale is or is not used in the =
request itself, depending if the root object uses it directly or not.

The simpliest example is this one. Admitting a user or an address that =
is classicaly not localized in the database. If this record contains a =
Country indication, only the country code will still be stored in the =
database. When mapRow will create the Country object with the code from =
the database, it will need the locale, not of the record, but of the =
user to serve. To allow the view displaying the name of the country =
correctly.

As we said both, the locale cannot be a current execute parameter in =
this case.

The core of rewriting is done. Just the doc is not changed accordingly =
and for the new feature, I have not rewrited convenience methods.=20

I will, when at home, put my current version of the three involved =
classes in the sandbox. So you will be able to see what changes I've =
made and if this way has to be changed.

The changes are completely backward compatible. Currently only one test =
breaks, but its only a lack of a constructor signature.

Note: I have also attached these files in this mail.

Regards,
Jean-Pierre



---------- Initial Header -----------

From      : j=FCrgen h=F6ller [werk3AT] <jue...@we...>
To          : "JP Pawlak" =
<jp....@ti...>,<spr...@li...>
Cc          :=20
Date      : Wed, 23 Jul 2003 09:27:53 +0200
Subject : Re: [Springframework-developer] Summary of pending points

Hi Jean-Pierre,
=20
<quote>
>>> Ad 3) I haven't thought about that in depth, as I'm mainly using
Hibernate these days. But it seems to me that simply using a
MappingSqlQuery instance per request should solve the problem. It's not
really about creating many such instances I guess, as they are pretty
lightweight. Do you have a particular reason for wanting to reuse
MappingSqlQuery instances in this case?

You're right that using a new instance per request solves the problem.

Nevertheless, it's not about a few particular requests, but almost all.
In addition to the class creation, it's also the prepared statement
re-creation and re-compilation. It's possible anyway that the gain is
not so high. But as the job is done for me, I prefer continue to reuse
as so it can only be faster and has no additional risk.
</quote>
=20
OK, I see that there is value in reusing the prepared statements.
=20
What exactly are you doing with the Locale inside the mapRow =
implementation? If you'd use it as an argument for the prepared =
statement too, it could be a parameter of the execute method, but it =
probably won't go into the statement as Locale object but rather as some =
language code. So are you setting the Locale to the mapped object but =
not using it directly for the statement? Then it couldn't be an execute =
parameter, so you'd have to get it there in some other way.
=20
That would require adding a new context parameter of type Object or Map =
to execute, newResultReader, and mapRow. There should be a solution to =
do this as backward compatible as possible, maybe by introducing a super =
class of MappingSqlQueryWithParameters called =
MappingSqlQueryWithParametersAndContext? The two subclasses could still =
offer the same mapRow implementations as before.
=20
Regards,
Juergen


********** L'ADSL A 20 EUR/MOIS**********
Tiscali propose l'ADSL le moins cher du march=E9 : 20 EUR/mois et le =
modem ADSL offert !=20
Pour profiter de cette offre exceptionnelle, cliquez ici : =
http://register.tiscali.fr/adsl/
Offre soumise =E0 conditions.