|
From: Trevor C. <pr...@se...> - 2003-11-21 16:31:31
|
This affects us heavily, but makes total sense (my +1). Once this is committed I'll start migrating/testing our code. Trevor -----Original Message----- From: spr...@li... [mailto:spr...@li...]On Behalf Of j=FCrgen h=F6ller [werk3AT] Sent: November 21, 2003 6:11 AM To: spr...@li... Subject: [Springframework-developer] BaseCommandController: setBeanName -> setCommandName Everybody, In the old tradition of last minute changes before Spring releases ;-), I= 'd like to finally change BaseCommandController's "setBeanName" method to "setCommandName", as it has been bugging me for quite a while that "setBeanName" is too generic and misleading. Now that we have a BeanNameAware interface with the natural method name "setBeanName", BaseCommandController's naming is even more confusing. "setCommandName" would accompany the existing "setCommandClass" method nicely. Of course, setBeanName is a *very* commonly called method in command/form controller initialization. I consider this a reason to change it before 1= .0 final, as we would have to stick with it else. I suggest to keep "setBeanName" as deprecated method for the time being, but clearly recomm= end to switch to "setCommandName". The same applies to our various notions of XML bean references. I'd like = to drop support for the deprecated <ref external=3D".../> as of 1.0 RC1, and suggest to proceed similarly with BaseCommandController's setBeanName. If= we communicate that clearly, we shouldn't cause any migration headaches. Juergen DI J=FCrgen H=F6ller Senior System Architect ______________________________________ werk3ATS - division systementwicklung werk3AT informations- und mediensysteme europaplatz 4 A - 4020 linz t. +43 (0) 732 71 65 29 502 f. +43 (0) 732 71 65 29 3 mailto:jue...@we... http://www.werk3at.com ______________________________________ werk3ATS - WIR ENTWICKELN ERFOLG ------------------------------------------------------- This SF.net email is sponsored by: SF.net Giveback Program. Does SourceForge.net help you be more productive? Does it help you create better code? SHARE THE LOVE, and help us help YOU! Click Here: http://sourceforge.net/donate/ _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer --- Incoming mail is certified Virus Free. Checked by AVG anti-virus system (http://www.grisoft.com). Version: 6.0.537 / Virus Database: 332 - Release Date: 06/11/2003 |