Re: [Springframework-developer] BaseCommandController: setBeanName -> setCommandName

[Colin S. <col...@ex...>]

+1, although this doesn't affect me at all...


jürgen höller [werk3AT] wrote:

>Everybody,
>
>In the old tradition of last minute changes before Spring releases ;-), I'd like to finally change BaseCommandController's "setBeanName" method to "setCommandName", as it has been bugging me for quite a while that "setBeanName" is too generic and misleading. Now that we have a BeanNameAware interface with the natural method name "setBeanName", BaseCommandController's naming is even more confusing. "setCommandName" would accompany the existing "setCommandClass" method nicely.
>
>Of course, setBeanName is a *very* commonly called method in command/form controller initialization. I consider this a reason to change it before 1.0 final, as we would have to stick with it else. I suggest to keep "setBeanName" as deprecated method for the time being, but clearly recommend to switch to "setCommandName".
>
>The same applies to our various notions of XML bean references. I'd like to drop support for the deprecated <ref external=".../> as of 1.0 RC1, and suggest to proceed similarly with BaseCommandController's setBeanName. If we communicate that clearly, we shouldn't cause any migration headaches.
>
>Juergen
>  
>