|
From: Rod J. <rod...@in...> - 2003-11-14 22:54:28
|
All, I've made all the proposed changes (although not committed them) and I'm very happy with how it looks. Ah, the wondering of refactoring tools. 5 years ago I would have spent the best part of a day doing that. And probably not have had comprehensive tests to prove that I was done. One last issue and I promise I'll shut up about AOP... The ProxyConfig interface. I wonder whether it might be nicer and more consistent to rename it Advised. (Now that it holds multiple advisors.) Pros: - More elegant and consistent with core interfaces(?) Cons: - JBoss uses this name too, which may be a bit confusing. (Or may cause them to threaten us with a lawsuit...[joke]). PLEASE feedback if you want to influence that decision. Otherwise I will decide, and I'm feeling about 50/50 about it. I guess no feedback would make me more likely to leave it alone. Regards, Rod |