|
From: Rod J. <rod...@in...> - 2003-11-09 15:16:05
|
Renaud's comments: > Seems ok for me. > I still do not think that AttributeRegistery sould be passed as a parameter. Perhaps we should just leave Attribute access up to pointcut implementations. > I am not sure about the composition of the pointcuts. "and" is a kind of > union of two pointcuts. Why not having an intersection possibility? > In that case. "union" and "inter" would maybe be better names? [RJ] Other operations also could be added. But I agree that "and" is potentially confusing. Perhaps we could have : - "intersection" when both pointcuts must be satisfied (I don't like abbreviations without good reason) - "union" when either pointcut must be satisfied I think moving composition out of the class hierarchy and into static methods will allow us to add arbitrary combinations without modifying the core interfaces. Regards, Rod |