RE: [Springframework-rcp-dev] Re: [Spring-JIRA] Created: (RCP-315) FormGuard does not notice child form errors

[Larry S. <lst...@ny...>]

Geoffrey,

That seems reasonable to me, but last time I went through the issues, I
found that even the ones with ready patches weren't as straight forward as
you'd like.  Sure, the patch addresses the specific issue raised, but often
in a way that may not be generally correct for the whole community.

Anyway, I'm not trying to be negative.  Please take a pass through the issue
list and see if you can come up with a set of "easy win" issues and we'll
look at getting them prioritized, reviewed, and resolved.

Thanks,
Larry.

> -----Original Message-----
> From: spr...@li...
> [mailto:spr...@li...] On Behalf Of
> Geoffrey De Smet
> Sent: Monday, April 10, 2006 5:01 AM
> To: spr...@li...
> Subject: [Springframework-rcp-dev] Re: [Spring-JIRA] Created: (RCP-315)
> FormGuard does not notice child form errors
> 
> This issue, and several other issues, have patches attached which make
> them "easy wins", but they should still be applied by someone who knows
> the corresponding part of spring-richclient (to avoid clutter).
> 
> How about we make a list of all easy wins (issues with well formed
> patches) and start processing them first (= give them priority)?
> If it turns out that such an attached patch still need a bunch of
> adjustments, then I propose commenting it and putting it back into the
> pool to process it later.
> The idea is to process patches that take less then 10 minutes first.
> 
> What do you guys think?
> 
> With kind regards,
> Geoffrey De Smet
> 
> 
> Frank Bowers (JIRA) wrote:
> > FormGuard does not notice child form errors
> > --------------------------------------------
> >
> >          Key: RCP-315
> >          URL:
> http://opensource.atlassian.com/projects/spring/browse/RCP-315
> >      Project: Spring Framework Rich Client Project
> >         Type: Bug
> >
> >   Components: Binding System
> >     Reporter: Frank Bowers
> >  Attachments: RCP-315-FormGuard.patch
> >
> > FormGuard does not notice when child validation errors occur.
> >
> > I have a patch which does the following to address this:
> >
> > 1.  adds a hasErrors() method to FormModel
> > 2.  in AbstractForm.addChildForm adds
> >
> ((ValidatingFormModel)childForm.getFormModel()).getValidationResults().add
> PropertyChangeListener(
> >                 ValidationResultsModel.HAS_ERRORS_PROPERTY, formGuard);
> > 3.  in AbstractFormModel modifies revert() to revert child forms.
> > 4.  in FormGuard.getFormModelState() call formModel.hasErrors() rather
> than formModel.getValidationResults().getHasErrors()
> >
> > Also included is HierarchicalFormGuardTests which precisely defines the
> problem these changes address
> >
> 
> 
> 
> -------------------------------------------------------
> This SF.Net email is sponsored by xPML, a groundbreaking scripting
> language
> that extends applications into web and mobile media. Attend the live
> webcast
> and join the prime developer group breaking into this new coding
> territory!
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
> _______________________________________________
> Springframework-rcp-dev mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-rcp-dev