[Springframework-developer] Plug'nPlay for AbstractApplicationContext & ListableBeanFactory

[roger h. <apo...@sn...>]

Greetings to you all !

I've been lurking about for a fair while, being thoroughly impressed by
Springframework - the conception, the code, this excellent list, Rod's book,
in short the whole shebang - it seems quite a while since I encountered a
project that more than anything, just seems to make me smile ;)  Many
thanks.

Anyway - having spent a wee while trying to work out what's going on in the
code, it's feels like time to start asking a few questions...

First up is the subject line & the method
AbstractApplicationContext.getBeanFactory()

I am wondering if the signature for this method might have been changed
inadvertently ?  Prior to the introduction of support for
BeanFactoryPostProcessor's, the method was returning the ListableBeanFactory
interface, but thereafter it has been ListableBeanFactoryImpl.  As the
latter comes with a final modifier on each of the methods implementing that
interface, the opportunity for Plug'nPlay appears to have gone missing...  &
if I'm not mistaken, a first casualty would be the loss of a JdbcBeanFactory
within an AbstractApplicationContext.  Can someone shed some
light - am I just missing something ?

By the way, on my wanderings I noticed the following typo in
AbstractBeanDefinition.equals()

public boolean equals(Object other) {
    if (!(other instanceof AbstractBeanDefinition))
        return false;
    AbstractBeanDefinition obd = (AbstractBeanDefinition) other;
-        return this.singleton = obd.singleton &&
+        return this.singleton == obd.singleton &&
            this.pvs.changesSince(obd.pvs).getPropertyValues().length == 0;
}

Anyway, I hope to be a little less retiring in the future - as you're
such an inspiring bunch ;)

Roger Holbrook