RE: [Springframework-developer] org.springframework.web.servlet.tags.RequestContextAwareTag

[Alef A. \(JTeam\) <al...@jt...>]

+1

Should not be abstract indeed!

-----Oorspronkelijk bericht-----
Van: spr...@li...
[mailto:spr...@li...] Namens
Trevor Cook
Verzonden: Wednesday, September 24, 2003 10:16 PM
Aan: Spring Developers
Onderwerp: [Springframework-developer]
org.springframework.web.servlet.tags.RequestContextAwareTag


Is there a specific reason that "doStartTagInternal" is abstract.  You
are not required to have a "doStart", so you can place your code in the
"doEnd" method (some of my tags do).  A more reusable solution would be
to have the
following:

	protected int doStartTagInternal() throws Exception {
		return super().doStartTag();
	}

which could still be overridden by subclasses but does not require an
implementation (and will function according to spec without one).

Again, I can commit this unless there are any major objections.

Trevor



-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf _______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer