RE: [Springframework-developer] NPE in JavaMailSender.send

[Kopylenko, D. <dko...@ac...>]

Thanks Christophe. Fixed :-)

Regards,
Dmitriy.

-----Original Message-----
From: Christophe Vanfleteren [mailto:c.v...@pa...] 
Sent: Sunday, September 14, 2003 8:38 PM
To: spr...@li...
Subject: [Springframework-developer] NPE in JavaMailSender.send


Hi,

I discovered a problem with the JavaMailSender class.
When you don't have any CC adresses set, you'll get a NPE while composing
the JavaMail message (the MailCC array is never initialized, and it
shouldn't have to be set explicitly to an empty array if there are no CC's).

This is the fix:

--- JavaMailSender.java	10 Sep 2003 00:14:54 -0000	1.1
+++ JavaMailSender.java	15 Sep 2003 00:32:34 -0000
@@ -47,7 +47,7 @@ public class JavaMailSender implements M
 			message.setText(mailSettings.getMailText());
 			message.setFrom(new
InternetAddress(mailSettings.getMailFrom()));
 			message.addRecipient(Message.RecipientType.TO, new
InternetAddress(mailSettings.getMailTo()));
-			if (mailSettings.getMailCc().length > 0) {
+			if (mailSettings.getMailCc() != null) {
 				for (int i = 0; i <
mailSettings.getMailCc().length; i++)
 
message.addRecipient(Message.RecipientType.CC, new
InternetAddress(mailSettings.getMailCc()[i]));
 			}

-- 
Kind regards,
Christophe Vanfleteren




-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf _______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer