|
From: <jue...@we...> - 2003-07-14 13:46:15
|
I've just checked the size in the jar file: It's just 8 KB there. =
Obviously, there's a lot of air in the class ;-)
Some more statistics: It's by far our largest class file with ~1900 LOC =
in 58 KB (BeanWrapperImpl is next with ~900 LOC in 21 KB), amounting for =
~25% of the uncompressed spring-beans.jar (230 KB in total). That's what =
led me to question its role.
As I personally don't mind new Object() {...}, I probably won't use =
ObjectArrayUtils myself, but I can live with 8 KB in the =
spring-beans.jar file. I just don't particularly like such large helper =
classes... Hopefully noone ever suggests to extend the number of =
signatures to all permutations for 20 arguments ;-)
Juergen
-----Original Message-----
From: Rod Johnson [mailto:rod...@in...]
Sent: Monday, July 14, 2003 12:53 PM
To: j=FCrgen h=F6ller [werk3AT];
spr...@li...
Subject: Re: [Springframework-developer] removing ObjectArrayUtils
I vote to keep it. I think it's a pain to have to write such methods =
(new
Object[] {whatever}). It is unfortunate about the footprint, maybe we =
could
have a distribution without it?
Also it has 100% test coverage, so we know all those methods work.
Regards,
Rod
----- Original Message -----
From: "j=FCrgen h=F6ller [werk3AT]" <jue...@we...>
To: <spr...@li...>
Sent: Monday, July 14, 2003 8:00 AM
Subject: [Springframework-developer] removing ObjectArrayUtils
Does anyone mind if I remove ObjectArrayUtils from com.interface21.util? =
I
don't really like its approach over having dozens of overloaded toArray
methods that take all kinds of arguments and convert them to an Object
array. What's so bad about
new Object[] {"bla", "blabla"}
or
new Object[] {new Integer(1), new Integer(2)}
after all? Is ObjectArrayUtils' syntax really significantly nicer, i.e.
ObjectArrayUtils.toArray("bla", "blabla");
or
ObjectArrayUtils.toArray(1, 2);
Given that it has to overload such an arbitrary number of argument
signatures, I don't consider that worth it. And let's not forget that
ObjectArrayUtils.java has 74 KB (!), the class file still 58 KB. I vote =
for
removing it, any application code that uses it (if any at all) is very =
easy
to convert (see above).
Juergen
DI J=FCrgen H=F6ller
Senior System Architect
______________________________________
werk3ATS - division systementwicklung
part of werk3AT internetmedien oeg
europaplatz 4
A - 4020 linz
t. +43 (0) 732 71 65 29 502
f. +43 (0) 732 71 65 29 3
jue...@we...
www.werk3at.com
______________________________________
werk3ATS - WIR ENTWICKELN ERFOLG
-------------------------------------------------------
This SF.Net email sponsored by: Parasoft
Error proof Web apps, automate testing & more.
Download & eval WebKing and get a free book.
www.parasoft.com/bulletproofapps1
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer
|