[Springframework-developer] Theme issue

[JP P. <jp....@ti...>]

Hi Juergen, everybody,

I tried to test the current theme and locale in a view for avoiding
links to current choices. I encountered these issues and committed
changes.

1) The request attribute containing dots forces to use the brackets
syntax, but we can leave with this.
2) The request attribute is a bit long: <c:when
test="${requestScope['com.interface21.web.servlet.theme.CookieThemeResol
ver.THEME'] == 'xxx'}">
3) The request attribute contains the implementation class name of the
resolver. If we change it in the configuration, the JSP have to be
changed accordingly :-(. For the point 2 and 3, I have changed the
request attribute name to the fixed String 'com.interface21.web.THEME'
defined now in ThemeResolver. I am aware that it breaks the backward
compatibility, but it solves this issue from this point (I think
especially on point 3).
4) When the theme is set, all is ok. But for next views, the current
theme name is no longer available, so the default is returned. I added a
new method 'makeThemeNameAvailable' in the ThemeResolver called by a new
else clause in ThemeChangeInterceptor. So, when an interceptor is used,
the request attribute is always set.

Regards,
Jean-Pierre