Re: [Springframework-developer] incrementers

[<tri...@tr...>]

Ken,

I meant I added it to the constructor - if the incrementorName is part of the
constructor, then columnName is also part of the constructor.  It matches the
constructors of he MySQL version.

Having access to the code would help :-)  Hopefully Sourceforge will resolve
their problems soon.  The CVS web access is accessing an old backup copy of the
repoitory, so you can't use that either.  If you can't get access soon, send me
an email and I can zip up my most recent version and send it to you.

Thomas


> Thomas,
> 
> I haven't been able to look at your changes due to the problems at 
> Sourceforge. Apparently anonymous access hasn't been working for several 
> days now.
> 
> I'm suprised you said you added columnName to the HSQL incrementer as I 
> added it to AbstractDataFieldMaxValueIncrementer as you had previously 
> suggested. If it's now duplicated, it should be removed.
> 
> Thanks for testing the Oracle version.
> 
> Ken
> 
> 
> tri...@tr... wrote:
> 
> >Ken,
> >
> >  
> >
> >>I have attached the changed files. Essentially, it is a refactoring to 
> >>move duplicate functionality to AbstractDataFieldMaxValueIncrementer. 
> >>The one change most affecting existing code is that tableName and 
> >>sequenceName are now known as incrementerName. Other 
> >>fields/getters/setters that have been moved to or created in 
> >>AbstractDataFieldMaxValueIncrementer are : dataSource, columnName, 
> >>cacheSize, and dirty. The subclasses now call new constructors in the 
> >>base class. AbstractDataFieldMaxValueIncrementer now implements 
> >>InitializingBean testing only for the dataSource property to be set. 
> >>This allows a prototype incrementer bean to be specified in the 
> >>ApplicationContext that can be used  for in-code construction of the 
> >>individual incrementers needed for each table.
> >>    
> >>
> >
> >I have committed your changes.  Thanks for cleaning up the code - it will
> help
> >when we implement incrementers for other databases.  I added columnName to
> the
> >HSQL incrementer so it would match the MySQL one, and also so we can clean
> up
> >the sequence table once we are done retrieving values.   The
> >RdbmsMaxValueIncrementer is now gone.  And so are the
> ManualExtractionSqlQuery
> >classes. They were still beeing used by SqlFunction, so I changed it to use
> the
> >new MappingSqlQuery.
> >
> >I also tested the Oracle version -- no problems to report.
> >
> >Thomas
> >
> >
> >  
> >
> 
>