|
From: JP P. <jp....@ti...> - 2003-06-17 09:04:48
|
Hi Rod, Juergen, Following the last Rod's proposal, I have committed a third version. It's effectively cleaner and more powerful to create an intermediate UI level. Current state: APPLICATION: Only adding the protected afterRefresh method. UI: ThemeSource NestingThemeSource UI-SUPPORT: ConcreteThemeSource AbstractXmlUiApplicationContext StaticUiApplicationContext The two lasts classes add theme capabilities on their respective ancestror. WEB: DispatcherServlet handles the ThemeResolver The ThemeResolver interface has moved in web.servlet.theme and joined its implementations. XmlWebApplicationContext and StaticWebApplicationContext are as original but extending the UI level classes instead of Application level. The core handling of the themes is now in the UI packages, except the Theme resolving which is web specific. A theme resolving scheme will to be added later for Swing and AWT applications. Jean-Pierre -----Message d'origine----- De=A0: Rod Johnson [mailto:rod...@in...]=20 Envoy=E9=A0: lundi 16 juin 2003 22:58 =C0=A0: JP Pawlak; 'j=FCrgen h=F6ller [werk3AT]'; spr...@li... Objet=A0: Re: [Springframework-developer] themes I have committed in the theme branch a new version having no more modification outer the web package. This is true with an exception: the refresh method from AbstractApplicationContext calls a protected afterRefresh method which by default does nothing. [RJ] Sounds promising The most war straightforward. Only the ThemeSource could not be directly generically implemented. To avoid the core code, I created a ConcreteThemeSource. The WebApplicationContext classes include a such object and are delegating to him for the theme related requests. They redefine also the new method afterRefresh to include the theme refresh. [RJ] It's almost like we need a new UIApplicationContext. A standalone Swing or SWT app might also want themes, would want all generic app context stuff, but wouldn't want the web app context stuff. ApplicationContext -> UIApplicationContext -> WebApplicationContext In the Struts galaxy, Struts-layout implements themes, but the whole library becomes quickly a nightmare as it uses extensively HTML generation by JSP Tags and blocks in a poor Html/Css technology. JBoss has also themes in his Nukes implementation. But here also bunches of HTML are hard-coded. [RJ] I think themes are a very promising area for Spring. I spend all day in messaging middleware (although I have a little web consulting coming up), but sure could have used this when I was at FT.com. Juergen, can you decide on whether this makes 0.9? I think it's definitely good for 1.0, but I don't want to delay 0.9 and it's basically a backward-compatible enhancement. Regards, Rod |