Menu
▾
▴
RE: [Springframework-developer] themes
|
From: <jue...@we...> - 2003-06-16 18:44:03
|
Hi JP, Rod, I've just reviewed the changes in the theme branch. I do consider themes = a useful addition, AFAIK no other web framework does support that = currently. Thanks for the idea and the prototype, JP! Unfortunately, I'm not too happy with the current implementation. It's a = bit too intrusive for my taste. For example, I'm not sure if the generic = non-web ApplicationContext should know about ThemeSources at all. We = should probably move themes support into the web package, abandoning the = tight coupling to the ApplicationContext (and its nesting). At the = moment, I'm just not sure how to integrate the ThemeSource there. I'm gonna think about the issue till tomorrow, maybe I'll make up my = mind :-) I'd appreciate any ideas on less intrusive modelling = alternatives... Whether we'll include in our upcoming release is mainly a matter of = timing: What's our deadline? 26.6., one day before the TheServerSide = Symposium? ;-) If possible, I don't want to force JP to keep his locally = modified state unnecessarily long, so I'm keen on a prompt solution. Regards, Juergen -----Original Message----- From: Rod Johnson [mailto:rod...@in...] Sent: Saturday, June 14, 2003 12:14 PM To: JP Pawlak; spr...@li... Subject: Re: [Springframework-developer] themes JP, This sounds like it could be useful. I don't have time to look at the = code changes in detail right now. Juergen, what do you think? I do think that this change is probably best left till after the 0.8 (or 0.9?) release. As it appears to be backward compatible, we can add it = later. However, if Juergen thinks it's worth including in our imminent release, = I'm open to that. I've just checked out your pagedlist demo (through the GUI and the = code). Very impressive: a good demo for Spring! Regards, Rod ----- Original Message ----- From: "JP Pawlak" <jp....@ti...> To: <spr...@li...> Sent: Saturday, June 14, 2003 2:47 AM Subject: [Springframework-developer] themes > Hi Everybody, > > As I have the need for using themes, I made the job. > But I don't know about your feeling on this. As many central files had > to be touched, despite of the fact than no test was broken and a = "real" > test run well, I committed it in a new branch "theme" for now. > > The javadoc and the test suite are to be made. I'm waiting on = reactions > to know if I can make the change in the main repository and finish the > doc and testsuite. > > For users that will not handle themes nothing new is required in the > configuration. This implementation is mainly a map (themes) of new > messages sources and the user is able to choose the theme to use for > display. Changing the theme is close to the locale handling and using = a > theme is close to the message source handling, but depending on the > chose theme. Accessing to the themes messages is done via a new tag > "theme" which runs like the "message" tag. For be able to change = theme, > only a ThemeResolver bean (provided) has to be added (cookies or > session). > > What is preferably to put in theme's resources instead of the standard > message source? > Obviously, stylesheets and images paths which can vary both on locale > and on theme. > > I have changed the pagedlist demo to demonstrate also the theme > handling. > As I have some trouble to access on logged ftp at the official site, = the > demo is visible at http://tech.jppawlak.info/spring/samples/pagedlist/ > The war file (renamed as zip) with sources is available at > > The modified spring library is on the repository under "theme" branch. > > The user can toggle between "theme" and "metal" themes. > Note: a little bug with JSTL handling makes some links don't work as > long as the session-id is added on the url. For testing, the best is = to > change locale first. > I will fix this starting next week. > > For each theme, the css file is defined in the no-localized file and = the > images in localized since they depend on locale. > > The modified and added (with +) files are: > context/ApplicationContext > + context/NestingThemeSource > + context/ThemeSource > context/support/AbstractApplicationContext > + context/support/ResourceBundleThemeSource > web/servlet/DispatcherServlet > + web/servlet/ThemeResolver > web/servlet/support/RequestContextUtils > + web/servlet/theme/CookieThemeResolver > + web/servlet/theme/FixedThemeResolver > + web/servlet/theme/SessionThemeResolver > web/tags/i21.tld > web/tags/TagInWebApplicationContext > + web/tags/ThemeTag > > Regards, > Jean-Pierre > > > > > ------------------------------------------------------- > This SF.NET email is sponsored by: eBay > Great deals on office technology -- on eBay now! Click here: > http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5 > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer ------------------------------------------------------- This SF.NET email is sponsored by: eBay Great deals on office technology -- on eBay now! Click here: http://adfarm.mediaplex.com/ad/ck/711-11697-6916-5 _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer |
