[Springframework-developer] Re: Petclinic demo app prototype

[Isabelle M. <isa...@me...>]

Hi Juergen,

I haven't come across Log4JServlet yet, will have a look at it today. Will incorporate your other suggestions as well.

Isabelle

On Thu, May 15, 2003 at 11:33:13PM +0200, jürgen höller [werk3AT] wrote:
> Ken, Isabelle,
>  
> First of all, thanks for your efforts - they're very welcome :-)
>  
> Some quick remarks after a brief look at the code (and also the web tutorial):
>  
> - You don't need to specify the contextClass param for ContextLoaderServlet, as XmlWebApplicationContext is the default.
>  
> - Let's omit the debug param declaration for ControllerServlet, it's rather confusing.
>  
> - UrlHandlerMapping aren't sorted by bean name anymore but can specify an "order" value, so let's use a nicer name than "a.urlMap".
>  
> - We should show Log4J web configuration too, i.e. starting Log4jConfigServlet with a lower startup number than ContextLoaderServlet, and using some webAppRootKey like "petclinic.root" in log4j.properties (see Log4jConfigServlet).
>  
> - Separating the DataSource configuration as separate bean is fine, but are you aware that MysqlConnectionPoolDataSource is just a pool-supporting DataSource that doesn't pool itself (like with any JDBC driver)? Let's use a correctly pooling container datasource, configured in Spring as JndiDataSourceBean with name "jdbc/petdb" or the like. Of course, a non-pooling DataSource can be used in a test or standalone environment without drawbacks.
>  
> I'm also keen on both transaction support and Hibernate support in a higher-end version of the demo.
>  
> Regards,
> Juergen
>  
>  
> 
> 	-----Ursprüngliche Nachricht----- 
> 	Von: Rod Johnson [mailto:rod...@in...] 
> 	Gesendet: Do 15.05.2003 10:38 
> 	An: Ken Krebs; Isabelle Muszynski; jürgen höller [werk3AT] 
> 	Cc: 'spring-dev-list' 
> 	Betreff: Re: Petclinic demo app prototype
> 	
> 	
> 
> 	Thanks Ken. This looks like a nice example. The fact that the code is so
> 	simple tends to show that Spring does what it claims!
> 	
> 	It would be good to use the JdbcTemplate at least once for a query / update.
> 	This is an important part of the API.
> 	
> 	"Stage D & later" - ???, suggestions wanted; JNDI, internationalization
> 	support, support for reference data in AbstractFormController,
> 	AbstractWizardFormController, simple transactions, non-JSP views,
> 	authentication/authorization, fancier display pages possibly with a
> 	header/footer/menu and maybe a stylesheet, etc.
> 	
> 	Transaction support: we'd need to come up with a requirement,  and show the
> 	TransactionTemplate and the AOP declarative approach. I have an example of
> 	the declarative approach, which I'll send when I'm accessing the net over
> 	something faster than my mobile phone.
> 	
> 	A Hibernate version of the present demo might be interesting to do later, as
> 	well, showing the new Hibernate integration.
> 	
> 	Regards,
> 	Rod
> 	
> 	
> 	
> 	----- Original Message -----
> 	From: "Ken Krebs" <kk...@kk...>
> 	To: "Isabelle Muszynski" <isa...@me...>; "jürgen höller
> 	[werk3AT]" <jue...@we...>; "Rod Johnson"
> 	<rod...@in...>
> 	Cc: "'spring-dev-list'" <spr...@li...>
> 	Sent: Thursday, May 15, 2003 3:29 AM
> 	Subject: Petclinic demo app prototype
> 	
> 	
> 	> To All,
> 	>
> 	> I am pleased to announce that I now have ready for download a PROTOTYPE
> 	> of the Petclinic demo app
> 	> <http://www.globaldialog.com/%7Ekkrebs/files/Petclinic1.zip>, approx.
> 	> 1.25MB.
> 	>
> 	> Be sure to read the file, petclinic.txt. This file contains my notes
> 	> about the design and implementation and also raises key issues that need
> 	> to be resolved.
> 	>
> 	> I very much welcome all comments, suggestions, ideas, and criticisms. I
> 	> look forward to hearing from you.
> 	>
> 	> Ken
> 	>
> 	
> 	
> 	
> 

-- 
Isabelle Muszynski
Software Engineer
Zandweellaan 4
2660 Antwerpen
Belgium
Tel. 32-(0)3-830 18 54
Mobile: 32-(0)485 49 50 89
Email: isa...@me...
Website: www.meta-logix.com