|
From: Roy W. <roy...@gm...> - 2006-08-02 20:39:42
|
I was looking at the AbstractUrlViewController while experimenting with "Pretty URL's" and noticed something that I thought was odd. This class defines a private UrlPathHelper class variable, and exposes two methods for setting properties on the UrlPathHelper. However the UrlPathHelper is not exposed to any subclasses, the variable is private and there is no getter method for it. Nor does the UrlPathHelper get used any way that is visible to a Subclass. It has one method called on it, this.urlPathHelper.getLookupPathForRequest(request); whose value is then sent to the debug log. I looks like at one point the intention was to pass the value of that method call on to the subclass via the protected abstract method getViewNameForRequest, but instead the request object is passed along. Roy Wells |