|
From: Colin S. <col...@ex...> - 2006-07-12 14:45:35
|
I don't think this will affect many people at all, as it's quite rare for people to use TransactionProxyFactoryBean programmatically. You could almost break things down into backwards compatibility for the declarative use (very very common) vs. programmatic use. I definitely like the use of Class[] more, it's cleaner. However if we are really concerned about even programmatic backwards compatibility, then one consideration is that in 2.0 people won't even be using TransactionProxyFactoryBean very much (preferring the new XML dialect), so it's not like the "benefit" of the Class[] signature is getting to many people. Of course, the 2.0 class could support both signatures, but the in that case for the declarative use the String[] will always be picked for the declarative case as it's a one-to-one mapping. Colin On 7/12/2006 10:15 AM, Matt Sgarlata wrote: > My 2 cents is that an IDE will point this out to you and the change will > take all of 2 minutes to code. > > It would be a bigger deal IMO if you had to change your context > definitions, because in that case the error might not be found for a > while (for example, if the bean was lazily initialized). However, > Spring's use of PropertyEditors means the change should be transparent > in terms of XML application context definitions. > > Matt > > Rob Harrop wrote: > >> All, >> >> I would like your input on this JIRA issue. Do you think this is valid >> breakage of backward-compatibility or would you like to see the change >> backed out? >> >> http://opensource.atlassian.com/projects/spring/browse/SPR-2277 >> >> Rob >> >> >> ------------------------------------------------------------------------ >> >> >> ------------------------------------------------------------------------- >> Using Tomcat but need to do more? Need to support web services, security? >> Get stuff done quickly with pre-integrated technology to make your job easier >> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo >> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 >> >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> Springframework-developer mailing list >> Spr...@li... >> https://lists.sourceforge.net/lists/listinfo/springframework-developer >> > > > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > |