|
From: Juergen H. <ju...@in...> - 2006-01-17 17:48:40
|
FYI, I've finally committed this change to CVS HEAD.
Juergen
-----Original Message-----
From: spr...@li...
[mailto:spr...@li...] On Behalf Of
Juergen Hoeller
Sent: Tuesday, January 17, 2006 1:01 PM
To: spr...@li...
Subject: Re: [Springframework-developer] Assumption about stack trace format
and cacao
I've just refined Jdk13ControlFactory to take this into account.
This should still be pretty efficient, since it does indexOf with start
indexes now, iterating over the stacktrace to find a match without
subsequent parenthesis - then checking the character right after the method
name whether it's a parenthesis or whitespace, either returning "found" or
increasing the index accordingly for the next iteration.
Juergen
-----Original Message-----
From: spr...@li...
[mailto:spr...@li...] On Behalf Of
Olivier Jolly
Sent: Tuesday, January 17, 2006 10:39 AM
To: spr...@li...
Subject: Re: [Springframework-developer] Assumption about stack trace format
and cacao
> Interesting issue. So for a simple fix, would this mean that we should
> also check for:
>
> this.stackTrace.indexOf(clazz.getName() + "." + methodName + " (")
> != -1
>
> With an extra space before the parenthesis?
Yes, exactly, that should do the trick nicely. I can confirm this later when
I'm home.
But, for performance issues, shouldn't it be better know which exact pattern
we're looking for ? If I understand right, the jdk13 way of doing is already
quite slow, it may hurt to make the situation worse ..
> Juergen
Olivier
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer
-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems? Stop! Download the new AJAX search engine that makes
searching your log files as easy as surfing the web. DOWNLOAD SPLUNK!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=103432&bid=230486&dat=121642
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer
|