Re: [Springframework-developer] UrlFilenameViewController not working in 1.2.6 Nightly

[Rob H. <rob...@in...>]

I'll look at this tonight - if I can't find a suitable fix I'll roll back.

Colin Sampaleanu wrote:

> Matt Raible wrote:
>
>> A few minutes ago, I tried to upgrade AppFuse from 1.2.5 to 1.2.6
>> Nightly.  For some reason, any URLs that I have mapped to my
>> UrlFilenameViewController results in a 404.  If I revert back to
>> spring.jar from 1.2.5, everything works fine.
>>
>> Any ideas?
>>
> This is undoubtedly related to the fix for SPR-1361:
>   http://opensource2.atlassian.com/projects/spring/browse/SPR-1361
>
> The old code was
>        int begin = uri.lastIndexOf('/');
>        if (begin == -1) {
>            begin = 0;
>        }
>        else {
>            begin++;
>        }
> the new code is:
>        int begin = (uri.startsWith("/") ? 1 : 0);
>
> This is not right, since the URI comes from request.getRequestURI() 
> which will include the entire request URI past the protocol level.
>
> I have reopened SPR-1361.
>
> It is not clear there is actually a good fix to SPR-1361, to the 
> extent that the controller itself has no real clue how an incoming 
> path was mapped to it. It's the handler mapping that decides that. So 
> it can not know how much of the path to strip off.
>
> Colin
>
>
>
>
>
>
>
>
>
> -------------------------------------------------------
> SF.Net email is sponsored by:
> Tame your development challenges with Apache's Geronimo App Server. 
> Download
> it for free - -and be entered to win a 42" plasma tv or your very own
> Sony(tm)PSP.  Click here to play: http://sourceforge.net/geronimo.php
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>

-- 
Rob Harrop
Principal Consultant
Interface21 - Spring Services from the Source
http://www.springframework.com