|
From: katentim <kat...@ho...> - 2005-05-09 11:48:25
|
Hi Keith,
Actually I was after something a bit less extensive - even the Spring
samples don't cater for those who've download Spring without
dependencies in this way (I think making this download a pre-requisite
for a pre-release is reasonable).
Keith Donald wrote:
> Katentim,
>
> I simplified the build.properties template in samples/webflow tonite. I
> basically threw out all attempts at assuming users would have their
> paths to jar dependencies setup exactly like the
> spring-with-dependencies download, in favor of requiring explicit
> specification of such jars on a file-by-file basis. It is indeed much
> simpler this way, what I was doing was a nice shot, but it was confusing
> I agree.
I think the confusion is in the settings below. All I really only wanted
was something like:
# location where development tools reside (e.g apps, libs, templates, etc.)
devtools.dir=c:/development/devtools
# location where development lib dependencies reside
devtools.lib.dir=${devtools.dir}/lib
# location of spring.jar
spring.dir=${devtools.lib.dir}/spring
changed to:
# location of spring root directory
devtools.dir=c:/java/spring-framework-1.2-rc2
# location where spring lib dependencies reside
devtools.lib.dir=${devtools.dir}/lib
# location of spring.jar
spring.dir=${devtools.dir}/dist
It isn't intuitive where 'devtools.dir' should point (without comments
or a better sample), and 'spring.dir=${devtools.lib.dir}/spring' will
usually need changing to 'spring.dir=${devtools.lib.dir}/dist'. What do
you think?
>
> Anyway, let me know what you think of this:
>
> # points to ant 1.6 build system for building samples
> builds.dir=../../../builds
>
> ############################################################
> # User-definable build properties neccessary to build samples.
> # Ensure the approrpiate properties are set correctly for your environment.
> #
> # For a list of default properties, see the file:
> # ../../../builds/build.properties
> #
> # Note: you need to specify entries in this file for each required
> dependency for the
> # sample you are building.
> #
> # For example, for Phonebook, you might set the following:
> #
> commons.logging.jar=c:/mydevdir/lib/jakarta-commons/commons-logging-1.0.jar
> # jakarta.taglibs.jar=c:/mydevdir/lib/j2ee/jakarta-taglibs-1.1.jar
> # log4j.jar=c:/mydevdir/lib/log4j/log4j-1.2.9.jar
> # jstl.jar=c:/mydevdir/lib/jstl/jstl-1.1.jar
> # spring.jar=c:/mydevdir/lib/spring/spring-1.2.jar
> #
> # For the complete listing of the dependencies each sample app requires,
> see below or
> # the 'build.webapp.libs' target in that sample's build.xml file.
> ############################################################
>
> # Common dependencies to all samples - uncomment and specify the path
> for each dependency.
> #commons.logging.jar=
> #jakarta.taglibs.jar=
> #jstl.jar=
> #log4j.jar=
> #spring.jar=
>
> # Dependencies for the 'fileupload' sample - uncomment and specify if
> building
> #commons.fileupload.jar=
>
> # Dependencies for the 'birthdate' sample - uncomment and specify if
> building
> #commons.beanutils.jar=
> #commons.collections.jar=
> #commons.digester.jar=
> #commons.validator.jar=
> #jakarta.oro.jar=
> #struts.jar=
>
> # Dependencies for the 'sellitem' sample - uncomment and specify if
> building
> #commons.codec.jar=
> #ognl.jar=
>
> # location of spring webflow jars (boilerplate)
> spring.webflow.jar=../../../dist/spring-webflow.jar
> spring.webflow.support.jar=../../../dist/spring-webflow-support.jar
>
> # location of tomcat - uncomment and specify for automated sample app
> deployment
> #tomcat.dir=
>
> Thanks,
> Keith
>
> ----- Original Message ----- From: "Keith Donald" <ke...@in...>
> To: <spr...@li...>
> Sent: Thursday, May 05, 2005 11:02 PM
> Subject: Re: [Springframework-developer] Re: Building WebFlow samples
>
>
> Well, as stated, if building from CVS none of that 'tweaking' is required.
>
> Such teaking of properties is only neccessary if people are attempting to
> build the samples direct from an expanded spring-webflow preview release
> archive. In that case, since we don't ship any dependencies with the
> webflow releases, you have to be able to point to a valid spring.jar, and
> valid locations to the other jars as well...
>
> In general, I've tried to make it as simple as possible here, where the
> build system assumes, by default, the users stores all their jars
> consistently under a devtools.lib.dir, so they don't have to manually
> specify the location of each dependent .jar.
>
> I'll see what I can do to make this more explicit, as our goal here is to
> make it as easy as possible to build the samples.
>
> Keith
>
>> It's step 3, "tweak the copied 'build.properties'" that isn't straight
>> forward (it's important to get people up and running ASAP). The entry:
>>
>> # location where development tools reside (e.g apps, libs, templates,
>> etc.)
>> devtools.dir=c:/development/devtools
>>
>> ...leaves you scratching your head and reading through the build files
>> to see where they should point to. While we should leave the property
>> names as is (unless you do a complete refactor), how about some better
>> default values and descriptions. E.g.
>>
>> # location of spring root directory
>> devtools.dir=c:/java/spring-framework-1.2-rc2
>>
>> # location where spring lib dependencies reside
>> devtools.lib.dir=${devtools.dir}/lib
>>
>> # location of spring.jar
>> spring.dir=${devtools.dir}/dist
>>
>> ... or am I on the wrong track? I'd presume everyone would organise
>> their java library directories differently, so a reference to a spring
>> root directory is the essential property (again maybe a refactor of
>> property names is required). What do you think?
>>
>> Finally, you could just combine all the Ant commands required to:
>> 1. build alljars webflow.jar webflow.support.jar
>>
>> ...which is still quite readable, and less steps.
>>
>> PS. My problem below was missing the webflow.support.jar. Thanks for the
>> help.
>>
>> Keith Donald wrote:
>>
>>> I updated the readme.txt instructions. Please let me know if these
>>> could
>>> still be improved.
>>>
>>> /*
>>> * webflow-samples
>>> *
>>> * phonebook - central sample demonstrating most webflow features
>>> * itemlist - demonstrates application transaction tokens and expired
>>> flow
>>> cleanup
>>> * fileupload - demonstrates multipart file upload with webflow
>>> * birthdate - demonstrates Struts integration and the MultiAction
>>> * sellitem - demonstrates a wizard with conditional transitions and
>>> continuations
>>> *
>>> * @author Keith Donald
>>> * @since Mar 2005
>>> * @version $Id: readme.txt,v 1.2 2005/04/11 06:19:53 kdonald Exp $
>>> */
>>>
>>> HOW TO BUILD WEBFLOW SAMPLES - FROM RELEASED DISTRIBUTION
>>>
>>> 1. copy in the template 'build.properties' file in the same directory as
>>> this file to the root directory of the sample you wish to run.
>>>
>>> 2. cd to the root directory of the sample you wish to run.
>>>
>>> 3. tweak the copied 'build.properties' to your environment
>>>
>>> 4. tweak 'build.bat' to point your environemnt so the ant build system
>>> can
>>> execute.
>>>
>>> 5. run 'build dist' to build the application .war file, ready for
>>> deployment.
>>>
>>> 6. if tomcat is installed on your system, run 'build
>>> tomcat.server.start' to
>>> start it and deploy the
>>> sample application in one step.
>>>
>>> 7. access the sample at the appropriate URL, e.g
>>> http://localhost:8080/phonebook
>>>
>>> HOW TO BUILD WEBFLOW SAMPLES - FROM CVS
>>>
>>> From the spring root directory, execute from the command line:
>>>
>>> 1. build alljars
>>>
>>> 2. build webflow.jar
>>>
>>> 3. build webflow.support.jar
>>>
>>> 4. Proceed with the RELEASED DISTRIBUTION instructions above,
>>> customizing
>>> your local build.properties for each sample as necessary. Note: If all
>>> want
>>> to do is build the sample .war file for manual deployment, you shouldn't
>>> have to do any build.properties customization--the default properties
>>> will
>>> suffice. Property customization is only necessary if you have custom
>>> paths
>>> to dependent jar files or wish to automate deployment with a local
>>> tomcat
>>> installation.
>>>
>>> -----Original Message-----
>>> From: spr...@li...
>>> [mailto:spr...@li...] On Behalf
>>> Of
>>> kat...@ho...
>>> Sent: Thursday, May 05, 2005 1:04 AM
>>> To: spr...@li...
>>> Subject: [Springframework-developer] Building WebFlow samples
>>>
>>> I was building the phonebook sample and found it wouldn't compile as the
>>> sandbox classes were missing. How is everyone else obtaining/generating
>>> the samples?
>>>
>>> I added a patch (see below) which fixes the problem - but there may be
>>> another approach. What are other doing? :)
>>>
>>> If there is a better way, maybe we can improve the build instructions in
>>> the distro.
>>>
>>> Cheers.
>>>
>>>
>>> Compiling 9 source files to
>>> C:\work\spring\samples\webflow\phonebook\target\classes
>>> C:\work\spring\samples\webflow\phonebook\src\org\springframework\samples\pho
>>>
>>> nebook\web\flow\PersonDetailFlowBuilder.java:18:
>>> package org.springframework.binding.convert does not exist
>>> import org.springframework.binding.convert.ConversionExecutor;
>>>
>>>
>>> ===================================================================
>>> RCS file: /cvsroot/springframework/spring/builds/build.xml,v
>>> retrieving revision 1.2
>>> diff -u -r1.2 build.xml
>>> --- build.xml 27 Apr 2005 00:14:44 -0000 1.2
>>> +++ build.xml 5 May 2005 04:44:26 -0000
>>> @@ -15,6 +15,7 @@
>>> <pathelement location="${target.classes.dir}" />
>>> <pathelement location="${commons.logging.jar}" />
>>> <pathelement location="${spring.jar}" />
>>> + <pathelement location="${spring.sandbox.jar}" />
>>> <pathelement location="${spring.mock.jar}" />
>>> </path>
>>>
>>>
>>>
>>> -------------------------------------------------------
>>> This SF.Net email is sponsored by: NEC IT Guy Games.
>>> Get your fingers limbered up and give it your best shot. 4 great events,
>>> 4
>>> opportunities to win big! Highest score wins.NEC IT Guy Games. Play to
>>> win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20
>>> _______________________________________________
>>> Springframework-developer mailing list
>>> Spr...@li...
>>> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>>>
>>>
>>>
>>> -------------------------------------------------------
>>> This SF.Net email is sponsored by: NEC IT Guy Games.
>>> Get your fingers limbered up and give it your best shot. 4 great events,
>>> 4
>>> opportunities to win big! Highest score wins.NEC IT Guy Games. Play to
>>> win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20
>>
>>
>>
>>
>> -------------------------------------------------------
>> This SF.Net email is sponsored by: NEC IT Guy Games.
>> Get your fingers limbered up and give it your best shot. 4 great
>> events, 4
>> opportunities to win big! Highest score wins.NEC IT Guy Games. Play to
>> win an NEC 61 plasma display. Visit http://www.necitguy.com/?r=20
>> _______________________________________________
>> Springframework-developer mailing list
>> Spr...@li...
>> https://lists.sourceforge.net/lists/listinfo/springframework-developer
>>
>
>
|