|
From: Alef A. <al...@jt...> - 2005-03-31 21:49:26
|
Ok, got it! I'll add the 1.4 building as a separate build then (as I said before,=20 can't do it in one run because of cruisecontrol limitations). rgds, alef On Mar 31, 2005, at 7:30 PM, Juergen Hoeller wrote: > AFAIK, when building on JDK 1.5, you're always compiling agains the=20 > 1.5 version of the standard libraries. We would get most value out of=20= > an auto-build on 1.4 that actually compiles against the 1.4 libraries,=20= > to make sure that we didn't accentally use 1.5-only methods somewhere. > =A0 > I do compile on 1.4 before each release anyway, to check that=20 > everything relevant still compiles there. Having this in the=20 > auto-builds would allow us to catch any issues earlier, though. > =A0 > Juergen > =A0 > =A0 > -----Original Message----- > From: spr...@li...=20 > [mailto:spr...@li...]On=20 > Behalf Of Alef Arendsen > Sent: Thursday, March 31, 2005 12:03 AM > To: spr...@li...;=20 > spr...@li... > Subject: RE: [Springframework-developer] Changes to build.xml to run=20= > autobuilds build on 1.5 as well > > > You're right, but I'll be adding support for running the unit tests on=20= > 1.4 as well... I was first thinking about adding a simple master build=20= > script that executes the two builds (1.4 and 1.5) but the problem here=20= > is that the 'ant' task does not support forking of a new JVM and doing=20= > an 'exec' is not an option, since I want to preserve the log files.=20 > JUnit does support the fork (we're already doing it) and you can also=20= > specify a JVM to use. > > About building (compiling), I thought the behavior when building on=20 > 1.5 in combination with adding the compatibility flag would be the=20 > same as with building on 1.4, wouldn't it? > > Alef > > > -----Original Message----- > From: spr...@li... on behalf=20= > of Juergen Hoeller > Sent: Wed 3/30/2005 8:15 PM > To: spr...@li... > Subject: Re: [Springframework-developer] Changes to build.xml to run=20= > autobuilds build on 1.5 as well > > Well, I don't object to such a property in general. But such a=20 > property only > makes sense if you intend to build the 1.4 version on JDK 1.5: I don't=20= > think > there's much point in that; building the 1.5 version only would be > sufficient then. > > The capability of our build script to build on 1.4 is really just=20 > meant as a > fallback for users that want to do custom builds on their 1.4 JDK. The=20= > only > value we could add to the auto-builds is to check that building the = 1.4 > version actually works *on JDK 1.4*, which we can't check by building=20= > on JDK > 1.5... > > Juergen > > > =A0 -----Original Message----- > =A0 From: spr...@li... > [mailto:spr...@li...]On=20 > Behalf Of > Alef Arendsen > =A0 Sent: Wednesday, March 30, 2005 4:32 PM > =A0 To: spr...@li... > =A0 Subject: [Springframework-developer] Changes to build.xml to run > autobuilds build on 1.5 as well > > > =A0 If nobody objects, I'll be modifying the build file to include an=20= > extra > property that indicates whether or not you want to build on 1.5. I=20 > want to > have the autobuild build for both 1.5 and 1.4 but I can't get this to=20= > work > while maintaining the build numbers. To in addition to detecting the=20= > Java > version automatically, there will be a property you can specify when=20= > issuing > an Ant command. > > =A0 regards, > =A0 Alef > |