|
From: Keith D. <ke...@in...> - 2005-03-24 04:43:46
|
Dave, Good point about the flow execution manager - it should be configurable, really, with a default as is. I fixed this. I also improved the ActionExecutionException - adding in the ActionState.NamedAction contextual information. Keith _____ From: spr...@li... [mailto:spr...@li...] On Behalf Of David Hewitt Sent: Wednesday, March 23, 2005 4:30 AM To: spr...@li... Subject: RE: [Springframework-developer] Web Flow progress I have a couple of comments about Webflow based on my usage in a current application. Firstly, FlowController is responsible for creating its own HttpFlowExecutionManager - I guess I don't understand why this isn't a dependency that's injected in the traditional way. I had to subclass the existing flow execution manager to get some behaviour I desired (storing flow executions in the servlet context, rather than the session), and the current structure meant I also had to subclass FlowController. Secondly, it would be nice if the exceptions thrown to indicate missing state or actions actually provided accessors to expose which state/action was missing. Currently I have immplemented fallback logic such that if an action is not found in the current flow, I can check in the parent flow(s) and handle back button issues with subflows quite elegantly. My logic would have been simpler if the caught exception indicated the state/action that was the problem. Thanks, -Dave _____ From: spr...@li... on behalf of Erwin Vervaet Sent: Tue 22/03/2005 20:22 To: spr...@li... Subject: [Springframework-developer] Web Flow progress All, We've been making very good progress on the web flow system the last few days. Things are shaping up for a preview release that might come as soon as next weekend! The code is in good shape again and all JavaDoc is up-to-date. All samples are also working again. For those with an interest in web flows, I fully recommend that you take a look at the code that is in CVS right now (http://cvs.sourceforge.net/viewcvs.py/springframework/spring/sandbox/src/or g/springframework/web/flow/) and let us know what you think! Any input would be appreciated! Issues left to work out (not necessarily for the preview release :): * Conditional transitions: basic support is there (via TransitionCriteria interface and a simple OgnlTransitionCriteria implementation), but details have to be worked out: - how to integrate this into XML flow definitions? - scope precedence? or should all scopes be merged before being evaluated by the expression? * Token based transitions (e.g. <transition on="countrySelected" to="register.${request.country}"/>): do we need this? There is no support for this at the moment. * Does the RequestContext need to keep track of a history of events signaled during its lifecycle? It's not the case for the moment but would be simple to implement. Also, do we need a query interface to find an event parameter across all signaled events for a particular request? Are there any good use-cases for this? * Do we need some convenience accessor on the RequestContext to find attributes in any scope: try request scope first, then fall back on flow scope? This would be simple to add. Erwin Vervaet erw...@er... ------------------------------------------------------- This SF.net email is sponsored by: 2005 Windows Mobile Application Contest Submit applications for Windows Mobile(tm)-based Pocket PCs or Smartphones for the chance to win $25,000 and application distribution. Enter today at http://ads.osdn.com/?ad_id=6882 <http://ads.osdn.com/?ad_id=6882&alloc_id=15148&op=click> &alloc_id=15148&op=click _______________________________________________ Springframework-developer mailing list Spr...@li... https://lists.sourceforge.net/lists/listinfo/springframework-developer ________________________________________________________________________ This e-mail has been scanned for all viruses by Star. The service is powered by MessageLabs. For more information on a proactive anti-virus service working around the clock, around the globe, visit: http://www.star.net.uk ________________________________________________________________________ ________________________________________________________________________ This e-mail has been scanned for all viruses by Star. The service is powered by MessageLabs. For more information on a proactive anti-virus service working around the clock, around the globe, visit: http://www.star.net.uk ________________________________________________________________________ |