Re: [Springframework-developer] Added support for JDBC RowSets

[Juergen H. <ju...@in...>]

Thomas, everybody,

I've just started reviewing this. Looks good!

The only basic thing that needs to change is the location of the SqlRowSet
classes: It currently introduces a circular package dependency between
"jdbc.core" and "jdbc.core.support". The support package should not contain
classes that are directly referenced from "jdbc.core", but this is
unfortunately the case here.

I'll move the SqlRowSet classes to a package "jdbc.support.rowset". I guess
this is worth it, as we have 4 classes there, and the row set stuff itself
is actually pretty independent from JdbcTemplate in the first place.

Additionally, I'll also factor the creation of a CachedRowSet instance out
into a method that can easily be overridden. CachedRowSetImpl, which we're
using by default, is a "com.sun" class, which I feel a little bit
uncomfortable with.

I'd also like to ask for a feature freeze for 1.2 RC1. We're already late; I
intend to finally release RC1 on Wednesday.

Refining CannotAcquireLockException and co is still fine with me, but please
keep me up to date on what's happening there. If someone reworks
documentation or the like, that's fine too, of course - but please refrain
from adding new features, even from trivial (or trivial-looking) ones.

Juergen



-----Original Message-----
From: spr...@li...
[mailto:spr...@li...]On Behalf
Of Thomas Risberg
Sent: Sunday, March 20, 2005 7:24 PM
To: spr...@li...
Subject: [Springframework-developer] Added support for JDBC RowSets


I have moved the JDBC RowSet support over from the Sandbox.  I will be
adding more JavaDocs and some tests later today - just wanted to get
the initial support committed.

Here is a brief usage sample:

         SqlRowSet rset = getJdbcTemplate().queryForRowSet(
                 "select id, name from mytest where id > ? and name < ?",
                 new Object[] {new Long(1), "Z"});
         int i = 0;
         while (rset.next()) {
             i++;
             System.out.println("Row" + i + " " + rset.getString(2));
         }

Thomas




-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer