Re: [Springframework-developer] Hibernate 3 annotations in 1.2 rc1

[Juergen H. <ju...@in...>]

Good point regarding "preview" in conjunction with JDK 1.5. Preview is
probably the wrong term anyway. This is essentially a building and packaging
issue: The JDK 1.5 transaction annotation support must be built with
"-target 1.5", while the rest of Spring obviously should be built with
"-target 1.3".

So there are just two options, as far as I see:

* either turn the JDK 1.5 transaction annotations into a separate download,
which will be built with JDK 1.5 as opposed to the main download

* or create a separate source tree within the main download (e.g.
"tiger/src" and "tiger/test"), built with "-target 1.5" as opposed to the
main sources which get built with "-target 1.3"

The latter option is fine with me too. The separate source tree would
essentially just contain the packages
"org.springframework.transaction.annotations" and
"org.springframework.jmx.export.annotations" (which I would suggest as
package names), compiled into a separate jar file in a separate build step.

Of course, we also need to decide on a final naming strategy for
annotations. "Transactional" sounds good to me. I would also suggest to
rename the PropagationType enumeration to PropagationBehavior, for
consistent naming - or go for "Propagation" and "Isolation" as enumeration
names.

BTW, I don't see much point in the AnnotationsAttributes implementation of
our Attribute facade, as used in the AnnotationsJmxAttributeSource. Why not
access the JDK 1.5 annotation API directly there? After all, the annotations
have to be converted to the JmxAttributeSource return values anyway.

The JDK 1.5 annotation model and our Attributes facade simply don't match
well, so I guess we need to go forward with both in parallel. The Attributes
facade provides value even for Commons Attributes as sole target (e.g. for
testing). I must say I appreciate the ability to use existing attribute
classes with Commons Attributes...

So how do we move forward with this? We should move the code to the main CVS
module ASAP, clarify the class naming, and also prepare the build script to
handle the different target JDKs. I can certainly care for this, but I would
appreciate some help. After all, 1.2 RC1 should go out this week!

Juergen



-----Original Message-----
From: spr...@li...
[mailto:spr...@li...]On Behalf
Of Rod Johnson
Sent: Monday, March 14, 2005 7:32 PM
To: spr...@li...
Subject: Re: [Springframework-developer] Hibernate 3 annotations in 1.2
rc1


Juergen

> I would suggest to do a preview/add-on download of the JDK 1.5 transaction
> annotation support plus the corresponding JPetStore version, probably
around
> the time of Spring 1.2 final (alongside the Web Flow preview download). No
> problem to build with JDK 1.5 there!
Are you suggesting that transaction annotation support should
essentially slip out of 1.2 proper? I'm not keen on this. I don't see
why it should be a "preview" or why it should take that long to release.
After all, 1.5 has been released for some time now. We don't need to
"preview" stuff built on it.

Rgds
Rod



-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer