|
From: Thomas R. <tho...@tr...> - 2005-03-06 01:48:43
|
Juergen I added that interface because, originally, during Geronimo integration we were looking to hook into the registration of the MBeans. It turns out this is no longer necessary so I guess we can just push registration back into MBeanExporter and remove RegistrationStrategy altogether. I don't think it has any other use case beyond the one I described and that is no longer required. My vote is to remove it. Rob (from Thomas' laptop) On Mar 5, 2005, at 6:35 PM, Juergen Hoeller wrote: > Rob, > > I've noticed that you've added a RegistrationStrategy interface to the > JMX > support. I'd like to suggest a couple of refinements: > > * MBeanExporter shouldn't modify the state of a passed-in > RegistrationStrategy instance: the passed-in instance is supposed to be > fully initialized. > > * Consequently, the MBeanServerAwareRegistrationStrategy subinterface > is not > ideal. I would prefer registerMBean and unregisterMBean methods with an > MBeanServer passed in as argument (which implementations can choose to > ignore). > > * DefaultRegistrationStrategy should probably be renamed to > SimpleRegistrationStrategy. What it really does is straighforward > delegation > to the MBeanServer: the simplest registration strategy that might > possibly > work. > > * Let's move the RegistrationStrategy interface and the > DefaultRegistrationStrategy class to the "jmx" package itself. Those > two > classes are not really worth their own subpackage, and the root > package is > still pretty thin anyway. > > What do you think? I'm also curious what alternative > RegistrationStrategy > implementations you have in mind (i.e. why you decided to introduce the > strategy). > > Once we've nailed down those remaining issues, I'll move the JMX > support > over to the main sources. Spring 1.2 RC1 is just around the corner :-) > > Juergen > > > > ------------------------------------------------------- > SF email is sponsored by - The IT Product Guide > Read honest & candid reviews on hundreds of IT Products from real > users. > Discover which products truly live up to the hype. Start reading now. > http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click > _______________________________________________ > Springframework-developer mailing list > Spr...@li... > https://lists.sourceforge.net/lists/listinfo/springframework-developer > > |