Re: [Springframework-developer] I don't like the DefaultXmlBeanDefinitionParser

[Dmitriy K. <dko...@ru...>]

Refactoring to improve the design of the existing code (maintainability, 
readability, etc.) is always good, iMO, provided that there is a 
comprehensive test suite to bullet proof the refactoring. I say go 
ahead, do it, and post it for the peer review.

Regards,
Dmitriy.


Steven Devijver wrote:

>During my many quest (sorry for the WoW terminology) of understanding
>Spring I endeavoured into the DefaultXmlBeanDefinitionParser code more
>than once. It's very hard to understand exactly what happens in there.
>
>Some refactoring could make it easier for clever people to tweak the
>Spring config format to their own needs. While the need for these
>tweaks may not be obvious to anyone of us there's nothing wrong with
>that. Supporting this can only improve the product. I don't think
>there's any need to anxiety since changes to the Spring core are
>thoroughly vetted.
>
>
>On Tue, 22 Feb 2005 13:54:48 +0000, Rob Harrop <ro...@ca...> wrote:
>  
>
>>I guess I just don't grasp it, but what benefit do contributions give my
>>application as opposed to the current configuration mechanism? Can you
>>give me a use case comparing the use of contributions to that of
>>standard DI configuration?
>>
>>Rob
>>
>>Martin Kersten wrote:
>>
>>    
>>
>>>>I think the main reason to use the W3C DOM API directly is to avoid
>>>>the need for an extra dependency (e.g. JDOM) just to parse the XML
>>>>bean definitions. You end up with an "less than elegant"
>>>>implementation in DefaultXmlBeanDefinitionParser, but in this case
>>>>the benifits outweigh the costs.
>>>>        
>>>>
>>>I don't talk about using JDOM. There is no need to change to another
>>>library. I just talking about plain and simply refactoring.
>>>
>>>The cost would be about two or three man hours. I document this
>>>refactoring for later review for my own, so I would take
>>>as double that long. The good news is that I have a set of test cases to
>>>test against. So it will be real fast. So hopefully in a couple of hours
>>>I can show you the result and you can compare.
>>>
>>>
>>>Cheers,
>>>
>>>Martin (Kersten)
>>>
>>>
>>>-------------------------------------------------------
>>>SF email is sponsored by - The IT Product Guide
>>>Read honest & candid reviews on hundreds of IT Products from real users.
>>>Discover which products truly live up to the hype. Start reading now.
>>>http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
>>>_______________________________________________
>>>Springframework-developer mailing list
>>>Spr...@li...
>>>https://lists.sourceforge.net/lists/listinfo/springframework-developer
>>>
>>>
>>>      
>>>
>>-------------------------------------------------------
>>SF email is sponsored by - The IT Product Guide
>>Read honest & candid reviews on hundreds of IT Products from real users.
>>Discover which products truly live up to the hype. Start reading now.
>>http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
>>_______________________________________________
>>Springframework-developer mailing list
>>Spr...@li...
>>https://lists.sourceforge.net/lists/listinfo/springframework-developer
>>
>>
>>    
>>
>
>
>-------------------------------------------------------
>SF email is sponsored by - The IT Product Guide
>Read honest & candid reviews on hundreds of IT Products from real users.
>Discover which products truly live up to the hype. Start reading now.
>http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
>_______________________________________________
>Springframework-developer mailing list
>Spr...@li...
>https://lists.sourceforge.net/lists/listinfo/springframework-developer
>  
>