Re: [Springframework-developer] I don't like the DefaultXmlBeanDefinitionParser

[Juergen H. <ju...@in...>]

OK, that's perfectly reasonable. It sounded like you wanted to get away from
DOM completely; if all you want to do is a refactoring, then you're welcome
to do so :-) I'll consider including this in Spring 1.2 RC1, provided that
we agree on the design.

So do I understand correctly that you intend to introduce some DOM
abstraction to make the actual XML bean definition parsing code nicer? I
guess a full abstraction would be overkill; some DOM helper stuff should be
sufficient, IMO.

Juergen


-----Original Message-----
From: spr...@li...
[mailto:spr...@li...]On Behalf
Of Martin Kersten
Sent: Tuesday, February 22, 2005 2:28 PM
To: spr...@li...
Subject: Re: [Springframework-developer] I don't like the
DefaultXmlBeanDefinitionParser


> I think the main reason to use the W3C DOM API directly is to
> avoid the need for an extra dependency (e.g. JDOM) just to
> parse the XML bean definitions. You end up with an
> "less than elegant" implementation in DefaultXmlBeanDefinitionParser,
> but in this case the benifits outweigh the costs.

I don't talk about using JDOM. There is no need to change to another
library. I just talking about plain and simply refactoring.

The cost would be about two or three man hours.
I document this refactoring for later review for my own, so I would take
as double that long. The good news is that I have a set of test cases to
test against. So it will be real fast. So hopefully in a couple of hours
I can show you the result and you can compare.


Cheers,

Martin (Kersten)


-------------------------------------------------------
SF email is sponsored by - The IT Product Guide
Read honest & candid reviews on hundreds of IT Products from real users.
Discover which products truly live up to the hype. Start reading now.
http://ads.osdn.com/?ad_id=6595&alloc_id=14396&op=click
_______________________________________________
Springframework-developer mailing list
Spr...@li...
https://lists.sourceforge.net/lists/listinfo/springframework-developer