[Springframework-developer] Please check these two things

[Dave B. <dbr...@qi...>]

These may be problems, and then again maybe not. But they seem odd/wrong =
to me


1) In org.springframework.aop.interceptor.ConcurrencyThrottleInterceptor

in method invoke

uses wait on 'this'

In my mind you are exposing your synchronization strategies as a public =
artifact, which leaves this class open to failure due to client code.=20
The client code may unwittingly us an instance of this class to do it's =
own synchronization, and totally screw up this class.
I would recommend doing synchronizations (especially the use of =
wait/notify) on a private member so client code can not effect it.



2) In org.springframework.jdbc.object.BatchSqlUpdate

in method update, you do

  if (!this.parameterQueue.isEmpty() && =
args.equals(this.parameterQueue.getLast())) {

this is the same as using     args =3D=3D this.parameterQueue.getLast()

or in other words, are these objects the same object. I assume you want =
to compare the elements of the array?