|
From: Artur K. <kar...@as...> - 2005-02-18 18:27:44
|
Colin Sampaleanu wrote: > +1. > > My only concern with using the patch in JIRA vs. making a new tree of > code based on existing one is if the patch has really been kept up to > date properly. There have been a pretty large number of Hibernate code > changes/fixes since then. It seems a shame to throw away that work, but > on the other hand it might be safer to start from scratch... I did the first patch and know that there were a lot of changes in classic hibernate support in spring since then (both in implementation and test suite). It would be much better to make fresh copy of hibernate into sandbox tree and refactor it. It took me two evnings using Elipse to prepare patch included in SPR-300 JIRA, to be honest most of time I spent learning MockObjects :)). Artur -- ,,Wine, jako emulator Windows...'' -- WO, pcoa ,,As Wine's name says: "Wine Is Not an Emulator"'' -- WineHQ, FAQ |