Re: [Springframework-developer] OGNL property configurer bean factory post-processor

[Drew D. <dr...@og...>]

Estes, James D - St. Louis, MO wrote:

>Cool, more ammo for factoring out the parts of
>PropertyPlaceholderConfigurer that do the digging through the bean
>definitions and creating an abstract PlaceholderConfigurer.
>
>http://opensource.atlassian.com/projects/spring/browse/SPR-260
>(IGNORE the examples).
>  
>

That's a good comment.  The JIRA report on this should get implemented, 
I think - you've got some good ideas there.

I was wondering about the abstract superclass thing myself; it seems 
that the functionality that the PropertyPlaceholderConfigurer implements 
would be 95% taken care of by a generic tree walker.  Considering the 
usual high level of reusability in the Spring code it suprised me to see 
such a "blob" of useful code not being abstracted.

Bear in mind that the PPC code needs to be careful detecting start and 
end tokens.  The PPC works like a token substituter - it scans strings 
and replaces possible multiple occurences within values, keys, etc.  The 
OGNL replacer does not allow this because the result of the evaluation 
can be any object; therefore the totality of the <value> contents  or 
attribute value must be :[ <ognl expr> ].

- Drew

-- 
+---------------------------------+
< Drew Davidson | OGNL Technology >
+---------------------------------+
|  Email: dr...@og...          /
|    Web: http://www.ognl.org   /
|    Vox: (520) 531-1966       <
|    Fax: (520) 531-1965        \
| Mobile: (520) 405-2967         \
+---------------------------------+