[Springframework-developer] Some code remarks

[Pieter C. <pie...@on...>]

Hi,

I browsed a bit through the Spring source code and have some remarks 
about possible code improvements.

1) JavaScriptUtils can be replaced with 
StringEscapeUtils.escapeJavaScript(), which is in commons-lang 2.0 
(apparently the current commons-lang version is an old one where this 
class isn't included)

2) HtmlUtils can be replaced with StringEscapeUtils.escapeHtml()

3) The class javadoc of org.springframework.core.Constants mentions 
asInt(), which doesn't exist

4) RegexpMethodPointcutAdvisor uses perl5=true by default.  Isn't it 
possible to use
private boolean perl5 = JdkVersion.getMajorJavaVersion()<JdkVersion.JAVA_14;
This doesn't require the perl5=false property in all advisors if you're 
running jdk 1.4

Greetings,

Pieter