|
From: Colin S. <col...@ex...> - 2005-01-09 14:50:09
|
I did it for iBatis because I had an explicit need for it, but I agree about doing it for other libraries that also have a DTD, like Hibernate... Juergen Hoeller wrote: >I see. It's not a bad idea, in general, in particular as the DTDs aren't >easy to find in the iBATIS distribution. I just wonder whether it makes >sense to only do this for iBATIS... Shouldn't we do this for Hibernate too >then, for example? > >Juergen > > >-----Original Message----- >From: spr...@li... >[mailto:spr...@li...]On Behalf >Of Colin Sampaleanu >Sent: Sunday, January 09, 2005 3:45 AM >To: spr...@li... >Subject: Re: [Springframework-developer] jpetstore upgraded to iBatis >2.0 > > >I added the DTD mainly because the DTDs are sometimes handy to have, >especially when there is no internet connectivity or something needs to >be looked up manually. If you object to it there we can just remove it. > >Colin > >Juergen Hoeller wrote: > > > >>Colin, >> >>I've noticed that you added the iBATIS DTDs to our lib/ibatis directory in >>CVS. What do we need them for? >> >>I'll remove ibatis-common.jar and jdom.jar from CVS, BTW, as they are only >>needed to run SQL Maps 1.3. I'll only keep ibatis-sqlmap.jar, for building >>our SQL Maps 1.3 support. >> >>Juergen >> >> >>-----Original Message----- >>From: spr...@li... >>[mailto:spr...@li...]On Behalf >>Of Juergen Hoeller >>Sent: Tuesday, January 04, 2005 7:25 PM >>To: spr...@li... >>Subject: RE: [Springframework-developer] jpetstore upgraded to iBatis >>2.0 >> >> >>That's great, Colin! I'll give the revised JPetStore a try as soon as I >> >> >can. > > >>I originally planned such an upgrade for 1.2 RC1, but it's a good fit for >>1.1.4 too. iBATIS 2.0 is certainly already mainstream. As of Spring 1.2, we >>should probably deprecate the iBATIS 1.x support classes, and remove them >>completely in Spring 1.3. >> >>On a related note, I recently implemented iBATIS 2.0 TypeHandlers that >>delegate to Spring's LOB support. I put them into our sandbox for the time >>being, as they were not able to work due to some restriction in the iBATIS >>TypeHandler support. Clinton addressed that issue in the just-released >>iBATIS 2.0.9, so I'll complete those LOB TypeHandlers and move them over to >>the main source tree for Spring 1.1.4. >> >>Juergen >> >> >>-----Original Message----- >>From: spr...@li... >>[mailto:spr...@li...]On Behalf >>Of Colin Sampaleanu >>Sent: Tuesday, January 04, 2005 6:48 PM >>To: spr...@li... >>Subject: [Springframework-developer] jpetstore upgraded to iBatis 2.0 >> >> >>I spent some time and upgraded jpetstore to use iBatis 2.0 instead of >>1.0 like it was using. It was incredibly tedious since almost every >>element in the mapping files had to be renamed, but on the other hand >>the conversion was very straightforward, with essentailly a one-to-one >>conversion from old to new, so I hope I didn't break anything. It seems >>to work ok, but if anybody else has 5 minutes to pull it out and play >>around with it a bit to try to catch any breakage, that would be good. >> >>We'll have to update the jpetstore under autobuilds too. I'm not clear >>if that's modified at all from the original. If not, the changed files >>can just be copied over. >> >>Colin >> >> |