Re: [Springframework-developer] Suspicion of problem with getLastModified

[<jo....@us...>]

Hi,

we extend Spring for a webdav-based framework, which means that=20
service() must be overridden to allow for other HTTP methods. Other=20
than that, it's important for us that the framework uses Spring's=20
default behavior  wherever possible, since it's well written,=20
maintained and documented :)

Since your preferred solution to the last-modified problem is to go=20
back to do...(), could you please make serviceWrapper() protected? That=20=

gives us the option to override service() ourselves without having to=20
manually duplicate the functionality of FrameworkServlet and=20
DispatcherServlet.

jo

P=E5 20. okt. 2004 kl. 23.30 skrev j=FCrgen h=F6ller [werk3AT]:

> Thanks for spotting this, Olivier! This has effectively been broken=20
> since 1.1 RC1, when FrameworkServlet was changed from overriding=20
> "doGet"/"doPost" to overriding "service(HttpServletRequest,=20
> HttpServletResponse)". Unfortunately, this slipped through, because=20
> the test suite just simulates "getLastModified" calls - it doesn't go=20=

> through Servlet's "service" method.
>
> I wonder why this hasn't been reported before... Probably because it=20=

> doesn't cause a failure - it simply sends the response back every time=20=

> rather than "not modified". Anyway, I've just fixed this through=20
> recoding FrameworkServlet to override "doGet"/"doPost" again, and also=20=

> "doHead" and co. This lets the HttpServlet base class properly call=20
> "getLastModified" now.
>
> Juergen
>
>
> ________________________________
>
> Von: spr...@li... im Auftrag=20=

> von Olivier Jolly
> Gesendet: So 17.10.2004 15:45
> An: spr...@li...
> Betreff: [Springframework-developer] Suspicion of problem with=20
> getLastModified
>
>
>
> Hi,
>   after the problem raised in the forum :
> http://forum.springframework.org/viewtopic.php?t=3D1385 , I checked =
this=20
> a
> bit and noticed that all the mechanisms developped in the
> DispatcherServlet to get the last modification date and such were
> relying on the fact that getLastModified in called on=20
> DispatchedServlet,
> ok. However, the jsr152 implementation of tomcat (which is probably a
> common one) call the getLastModified in the
> service(HttpServletRequest,HttpServletResponse), which is overidden in
> the FrameworkServlet, and no code related to getLastModified is called
> in the overidden method.
>   I propose to reenable the getLastModified call by adding in the
> service method of FrameworkServlet the code used to handle the last
> modification, hance the proposed attached patch.
>   If I haven't forgot something, which would explain that it should=20
> work
> as it is now but that I and the forum poster didn't see, please yell =
at
> me, else I'll open a jira issue to remember it.
>   Regards
> Olivier
>
>
>
>
> -------------------------------------------------------
> This SF.net email is sponsored by: IT Product Guide on=20
> ITManagersJournal
> Use IT products in your business? Tell us what you think of them. Give=20=

> us
> Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out=20=

> more
> http://productguide.itmanagersjournal.com/guidepromo.tmpl
> _______________________________________________
> Springframework-developer mailing list
> Spr...@li...
> https://lists.sourceforge.net/lists/listinfo/springframework-developer