Re: [Springframework-developer] Suspicion of problem with getLastModified

[<jue...@we...>]

Thanks for spotting this, Olivier! This has effectively been broken =
since 1.1 RC1, when FrameworkServlet was changed from overriding =
"doGet"/"doPost" to overriding "service(HttpServletRequest, =
HttpServletResponse)". Unfortunately, this slipped through, because the =
test suite just simulates "getLastModified" calls - it doesn't go =
through Servlet's "service" method.
=20
I wonder why this hasn't been reported before... Probably because it =
doesn't cause a failure - it simply sends the response back every time =
rather than "not modified". Anyway, I've just fixed this through =
recoding FrameworkServlet to override "doGet"/"doPost" again, and also =
"doHead" and co. This lets the HttpServlet base class properly call =
"getLastModified" now.
=20
Juergen
=20

________________________________

Von: spr...@li... im Auftrag =
von Olivier Jolly
Gesendet: So 17.10.2004 15:45
An: spr...@li...
Betreff: [Springframework-developer] Suspicion of problem with =
getLastModified



Hi,
  after the problem raised in the forum :
http://forum.springframework.org/viewtopic.php?t=3D1385 , I checked this =
a
bit and noticed that all the mechanisms developped in the
DispatcherServlet to get the last modification date and such were
relying on the fact that getLastModified in called on DispatchedServlet,
ok. However, the jsr152 implementation of tomcat (which is probably a
common one) call the getLastModified in the
service(HttpServletRequest,HttpServletResponse), which is overidden in
the FrameworkServlet, and no code related to getLastModified is called
in the overidden method.
  I propose to reenable the getLastModified call by adding in the
service method of FrameworkServlet the code used to handle the last
modification, hance the proposed attached patch.
  If I haven't forgot something, which would explain that it should work
as it is now but that I and the forum poster didn't see, please yell at
me, else I'll open a jira issue to remember it.
  Regards
Olivier