|
From: Rob H. <ro...@ca...> - 2004-10-02 21:49:47
|
Seth, I have meaning to add support for beans that are already MBeans for ages. I think it will fit nicely with the autodetect support I added. I might add a refactoring to move the register and JMXify logic into separate classes, although much of the actual MBeans info is built in the MetadataAssemblers anyway. It is good to see that you are using this and it is working for you. Thanks very much for the feedback! Rob Seth Ladd wrote: >Hello, > >What's nice about JmxMBeanAdapter is that it's an easy way to say >"Please take this bean and register it with the MBean Server". For >normal beans, it's also nice because it'll make a ModelMBean out of >the normal bean, before registration. > >This could be a bit more flexible, though. JmxMBeanAdapter should >recognize if the bean is already a DynamicMBean. If it is, it should >not get wrapped in a ModelMBean (since it already is an MBean). > >The act of turning Spring Beans into MBeans and the act of registering >MBeans with the server (and unregistering at shutdown) might be >decoupled. This way, one chunk of code creates MBeans from non >mbeans, and another chunk of code does all the registering and >unregistering of MBeans (including those that didn't need to get >converted in the first place). > >I added a quick if (bean instanceof DynamicMBean) check in >JmxMBeanAdapter, but the refactoring seems like it'll help split these >two concerns. > >The JMX code is going to be a real killer feature for Spring! >Seth > > >------------------------------------------------------- >This SF.net email is sponsored by: IT Product Guide on ITManagersJournal >Use IT products in your business? Tell us what you think of them. Give us >Your Opinions, Get Free ThinkGeek Gift Certificates! Click to find out more >http://productguide.itmanagersjournal.com/guidepromo.tmpl >_______________________________________________ >Springframework-developer mailing list >Spr...@li... >https://lists.sourceforge.net/lists/listinfo/springframework-developer > > > > |