Re: [Springframework-developer] Formatting in the face of tab usage

[Colin S. <col...@ex...>]

We should probably just take a real vote. Doing it one way or another is 
not going to appeal to some people in the group, but everybody can work 
with either setup; so there's no way we'll ever have everybody happy, 
and a vote is the democratic thing (the spoiler in this is of course 
that you and Juergen produce most of the code).

Spaces would break comparisons depending on the actual tool used. A lot 
of diff tools can ignore whitespace. CVS itself will consider the two 
versions different.


Rod Johnson wrote:

>Yes, Juergen's the one responsible :-)
>
>I would prefer to keep tabs. I know I'm in a minority, but I hate spaces.
>Also if we switch wouldn't it would break all revision history comparisons.
>But certainly there are a few files untidy, with very long lines.
>
>I'm not a big fan of parameter alignment in general.
>
>Rgds
>Rod
>
>----- Original Message -----
>From: "jürgen höller [werk3AT]" <jue...@we...>
>To: <spr...@li...>
>Sent: Tuesday, July 27, 2004 5:51 PM
>Subject: Re: [Springframework-developer] Formatting in the face of tab usage
>
>
>I see, you refer to the parameter aligning in new lines, which I do have set
>in my IDEA code style. That's indeed messing up things for other tab sizes,
>when usign hard tabs.
>
>So we should probably not use parameter aligning as long as we stay with
>hard tabs then... But it just looks nicer, IMO - if the tab size matches ;-)
>
>Juergen
>
>
>-----Original Message-----
>From: spr...@li...
>[mailto:spr...@li...]On Behalf
>Of Colin Sampaleanu
>Sent: Tuesday, July 27, 2004 6:15 PM
>To: spr...@li...
>Subject: [Springframework-developer] Formatting in the face of tab usage
>
>
>I was looking at DefaultXmlBeanDefinitionParser, and it's clear that
>whoever formatted it (Juergen I guess) is using an editor with hard tabs
>set to 2 characters (not the more common 4 or 8). I say this because for
>some method calls, the continuation line lines up method args, but only
>if tabs are set to 2. If they are 4 or 8, the continuation line is _way_
>over to the right.
>
>While I'm not a big fan of hard tabs, as per our discussion last fall, I
>can live with them. But what this means is that any continuation lines
>need to be simply one or more tabs farther in than the line before it.
>If you format lines so that you use hard tabs to line up with some
>non-tab text in a line above, this will completely mess up for other
>people using different tab settings. Ditto with adding some real spaces
>(with or without tabs) at the beginning of the line. Essentially _all_
>indentation has to be based only on tabs.
>
>Colin
>  
>